From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6519C43334 for ; Tue, 12 Jul 2022 13:34:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hofK5CHFCxH/JsB/wD3WBKj9zC8Q5xI/urO9kDs+7uY=; b=mrl8Sqkkke4mG5 IirTN72dX5/imIGUeyX6K31lpBYIhl65XAwTVIFySC+JuU0Enqa2q2fYttf7lpyrhhdhwpJDBFY4T ZiRM27SpcNTyZfhcfbHovUIyW40wZkvDMGPn83zv5308b411Y0XCS/OET71ZbRMnsevwX6hv9ssY2 mBi1WTgAB3/UiPEhfLjJ7VY8DE3LFN1wUbVJr1rXTUfctvM7pSm1NR3BJA2dAN71ZYA8PcwUPoGHG sRqKDjUFLpK9WYXiz458w70zDzelPNFivu+S1MwGzjvKjlfFmY6pQVkTxvXzZk218auhEU227Mmyg 66SPIv7sANhr5LIkl3DA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBG19-00BNfJ-0O; Tue, 12 Jul 2022 13:33:36 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBG0v-00BNUC-1e for linux-arm-kernel@lists.infradead.org; Tue, 12 Jul 2022 13:33:22 +0000 Received: by mail-wr1-x42f.google.com with SMTP id r14so11230196wrg.1 for ; Tue, 12 Jul 2022 06:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=1FNQrGGLfgdOgMRKiUwsbzE3SGEjtGBgzxsXljwQUHE=; b=hTDsqLoXRixjt/Sxz4pnsbxPZ2ChVkl5G3Efink/BugEruXacu1c14dFTFwKa0c3gY o/+eryoGjW9zyuyJ7wemDQirD4D04/nXfYPkHa1G3NtRldyCDQ/2zs/zyzMfMEI8HTWr iYlsUd6VZ1BdSYB6OpRejTRfbS/3+NfNcv56pt8/W3na5GXCHJ5oq4VO25FksgV9cQFP OOzwUmFoXuLhNwWST4eb5B14ImeEhE4+FdqOm1DF6nMbC5rCYGWDPXDwqd7SkScILR7N gec2/C7+2gfE3s/eAraUC8ItcbP1D33rLOfkl66gtcp/BtJDaEyGPr/I+63MxweebsQZ wKaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=1FNQrGGLfgdOgMRKiUwsbzE3SGEjtGBgzxsXljwQUHE=; b=x/0AhOnJfU+dMqrSIS3geoBwP/8zwzhkZPqSRgLGspc7i+NEdAggAaOdLWI8uhmYM9 OTVEgSECpI7wiSB2FyWmES2ZUMvSEJRehLSOsWLsh56laJBDXvBoES4VIhvtaM4tqtTm 4leO9p6EDokqPmHXuCRvRE/b+Yarszs3M2mDTVLzqLF8cIHqu1dv+smUWI6CbP8hIyno WzCiDAYN3PCfcXe4zYzZKQz06CrsbA35Lmh2z/2G5mMeZFZo35SnuLB01hHcXofoKijT 8n8vXNCY2xvDqZGiUpnsvixNJDtWkIqebziXpDE6PXJL6q/XgktOxmJdRe5I2NLm3Hfm mEjQ== X-Gm-Message-State: AJIora/ctjNZvDYitihpjF6Id5i/iqJNl7UnEisRo5BlqxarpiiLzDAP eKNv95krkSxwKF9QpUikhyOcDA== X-Google-Smtp-Source: AGRyM1tDxqUM6cVCSs98mVzMblL7DYw1ebw4b5m50i0FuBi3jTzjyS1F+201+kxSFQ4/IZUzwFtrpw== X-Received: by 2002:a05:6000:178c:b0:21d:b6d0:11a8 with SMTP id e12-20020a056000178c00b0021db6d011a8mr1741057wrg.547.1657632795572; Tue, 12 Jul 2022 06:33:15 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id g4-20020adff404000000b0021d87798237sm8320371wro.20.2022.07.12.06.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 06:33:14 -0700 (PDT) Date: Tue, 12 Jul 2022 14:33:13 +0100 From: Lee Jones To: Francesco Dolcini Cc: Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Ahmad Fatoum Subject: Re: [PATCH v1 1/4] mfd: stmpe: Probe sub-function by compatible Message-ID: References: <20220712110232.329164-1-francesco.dolcini@toradex.com> <20220712110232.329164-2-francesco.dolcini@toradex.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220712110232.329164-2-francesco.dolcini@toradex.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220712_063321_130343_9424E02B X-CRM114-Status: GOOD ( 26.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxMiBKdWwgMjAyMiwgRnJhbmNlc2NvIERvbGNpbmkgd3JvdGU6Cgo+IFVzZSBzdWIt ZnVuY3Rpb24gb2ZfY29tcGF0aWJsZSBkdXJpbmcgcHJvYmUsIGluc3RlYWQgb2YgdXNpbmcgdGhl IG5vZGUKPiBuYW1lLiBUaGUgY29kZSBzaG91bGQgbm90IHJlbHkgb24gdGhlIG5vZGUgbmFtZXMg ZHVyaW5nIHByb2JlLCBpbgo+IGFkZGl0aW9uIHRvIHRoYXQgdGhlIHByZXZpb3VzbHkgaGFyZC1j b2RlZCBub2RlIG5hbWVzIGFyZSBub3QgY29tcGxpYW50Cj4gdG8gdGhlIGxhdGVzdCBuYW1pbmcg Y29udmVudGlvbiAodGhleSBhcmUgbm90IGdlbmVyaWMgYW5kIHRoZXkgdXNlCj4gdW5kZXJzY29y ZXMpLCBhbmQgaXQgd2FzIGJyb2tlbiBieSBtaXN0YWtlIGFscmVhZHkgb25jZSBbMV0uCj4gCj4g V2hpbGUgZG9pbmcgdGhpcyBjaGFuZ2UgYHJvdGF0b3JgIGVudHJ5IHdhcyByZW1vdmVkLCBpdCBp cyBub3QKPiB1c2VkIGluIGFueSBkZXZpY2UgdHJlZSBmaWxlLCB0aGVyZSBpcyBubyBjZWxsIGRl ZmluZWQsIGl0J3MganVzdCBkZWFkCj4gbm9uLXdvcmtpbmcgY29kZSB3aXRoIG5vIG9mX2NvbXBh dGlibGUgZm9yIGl0Lgo+IAo+IFsxXSBjb21taXQgNTYwODZiNWU4MDRmICgiQVJNOiBkdHM6IGlt eDZxZGwtYXBhbGlzOiBBdm9pZCB1bmRlcnNjb3JlIGluIG5vZGUgbmFtZSIpCj4gCj4gU3VnZ2Vz dGVkLWJ5OiBBaG1hZCBGYXRvdW0gPGEuZmF0b3VtQHBlbmd1dHJvbml4LmRlPgo+IFNpZ25lZC1v ZmYtYnk6IEZyYW5jZXNjbyBEb2xjaW5pIDxmcmFuY2VzY28uZG9sY2luaUB0b3JhZGV4LmNvbT4K PiAtLS0KPiAgZHJpdmVycy9tZmQvc3RtcGUuYyB8IDMxICsrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9u cygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9zdG1wZS5jIGIvZHJpdmVycy9tZmQv c3RtcGUuYwo+IGluZGV4IGFlYjllYTU1Zjk3ZC4uOTBhMDdhOTQ0NTVmIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvbWZkL3N0bXBlLmMKPiArKysgYi9kcml2ZXJzL21mZC9zdG1wZS5jCj4gQEAgLTIz LDYgKzIzLDEyIEBACj4gICNpbmNsdWRlIDxsaW51eC9yZWd1bGF0b3IvY29uc3VtZXIuaD4KPiAg I2luY2x1ZGUgInN0bXBlLmgiCj4gIAo+ICsjZGVmaW5lIFNUTVBFX0dQSU9fQ09NUEFUSUJMRSAg ICJzdCxzdG1wZS1ncGlvIgo+ICsjZGVmaW5lIFNUTVBFX0tFWVBBRF9DT01QQVRJQkxFICJzdCxz dG1wZS1rZXlwYWQiCj4gKyNkZWZpbmUgU1RNUEVfUFdNX0NPTVBBVElCTEUgICAgInN0LHN0bXBl LXB3bSIKPiArI2RlZmluZSBTVE1QRV9UU19DT01QQVRJQkxFICAgICAic3Qsc3RtcGUtdHMiCj4g KyNkZWZpbmUgU1RNUEVfQURDX0NPTVBBVElCTEUgICAgInN0LHN0bXBlLWFkYyIKClRoaXMgaXMg aG9ycmlibGUuCgpQbGVhc2UgcmVmcmFpbiBmcm9tIGRlZmluaW5nIGRldmljZS9jb21wYXRpYmxl IHN0cmluZ3MuCgo+ICAvKioKPiAgICogc3RydWN0IHN0bXBlX3BsYXRmb3JtX2RhdGEgLSBTVE1Q RSBwbGF0Zm9ybSBkYXRhCj4gICAqIEBpZDogZGV2aWNlIGlkIHRvIGRpc3Rpbmd1aXNoIGJldHdl ZW4gbXVsdGlwbGUgU1RNUEVzIG9uIHRoZSBzYW1lIGJvYXJkCj4gQEAgLTMyMSwxNCArMzI3LDE0 IEBAIHN0YXRpYyBzdHJ1Y3QgcmVzb3VyY2Ugc3RtcGVfZ3Bpb19yZXNvdXJjZXNbXSA9IHsKPiAg Cj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgbWZkX2NlbGwgc3RtcGVfZ3Bpb19jZWxsID0gewo+ICAJ Lm5hbWUJCT0gInN0bXBlLWdwaW8iLAo+IC0JLm9mX2NvbXBhdGlibGUJPSAic3Qsc3RtcGUtZ3Bp byIsCj4gKwkub2ZfY29tcGF0aWJsZQk9IFNUTVBFX0dQSU9fQ09NUEFUSUJMRSwKPiAgCS5yZXNv dXJjZXMJPSBzdG1wZV9ncGlvX3Jlc291cmNlcywKPiAgCS5udW1fcmVzb3VyY2VzCT0gQVJSQVlf U0laRShzdG1wZV9ncGlvX3Jlc291cmNlcyksCj4gIH07Cj4gIAo+ICBzdGF0aWMgY29uc3Qgc3Ry dWN0IG1mZF9jZWxsIHN0bXBlX2dwaW9fY2VsbF9ub2lycSA9IHsKPiAgCS5uYW1lCQk9ICJzdG1w ZS1ncGlvIiwKPiAtCS5vZl9jb21wYXRpYmxlCT0gInN0LHN0bXBlLWdwaW8iLAo+ICsJLm9mX2Nv bXBhdGlibGUJPSBTVE1QRV9HUElPX0NPTVBBVElCTEUsCj4gIAkvKiBncGlvIGNlbGwgcmVzb3Vy Y2VzIGNvbnNpc3Qgb2YgYW4gaXJxIG9ubHkgc28gbm8gcmVzb3VyY2VzIGhlcmUgKi8KPiAgfTsK PiAgCj4gQEAgLTM1MCw3ICszNTYsNyBAQCBzdGF0aWMgc3RydWN0IHJlc291cmNlIHN0bXBlX2tl eXBhZF9yZXNvdXJjZXNbXSA9IHsKPiAgCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgbWZkX2NlbGwg c3RtcGVfa2V5cGFkX2NlbGwgPSB7Cj4gIAkubmFtZQkJPSAic3RtcGUta2V5cGFkIiwKPiAtCS5v Zl9jb21wYXRpYmxlICA9ICJzdCxzdG1wZS1rZXlwYWQiLAo+ICsJLm9mX2NvbXBhdGlibGUgID0g U1RNUEVfS0VZUEFEX0NPTVBBVElCTEUsCj4gIAkucmVzb3VyY2VzCT0gc3RtcGVfa2V5cGFkX3Jl c291cmNlcywKPiAgCS5udW1fcmVzb3VyY2VzCT0gQVJSQVlfU0laRShzdG1wZV9rZXlwYWRfcmVz b3VyY2VzKSwKPiAgfTsKPiBAQCAtMzc2LDcgKzM4Miw3IEBAIHN0YXRpYyBzdHJ1Y3QgcmVzb3Vy Y2Ugc3RtcGVfcHdtX3Jlc291cmNlc1tdID0gewo+ICAKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBt ZmRfY2VsbCBzdG1wZV9wd21fY2VsbCA9IHsKPiAgCS5uYW1lCQk9ICJzdG1wZS1wd20iLAo+IC0J Lm9mX2NvbXBhdGlibGUgID0gInN0LHN0bXBlLXB3bSIsCj4gKwkub2ZfY29tcGF0aWJsZSAgPSBT VE1QRV9QV01fQ09NUEFUSUJMRSwKPiAgCS5yZXNvdXJjZXMJPSBzdG1wZV9wd21fcmVzb3VyY2Vz LAo+ICAJLm51bV9yZXNvdXJjZXMJPSBBUlJBWV9TSVpFKHN0bXBlX3B3bV9yZXNvdXJjZXMpLAo+ ICB9Owo+IEBAIC00NjEsNyArNDY3LDcgQEAgc3RhdGljIHN0cnVjdCByZXNvdXJjZSBzdG1wZV90 c19yZXNvdXJjZXNbXSA9IHsKPiAgCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgbWZkX2NlbGwgc3Rt cGVfdHNfY2VsbCA9IHsKPiAgCS5uYW1lCQk9ICJzdG1wZS10cyIsCj4gLQkub2ZfY29tcGF0aWJs ZQk9ICJzdCxzdG1wZS10cyIsCj4gKwkub2ZfY29tcGF0aWJsZQk9IFNUTVBFX1RTX0NPTVBBVElC TEUsCj4gIAkucmVzb3VyY2VzCT0gc3RtcGVfdHNfcmVzb3VyY2VzLAo+ICAJLm51bV9yZXNvdXJj ZXMJPSBBUlJBWV9TSVpFKHN0bXBlX3RzX3Jlc291cmNlcyksCj4gIH07Cj4gQEAgLTQ4NCw3ICs0 OTAsNyBAQCBzdGF0aWMgc3RydWN0IHJlc291cmNlIHN0bXBlX2FkY19yZXNvdXJjZXNbXSA9IHsK PiAgCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgbWZkX2NlbGwgc3RtcGVfYWRjX2NlbGwgPSB7Cj4g IAkubmFtZQkJPSAic3RtcGUtYWRjIiwKPiAtCS5vZl9jb21wYXRpYmxlCT0gInN0LHN0bXBlLWFk YyIsCj4gKwkub2ZfY29tcGF0aWJsZQk9IFNUTVBFX0FEQ19DT01QQVRJQkxFLAo+ICAJLnJlc291 cmNlcwk9IHN0bXBlX2FkY19yZXNvdXJjZXMsCj4gIAkubnVtX3Jlc291cmNlcwk9IEFSUkFZX1NJ WkUoc3RtcGVfYWRjX3Jlc291cmNlcyksCj4gIH07Cj4gQEAgLTEzNjIsMTkgKzEzNjgsMTYgQEAg c3RhdGljIHZvaWQgc3RtcGVfb2ZfcHJvYmUoc3RydWN0IHN0bXBlX3BsYXRmb3JtX2RhdGEgKnBk YXRhLAo+ICAJcGRhdGEtPmF1dG9zbGVlcCA9IChwZGF0YS0+YXV0b3NsZWVwX3RpbWVvdXQpID8g dHJ1ZSA6IGZhbHNlOwo+ICAKPiAgCWZvcl9lYWNoX2F2YWlsYWJsZV9jaGlsZF9vZl9ub2RlKG5w LCBjaGlsZCkgewo+IC0JCWlmIChvZl9ub2RlX25hbWVfZXEoY2hpbGQsICJzdG1wZV9ncGlvIikp IHsKPiArCQlpZiAob2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUoY2hpbGQsIFNUTVBFX0dQSU9fQ09N UEFUSUJMRSkpCj4gIAkJCXBkYXRhLT5ibG9ja3MgfD0gU1RNUEVfQkxPQ0tfR1BJTzsKPiAtCQl9 IGVsc2UgaWYgKG9mX25vZGVfbmFtZV9lcShjaGlsZCwgInN0bXBlX2tleXBhZCIpKSB7Cj4gKwkJ ZWxzZSBpZiAob2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUoY2hpbGQsIFNUTVBFX0tFWVBBRF9DT01Q QVRJQkxFKSkKPiAgCQkJcGRhdGEtPmJsb2NrcyB8PSBTVE1QRV9CTE9DS19LRVlQQUQ7Cj4gLQkJ fSBlbHNlIGlmIChvZl9ub2RlX25hbWVfZXEoY2hpbGQsICJzdG1wZV90b3VjaHNjcmVlbiIpKSB7 Cj4gKwkJZWxzZSBpZiAob2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUoY2hpbGQsIFNUTVBFX1RTX0NP TVBBVElCTEUpKQo+ICAJCQlwZGF0YS0+YmxvY2tzIHw9IFNUTVBFX0JMT0NLX1RPVUNIU0NSRUVO Owo+IC0JCX0gZWxzZSBpZiAob2Zfbm9kZV9uYW1lX2VxKGNoaWxkLCAic3RtcGVfYWRjIikpIHsK PiArCQllbHNlIGlmIChvZl9kZXZpY2VfaXNfY29tcGF0aWJsZShjaGlsZCwgU1RNUEVfQURDX0NP TVBBVElCTEUpKQo+ICAJCQlwZGF0YS0+YmxvY2tzIHw9IFNUTVBFX0JMT0NLX0FEQzsKPiAtCQl9 IGVsc2UgaWYgKG9mX25vZGVfbmFtZV9lcShjaGlsZCwgInN0bXBlX3B3bSIpKSB7Cj4gKwkJZWxz ZSBpZiAob2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUoY2hpbGQsIFNUTVBFX1BXTV9DT01QQVRJQkxF KSkKPiAgCQkJcGRhdGEtPmJsb2NrcyB8PSBTVE1QRV9CTE9DS19QV007Cj4gLQkJfSBlbHNlIGlm IChvZl9ub2RlX25hbWVfZXEoY2hpbGQsICJzdG1wZV9yb3RhdG9yIikpIHsKPiAtCQkJcGRhdGEt PmJsb2NrcyB8PSBTVE1QRV9CTE9DS19ST1RBVE9SOwo+IC0JCX0KClRoaXMgc2hvdWxkIGJlIGEg c2VwYXJhdGUgcGF0Y2guCgo+ICAJfQo+ICB9Cj4gIAoKLS0gCkxlZSBKb25lcyBb5p2O55C85pav XQpQcmluY2lwYWwgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9y ZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZh Y2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27011C43334 for ; Tue, 12 Jul 2022 13:33:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229537AbiGLNdT (ORCPT ); Tue, 12 Jul 2022 09:33:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229918AbiGLNdS (ORCPT ); Tue, 12 Jul 2022 09:33:18 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D94CB6294 for ; Tue, 12 Jul 2022 06:33:17 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id bk26so11172342wrb.11 for ; Tue, 12 Jul 2022 06:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=1FNQrGGLfgdOgMRKiUwsbzE3SGEjtGBgzxsXljwQUHE=; b=hTDsqLoXRixjt/Sxz4pnsbxPZ2ChVkl5G3Efink/BugEruXacu1c14dFTFwKa0c3gY o/+eryoGjW9zyuyJ7wemDQirD4D04/nXfYPkHa1G3NtRldyCDQ/2zs/zyzMfMEI8HTWr iYlsUd6VZ1BdSYB6OpRejTRfbS/3+NfNcv56pt8/W3na5GXCHJ5oq4VO25FksgV9cQFP OOzwUmFoXuLhNwWST4eb5B14ImeEhE4+FdqOm1DF6nMbC5rCYGWDPXDwqd7SkScILR7N gec2/C7+2gfE3s/eAraUC8ItcbP1D33rLOfkl66gtcp/BtJDaEyGPr/I+63MxweebsQZ wKaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=1FNQrGGLfgdOgMRKiUwsbzE3SGEjtGBgzxsXljwQUHE=; b=gptUD+4+xikpqffDIS8PXsiBFTvWab4wt/sUcOLpOw4Rcs4MuDTlH/KC6XewTERGgc 6mgvoFIZRB1exdFK11KJ3C2+4672MUMld2WK6VPpGskLxzCnRJ7ltFW/0FhMuvRfRlfb RNrmXJ02tg9KoSSm6+G8higcIMFVHvqnuCCrlq0/SHEjHYz4Z2kx50PlqXzVrf2lA4s4 Sx/1JXjIYTXLCUdl4/3PWedRAviMmrj21oTqNOYvZuPdxuroqqU4glDq3Za8T8HmRyDb Hqx48soxQ2Fs02+5c2nNksHYGez1PTOo7iM0ZxXnn9jX9maVK+Kh6e0xC4ibTwIRmABN gjgQ== X-Gm-Message-State: AJIora/OK1lqB8IhkBsFnNomRSlU1EWoU7U5CL4KQ2CvCnpZsVhlz3kQ QN97oaIK9r2we/VT3vTusrLL8g== X-Google-Smtp-Source: AGRyM1tDxqUM6cVCSs98mVzMblL7DYw1ebw4b5m50i0FuBi3jTzjyS1F+201+kxSFQ4/IZUzwFtrpw== X-Received: by 2002:a05:6000:178c:b0:21d:b6d0:11a8 with SMTP id e12-20020a056000178c00b0021db6d011a8mr1741057wrg.547.1657632795572; Tue, 12 Jul 2022 06:33:15 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id g4-20020adff404000000b0021d87798237sm8320371wro.20.2022.07.12.06.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 06:33:14 -0700 (PDT) Date: Tue, 12 Jul 2022 14:33:13 +0100 From: Lee Jones To: Francesco Dolcini Cc: Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Ahmad Fatoum Subject: Re: [PATCH v1 1/4] mfd: stmpe: Probe sub-function by compatible Message-ID: References: <20220712110232.329164-1-francesco.dolcini@toradex.com> <20220712110232.329164-2-francesco.dolcini@toradex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220712110232.329164-2-francesco.dolcini@toradex.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 12 Jul 2022, Francesco Dolcini wrote: > Use sub-function of_compatible during probe, instead of using the node > name. The code should not rely on the node names during probe, in > addition to that the previously hard-coded node names are not compliant > to the latest naming convention (they are not generic and they use > underscores), and it was broken by mistake already once [1]. > > While doing this change `rotator` entry was removed, it is not > used in any device tree file, there is no cell defined, it's just dead > non-working code with no of_compatible for it. > > [1] commit 56086b5e804f ("ARM: dts: imx6qdl-apalis: Avoid underscore in node name") > > Suggested-by: Ahmad Fatoum > Signed-off-by: Francesco Dolcini > --- > drivers/mfd/stmpe.c | 31 +++++++++++++++++-------------- > 1 file changed, 17 insertions(+), 14 deletions(-) > > diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c > index aeb9ea55f97d..90a07a94455f 100644 > --- a/drivers/mfd/stmpe.c > +++ b/drivers/mfd/stmpe.c > @@ -23,6 +23,12 @@ > #include > #include "stmpe.h" > > +#define STMPE_GPIO_COMPATIBLE "st,stmpe-gpio" > +#define STMPE_KEYPAD_COMPATIBLE "st,stmpe-keypad" > +#define STMPE_PWM_COMPATIBLE "st,stmpe-pwm" > +#define STMPE_TS_COMPATIBLE "st,stmpe-ts" > +#define STMPE_ADC_COMPATIBLE "st,stmpe-adc" This is horrible. Please refrain from defining device/compatible strings. > /** > * struct stmpe_platform_data - STMPE platform data > * @id: device id to distinguish between multiple STMPEs on the same board > @@ -321,14 +327,14 @@ static struct resource stmpe_gpio_resources[] = { > > static const struct mfd_cell stmpe_gpio_cell = { > .name = "stmpe-gpio", > - .of_compatible = "st,stmpe-gpio", > + .of_compatible = STMPE_GPIO_COMPATIBLE, > .resources = stmpe_gpio_resources, > .num_resources = ARRAY_SIZE(stmpe_gpio_resources), > }; > > static const struct mfd_cell stmpe_gpio_cell_noirq = { > .name = "stmpe-gpio", > - .of_compatible = "st,stmpe-gpio", > + .of_compatible = STMPE_GPIO_COMPATIBLE, > /* gpio cell resources consist of an irq only so no resources here */ > }; > > @@ -350,7 +356,7 @@ static struct resource stmpe_keypad_resources[] = { > > static const struct mfd_cell stmpe_keypad_cell = { > .name = "stmpe-keypad", > - .of_compatible = "st,stmpe-keypad", > + .of_compatible = STMPE_KEYPAD_COMPATIBLE, > .resources = stmpe_keypad_resources, > .num_resources = ARRAY_SIZE(stmpe_keypad_resources), > }; > @@ -376,7 +382,7 @@ static struct resource stmpe_pwm_resources[] = { > > static const struct mfd_cell stmpe_pwm_cell = { > .name = "stmpe-pwm", > - .of_compatible = "st,stmpe-pwm", > + .of_compatible = STMPE_PWM_COMPATIBLE, > .resources = stmpe_pwm_resources, > .num_resources = ARRAY_SIZE(stmpe_pwm_resources), > }; > @@ -461,7 +467,7 @@ static struct resource stmpe_ts_resources[] = { > > static const struct mfd_cell stmpe_ts_cell = { > .name = "stmpe-ts", > - .of_compatible = "st,stmpe-ts", > + .of_compatible = STMPE_TS_COMPATIBLE, > .resources = stmpe_ts_resources, > .num_resources = ARRAY_SIZE(stmpe_ts_resources), > }; > @@ -484,7 +490,7 @@ static struct resource stmpe_adc_resources[] = { > > static const struct mfd_cell stmpe_adc_cell = { > .name = "stmpe-adc", > - .of_compatible = "st,stmpe-adc", > + .of_compatible = STMPE_ADC_COMPATIBLE, > .resources = stmpe_adc_resources, > .num_resources = ARRAY_SIZE(stmpe_adc_resources), > }; > @@ -1362,19 +1368,16 @@ static void stmpe_of_probe(struct stmpe_platform_data *pdata, > pdata->autosleep = (pdata->autosleep_timeout) ? true : false; > > for_each_available_child_of_node(np, child) { > - if (of_node_name_eq(child, "stmpe_gpio")) { > + if (of_device_is_compatible(child, STMPE_GPIO_COMPATIBLE)) > pdata->blocks |= STMPE_BLOCK_GPIO; > - } else if (of_node_name_eq(child, "stmpe_keypad")) { > + else if (of_device_is_compatible(child, STMPE_KEYPAD_COMPATIBLE)) > pdata->blocks |= STMPE_BLOCK_KEYPAD; > - } else if (of_node_name_eq(child, "stmpe_touchscreen")) { > + else if (of_device_is_compatible(child, STMPE_TS_COMPATIBLE)) > pdata->blocks |= STMPE_BLOCK_TOUCHSCREEN; > - } else if (of_node_name_eq(child, "stmpe_adc")) { > + else if (of_device_is_compatible(child, STMPE_ADC_COMPATIBLE)) > pdata->blocks |= STMPE_BLOCK_ADC; > - } else if (of_node_name_eq(child, "stmpe_pwm")) { > + else if (of_device_is_compatible(child, STMPE_PWM_COMPATIBLE)) > pdata->blocks |= STMPE_BLOCK_PWM; > - } else if (of_node_name_eq(child, "stmpe_rotator")) { > - pdata->blocks |= STMPE_BLOCK_ROTATOR; > - } This should be a separate patch. > } > } > -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog