Re: [patch net-next RFC 02/10] net: devlink: add unlocked variants of devling_trap*() functions

[Ido Schimmel <idosch@nvidia.com>]

In subject: s/devling/devlink/

On Tue, Jul 12, 2022 at 01:05:03PM +0200, Jiri Pirko wrote:
> From: Moshe Shemesh <moshe@nvidia.com>
> 
> Add unlocked variants of devl_trap*() functions to be used in drivers
> called-in with devlink->lock held.
> 
> Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>

Please fold patch #6 into this. I guess the only reason for the
artificial split is that mlx5 does not use the functions from patch #6.

[...]

> +int devlink_traps_register(struct devlink *devlink,
> +			   const struct devlink_trap *traps,
> +			   size_t traps_count, void *priv)
> +{
> +	int ret;
> +
> +	devl_lock(devlink);
> +	ret = devl_traps_register(devlink, traps, traps_count, priv);

Most of the related code (including patch #6) uses 'err' instead of
'ret'

> +	devl_unlock(devlink);
> +
> +	return ret;
> +}