All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Konstantin Kostiuk <kkostiuk@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	Michael Roth <michael.roth@amd.com>
Subject: Re: [PULL 1/3] MAINTAINERS: Add myself as Guest Agent reviewer
Date: Wed, 13 Jul 2022 11:38:15 +0100	[thread overview]
Message-ID: <Ys6gl74SLea6dsfU@redhat.com> (raw)
In-Reply-To: <20220713101908.2212307-2-kkostiuk@redhat.com>

On Wed, Jul 13, 2022 at 01:19:06PM +0300, Konstantin Kostiuk wrote:
> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> Message-Id: <20220712092715.2136898-1-kkostiuk@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 450abd0252..b1e73d99f3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2880,6 +2880,7 @@ T: git https://repo.or.cz/qemu/armbru.git qapi-next
>  
>  QEMU Guest Agent
>  M: Michael Roth <michael.roth@amd.com>
> +R: Konstantin Kostiuk <kkostiuk@redhat.com>

This pull request contains functional changes under qga/, which
suggests you're acting as a (co-)maintainer for QGA, not merely
a reviewer. I wouldn't normally expect reviewers to send pull
requests for a subsystem. As such should this be "M:", to
indicate co-maintainership and have an explicit ACK from
Michael Roth.

>  S: Maintained
>  F: qga/
>  F: docs/interop/qemu-ga.rst


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2022-07-13 10:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13 10:19 [PULL 0/3] Guest Agent patches 2022-07-13 Konstantin Kostiuk
2022-07-13 10:19 ` [PULL 1/3] MAINTAINERS: Add myself as Guest Agent reviewer Konstantin Kostiuk
2022-07-13 10:38   ` Daniel P. Berrangé [this message]
2022-07-13 11:31     ` Konstantin Kostiuk
2022-07-13 11:55       ` Daniel P. Berrangé
2022-07-13 12:06         ` Konstantin Kostiuk
2022-07-13 10:19 ` [PULL 2/3] qapi: Avoid generating C identifier 'linux' Konstantin Kostiuk
2022-07-13 10:19 ` [PULL 3/3] qga: add command 'guest-get-cpustats' Konstantin Kostiuk
2022-07-14 17:13 ` [PULL 0/3] Guest Agent patches 2022-07-13 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ys6gl74SLea6dsfU@redhat.com \
    --to=berrange@redhat.com \
    --cc=kkostiuk@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.