From: Patrick Williams <patrick@stwcx.xyz>
To: Nan Zhou <nanzhou@google.com>
Cc: Ed Tanous <edtanous@google.com>,
Brad Bishop <bradleyb@fuzziesquirrel.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: DBus ObjectManager Interface usages within the project
Date: Wed, 13 Jul 2022 06:44:07 -0500 [thread overview]
Message-ID: <Ys6wB54/qPxokthK@heinlein.stwcx.org.github.beta.tailscale.net> (raw)
In-Reply-To: <CAOLfGj6DWfmhxzSQx9PaU1awppsExrgJodFu8JrSgkbQZbnStA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]
On Tue, Jul 12, 2022 at 01:02:37PM -0700, Nan Zhou wrote:
> Ed brought up this issue that OM is optional as of today in inventories and
> sensors during the code review of
> https://gerrit.openbmc.org/c/openbmc/bmcweb/+/53824. The path of the OM is
> also inconsistent.
I don't think "OM is optional" is really a true statement. It is
optional from a dbus perspective, true, but practically speaking all of
our daemons have it (just at an inconsistent location). One of the
primary features of the object manager is to emit the signals for
managed objects, such as PropertiesChanged. If you don't have an object
manager you don't get those signals. We have to have that on Sensors,
at least, and I'm pretty sure everyone adds them for Inventory as well.
As you're seeing, there are typically two behaviors of implementation:
1. Anything using ASIO places OM at the root by default.
2. Anything using PDI-bindings places the OM at the lowest common part
in their hierarchy. (Something like /xyz/openbmc_project/sensors or
/xyz/openbmc_project typically).
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-07-13 11:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 18:48 DBus ObjectManager Interface usages within the project Ed Tanous
2022-07-12 20:02 ` Nan Zhou
2022-07-13 11:44 ` Patrick Williams [this message]
2022-07-13 3:07 ` Lei Yu
2022-07-13 5:54 ` Ed Tanous
2022-07-13 10:17 ` dbus prefixes (was: DBus ObjectManager Interface usages within the project) Alexander Amelkin
2022-07-13 11:39 ` Patrick Williams
2022-07-27 11:15 ` Alexander Amelkin
2022-07-29 0:26 ` Brad Bishop
2022-07-13 11:24 ` DBus ObjectManager Interface usages within the project Patrick Williams
2022-07-13 14:36 ` Ed Tanous
2022-07-14 0:49 ` Nan Zhou
2022-09-12 16:54 ` Nan Zhou
2022-09-13 15:46 ` Brad Bishop
2022-09-13 16:52 ` Nan Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys6wB54/qPxokthK@heinlein.stwcx.org.github.beta.tailscale.net \
--to=patrick@stwcx.xyz \
--cc=bradleyb@fuzziesquirrel.com \
--cc=edtanous@google.com \
--cc=nanzhou@google.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.