From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CCBCCCA479 for ; Wed, 13 Jul 2022 13:07:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235860AbiGMNHv (ORCPT ); Wed, 13 Jul 2022 09:07:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbiGMNHt (ORCPT ); Wed, 13 Jul 2022 09:07:49 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B9AB766C for ; Wed, 13 Jul 2022 06:07:40 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id o4so15447875wrh.3 for ; Wed, 13 Jul 2022 06:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ZDp5NtLIxNT/y/y4TV28JKQZE5KPsmeDwau7U2nvfbI=; b=ykcE/L76OyKjfmB6gW/9PEIXPb7KX9wbY5QZt6rzoJ7cx+NshQnf3zYFk9CJJmZ/WM Yjn5tpbDrFkjNkWS+WFrkqjSfGYuauzrhkLnPgPWJ+ijDPIFajS1TTDtmC2uQEI2eXJq v/PjSpgG/525Lm1jJ94ez4EFFEytapEdMWKLq79xQRBWSawK2YgrGJjhf+6mviSVU3q3 kOx9C54FFQzStrBSdTBuFlQdgkenCIZH2XWgb8DLkaqKQZ3XbPUtvaJN7A3d1aNdPv+L MOY47XiJ+MoxEz7XvBmRhEiBH0MhBUFHBMZQFzRyd4+1IQ/e0LRFMgzPqoPQQ++2EeCE bFRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ZDp5NtLIxNT/y/y4TV28JKQZE5KPsmeDwau7U2nvfbI=; b=7VMo3k3lDyxfwWN8Lr8pYPj16kk06StdtSRqdAeCWslYorzvwkbRhSYh62Vb0r7AlC 2vmqC2tVb3VkMhpkFY895JO7XKqBQqlXPTIS9uke9tefToNGyWiPYoroXG0wONa3eHuk x2DlUcRh5V1ndvU06M605t7qmOKudnDk6Lx0DEm3gvUwJ1MevPhmckloU1v1fVxl6Q1D 0Os6tAruPt3i8+37rQdN+7EIgAnjee+6G5Y5ub797IdqDavkDZjWeyzxE99duZ2KHv6Z jz30JcVu9PwoixAnDgDdAntJxZO6kKEBuxWjvXko1pEhB+J1KEblaYt7UweViIQm5Me/ Tj0Q== X-Gm-Message-State: AJIora8z06EVpwwPgcYVRuZnaXjInmE1Dgv/BJbEQpdVnjus923LRd9X bqVQA7GBGJ0mD6igm9KVrS/FJA== X-Google-Smtp-Source: AGRyM1v3Wejcmcef1+JLx2OGnt8FIDdBIQxbNYoMtF21Qn+Urzq7T2tg4YCX+P2hq8vPNX2sKjEQ7Q== X-Received: by 2002:a5d:5747:0:b0:21d:65e9:be07 with SMTP id q7-20020a5d5747000000b0021d65e9be07mr3162978wrw.215.1657717658781; Wed, 13 Jul 2022 06:07:38 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id l29-20020a05600c1d1d00b0039749b01ea7sm2628398wms.32.2022.07.13.06.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 06:07:38 -0700 (PDT) Date: Wed, 13 Jul 2022 14:07:35 +0100 From: Lee Jones To: Andy Shevchenko Cc: ChiaEn Wu , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Subject: Re: [PATCH v4 13/13] video: backlight: mt6370: Add Mediatek MT6370 support Message-ID: References: <20220704053901.728-1-peterwu.pub@gmail.com> <20220704053901.728-14-peterwu.pub@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Wed, 13 Jul 2022, Andy Shevchenko wrote: > On Wed, Jul 13, 2022 at 12:53 PM ChiaEn Wu wrote: > > Andy Shevchenko 於 2022年7月5日 週二 清晨5:14寫道： > > > On Mon, Jul 4, 2022 at 7:43 AM ChiaEn Wu wrote: > > Please, remove unneeded context when replying! > > ... > > > > > + brightness_val[0] = (brightness - 1) & MT6370_BL_DIM2_MASK; > > > > + brightness_val[1] = (brightness - 1) > > > > + >> fls(MT6370_BL_DIM2_MASK); > > > > > > Bad indentation. One line? > > > > Well... if indent to one line, it will be over 80 characters(or called columns?) > > From my understanding, it is not allowed, right?? > > It's allowed to some extent.Use your common sense. > Here it's obviously broken indentation. Refrain from going crazy though - hard limit is 100 chars. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C84CC433EF for ; Wed, 13 Jul 2022 14:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dllCy8RD6mZuLPcr4qfejl0xphXy6P0DUM1zk6fDaJI=; b=aoxAcY2Cok9XZA PIxWoAomN1H94o+Pbb8waaN4OzTnXY1OL220W/tuehpP26IPfv/gRMSlxmIq5WNGW2Ii8xNUQDiVz hMRa33+AJoCbExrgd715fRHiNtR6qbTJYaoGzRLCF29e0EoetrnxQgskDHu6p42ico7UqmI10sTqp BZ9EyV87MVI57w4uIvW3rl5AZ1UKDmtDa+/vzaTQDjnIKn3xq2djybLJVy7YKOy0Z/Vkz1pmzecCF E/WSCLxyL7zwAzYf1iwLlCFFMVEgLx8hNIacMjB4XU6mJe376X24cV9NOz+o4T498xhq0b76DSc7m V3v+H76HptXt69l3IU7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBd9S-004KvY-UM; Wed, 13 Jul 2022 14:15:44 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBc5g-003n6M-6C for linux-arm-kernel@lists.infradead.org; Wed, 13 Jul 2022 13:07:48 +0000 Received: by mail-wr1-x42d.google.com with SMTP id r14so15472287wrg.1 for ; Wed, 13 Jul 2022 06:07:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ZDp5NtLIxNT/y/y4TV28JKQZE5KPsmeDwau7U2nvfbI=; b=ykcE/L76OyKjfmB6gW/9PEIXPb7KX9wbY5QZt6rzoJ7cx+NshQnf3zYFk9CJJmZ/WM Yjn5tpbDrFkjNkWS+WFrkqjSfGYuauzrhkLnPgPWJ+ijDPIFajS1TTDtmC2uQEI2eXJq v/PjSpgG/525Lm1jJ94ez4EFFEytapEdMWKLq79xQRBWSawK2YgrGJjhf+6mviSVU3q3 kOx9C54FFQzStrBSdTBuFlQdgkenCIZH2XWgb8DLkaqKQZ3XbPUtvaJN7A3d1aNdPv+L MOY47XiJ+MoxEz7XvBmRhEiBH0MhBUFHBMZQFzRyd4+1IQ/e0LRFMgzPqoPQQ++2EeCE bFRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ZDp5NtLIxNT/y/y4TV28JKQZE5KPsmeDwau7U2nvfbI=; b=YPpmX9k7Vjo9fvHpxTZ4AdIGOmw7f4WYC4mzCcCGb0IvgQ8ZLeX8+MzN1Y8owwb7NC ZxCARaiINpmPvfX3qwBDegsHg+IHG7o8hIBXP6zyFIJKj+7NOJfDOr0TDQNXSDatRO5u Bk8rWB+mRD9+tUTFdpZWO34iyuCvybwTMuQHdutz8AiDypojbJ9idewd+0NSH6/kWQic muBxwiE2HNO73ud4CM67OS7Vm6GJZYklgfuMK0rwzQHFZ2Roxj12wndWz4z6MqwgUXhO zoItZIok8mtrXH8Ag3CJGSJxzJVeJ/6Qct6XhVciajULde4TbdQTd1GESBXDqnFkEQ0K OK8g== X-Gm-Message-State: AJIora/EzKiO4HWAQ5j62bvc0hbzjdj9ZnXE8LJSClne6e6C5xh1V7Br gk5V7Kw66HgeoJaMPw+ASmakGQ== X-Google-Smtp-Source: AGRyM1v3Wejcmcef1+JLx2OGnt8FIDdBIQxbNYoMtF21Qn+Urzq7T2tg4YCX+P2hq8vPNX2sKjEQ7Q== X-Received: by 2002:a5d:5747:0:b0:21d:65e9:be07 with SMTP id q7-20020a5d5747000000b0021d65e9be07mr3162978wrw.215.1657717658781; Wed, 13 Jul 2022 06:07:38 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id l29-20020a05600c1d1d00b0039749b01ea7sm2628398wms.32.2022.07.13.06.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 06:07:38 -0700 (PDT) Date: Wed, 13 Jul 2022 14:07:35 +0100 From: Lee Jones To: Andy Shevchenko Cc: ChiaEn Wu , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Subject: Re: [PATCH v4 13/13] video: backlight: mt6370: Add Mediatek MT6370 support Message-ID: References: <20220704053901.728-1-peterwu.pub@gmail.com> <20220704053901.728-14-peterwu.pub@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220713_060744_240041_D7FBF354 X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAxMyBKdWwgMjAyMiwgQW5keSBTaGV2Y2hlbmtvIHdyb3RlOgoKPiBPbiBXZWQsIEp1 bCAxMywgMjAyMiBhdCAxMjo1MyBQTSBDaGlhRW4gV3UgPHBldGVyd3UucHViQGdtYWlsLmNvbT4g d3JvdGU6Cj4gPiBBbmR5IFNoZXZjaGVua28gPGFuZHkuc2hldmNoZW5rb0BnbWFpbC5jb20+IOaW vCAyMDIy5bm0N+aciDXml6Ug6YCx5LqMIOa4heaZqDU6MTTlr6vpgZPvvJoKPiA+ID4gT24gTW9u LCBKdWwgNCwgMjAyMiBhdCA3OjQzIEFNIENoaWFFbiBXdSA8cGV0ZXJ3dS5wdWJAZ21haWwuY29t PiB3cm90ZToKPiAKPiBQbGVhc2UsIHJlbW92ZSB1bm5lZWRlZCBjb250ZXh0IHdoZW4gcmVwbHlp bmchCj4gCj4gLi4uCj4gCj4gPiA+ID4gKyAgICAgICAgICAgICAgIGJyaWdodG5lc3NfdmFsWzBd ID0gKGJyaWdodG5lc3MgLSAxKSAmIE1UNjM3MF9CTF9ESU0yX01BU0s7Cj4gPiA+ID4gKyAgICAg ICAgICAgICAgIGJyaWdodG5lc3NfdmFsWzFdID0gKGJyaWdodG5lc3MgLSAxKQo+ID4gPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgID4+IGZscyhNVDYzNzBfQkxfRElNMl9N QVNLKTsKPiA+ID4KPiA+ID4gQmFkIGluZGVudGF0aW9uLiBPbmUgbGluZT8KPiA+Cj4gPiBXZWxs Li4uIGlmIGluZGVudCB0byBvbmUgbGluZSwgaXQgd2lsbCBiZSBvdmVyIDgwIGNoYXJhY3RlcnMo b3IgY2FsbGVkIGNvbHVtbnM/KQo+ID4gRnJvbSBteSB1bmRlcnN0YW5kaW5nLCBpdCBpcyBub3Qg YWxsb3dlZCwgcmlnaHQ/Pwo+IAo+IEl0J3MgYWxsb3dlZCB0byBzb21lIGV4dGVudC5Vc2UgeW91 ciBjb21tb24gc2Vuc2UuCj4gSGVyZSBpdCdzIG9idmlvdXNseSBicm9rZW4gaW5kZW50YXRpb24u CgpSZWZyYWluIGZyb20gZ29pbmcgY3JhenkgdGhvdWdoIC0gaGFyZCBsaW1pdCBpcyAxMDAgY2hh cnMuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClByaW5jaXBhbCBUZWNobmljYWwgTGVhZCAt IERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBm b3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA743C433EF for ; Wed, 13 Jul 2022 13:07:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0700B884D4; Wed, 13 Jul 2022 13:07:42 +0000 (UTC) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by gabe.freedesktop.org (Postfix) with ESMTPS id 541CD9A925 for ; Wed, 13 Jul 2022 13:07:40 +0000 (UTC) Received: by mail-wr1-x429.google.com with SMTP id r10so9278387wrv.4 for ; Wed, 13 Jul 2022 06:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ZDp5NtLIxNT/y/y4TV28JKQZE5KPsmeDwau7U2nvfbI=; b=ykcE/L76OyKjfmB6gW/9PEIXPb7KX9wbY5QZt6rzoJ7cx+NshQnf3zYFk9CJJmZ/WM Yjn5tpbDrFkjNkWS+WFrkqjSfGYuauzrhkLnPgPWJ+ijDPIFajS1TTDtmC2uQEI2eXJq v/PjSpgG/525Lm1jJ94ez4EFFEytapEdMWKLq79xQRBWSawK2YgrGJjhf+6mviSVU3q3 kOx9C54FFQzStrBSdTBuFlQdgkenCIZH2XWgb8DLkaqKQZ3XbPUtvaJN7A3d1aNdPv+L MOY47XiJ+MoxEz7XvBmRhEiBH0MhBUFHBMZQFzRyd4+1IQ/e0LRFMgzPqoPQQ++2EeCE bFRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ZDp5NtLIxNT/y/y4TV28JKQZE5KPsmeDwau7U2nvfbI=; b=FrsCsMAh1G5F3QXaRT93TCMVPtvkJ1hqmtISt2Rq+X41ykbWtV+N0G/wY9DBnGYcbv XZXlgS5NT+FNFoFd0IWar0MIGXT3xYxNE5Aciy/ArHK0/pKY5XM4lSytZV4papvDo3Lq mE+7cfhC9hDKJyLiaGFPmXJoubLGHfEhK8tv0jKleuEcsE8xqRpSffXQIhUu2dlTxkor MGRqEmiUIn1XkCmle+XarInjzcHkMW6bVjVbvBz1KQMzZHwtmlLfzklX068/sy2pc2Je A0E25vtce8xvbMhBiWLy+amg3pzZTRycYlVPFEN7NuJQu3wdJSiudm0+DWTb0zP78QLy ZyfA== X-Gm-Message-State: AJIora8ymSjoM6v3ZuHixdpShvkG3b7GAel+hrpkibCX4g4nAsNV2arh 447MCQ06IDc3WmXtoUVhGQiNYA== X-Google-Smtp-Source: AGRyM1v3Wejcmcef1+JLx2OGnt8FIDdBIQxbNYoMtF21Qn+Urzq7T2tg4YCX+P2hq8vPNX2sKjEQ7Q== X-Received: by 2002:a5d:5747:0:b0:21d:65e9:be07 with SMTP id q7-20020a5d5747000000b0021d65e9be07mr3162978wrw.215.1657717658781; Wed, 13 Jul 2022 06:07:38 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id l29-20020a05600c1d1d00b0039749b01ea7sm2628398wms.32.2022.07.13.06.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 06:07:38 -0700 (PDT) Date: Wed, 13 Jul 2022 14:07:35 +0100 From: Lee Jones To: Andy Shevchenko Subject: Re: [PATCH v4 13/13] video: backlight: mt6370: Add Mediatek MT6370 support Message-ID: References: <20220704053901.728-1-peterwu.pub@gmail.com> <20220704053901.728-14-peterwu.pub@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:FRAMEBUFFER LAYER" , "Krogerus, Heikki" , Krzysztof Kozlowski , Alice Chen , linux-iio , dri-devel , Liam Girdwood , cy_huang , Pavel Machek , Linux LED Subsystem , Daniel Thompson , Helge Deller , Rob Herring , Chunfeng Yun , Guenter Roeck , devicetree , Linux PM , szuni chen , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , ChiaEn Wu , linux-arm Mailing List , Jingoo Han , USB , Sebastian Reichel , Linux Kernel Mailing List , ChiaEn Wu , Greg Kroah-Hartman , Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 13 Jul 2022, Andy Shevchenko wrote: > On Wed, Jul 13, 2022 at 12:53 PM ChiaEn Wu wrote: > > Andy Shevchenko 於 2022年7月5日 週二 清晨5:14寫道： > > > On Mon, Jul 4, 2022 at 7:43 AM ChiaEn Wu wrote: > > Please, remove unneeded context when replying! > > ... > > > > > + brightness_val[0] = (brightness - 1) & MT6370_BL_DIM2_MASK; > > > > + brightness_val[1] = (brightness - 1) > > > > + >> fls(MT6370_BL_DIM2_MASK); > > > > > > Bad indentation. One line? > > > > Well... if indent to one line, it will be over 80 characters(or called columns?) > > From my understanding, it is not allowed, right?? > > It's allowed to some extent.Use your common sense. > Here it's obviously broken indentation. Refrain from going crazy though - hard limit is 100 chars. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog