From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Robert Marko <robimarko@gmail.com>
Cc: agross@kernel.org, konrad.dybcio@somainline.org,
amitk@kernel.org, thara.gopinath@gmail.com, rafael@kernel.org,
daniel.lezcano@linaro.org, rui.zhang@intel.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/5] drivers: thermal: tsens: Add support for combined interrupt
Date: Wed, 13 Jul 2022 15:59:18 -0500 [thread overview]
Message-ID: <Ys8yJutlV00q1hFX@builder.lan> (raw)
In-Reply-To: <20220708132930.595897-2-robimarko@gmail.com>
On Fri 08 Jul 08:29 CDT 2022, Robert Marko wrote:
[..]
> +static irqreturn_t tsens_combined_irq_thread(int irq, void *data)
> +{
> + irqreturn_t ret;
> +
> + ret = tsens_critical_irq_thread(irq, data);
Perhaps you could do something with this return value?
> + ret = tsens_irq_thread(irq, data);
As written here, return tsens_irq_thread() seems cleaner.
Regards,
Bjorn
next prev parent reply other threads:[~2022-07-13 20:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 13:29 [PATCH v5 1/5] dt-bindings: thermal: tsens: Add ipq8074 compatible Robert Marko
2022-07-08 13:29 ` [PATCH v5 2/5] drivers: thermal: tsens: Add support for combined interrupt Robert Marko
2022-07-13 20:59 ` Bjorn Andersson [this message]
2022-07-08 13:29 ` [PATCH v5 3/5] drivers: thermal: tsens: allow configuring min and max trips Robert Marko
2022-07-13 21:02 ` Bjorn Andersson
2022-07-08 13:29 ` [PATCH v5 4/5] drivers: thermal: tsens: add IPQ8074 support Robert Marko
2022-07-13 21:05 ` Bjorn Andersson
2022-07-08 13:29 ` [PATCH v5 5/5] arm64: dts: ipq8074: add thermal nodes Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys8yJutlV00q1hFX@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.