All of lore.kernel.org
 help / color / mirror / Atom feed
From: sdf@google.com
To: Indu Bhagat <indu.bhagat@oracle.com>
Cc: bpf@vger.kernel.org, yhs@fb.com
Subject: Re: [PATCH bpf-next] docs/bpf: Update documentation for BTF_KIND_FUNC
Date: Wed, 13 Jul 2022 16:52:52 -0700	[thread overview]
Message-ID: <Ys9a1MJ3YcFqxwe4@google.com> (raw)
In-Reply-To: <20220713222544.2355143-1-indu.bhagat@oracle.com>

On 07/13, Indu Bhagat wrote:
> The vlen bits in the BTF type of kind BTF_KIND_FUNC are used to convey the
> linkage information for functions.

> Signed-off-by: Indu Bhagat <indu.bhagat@oracle.com>

Reviewed-by: Stanislav Fomichev <sdf@google.com>

Judging by:

static inline u16 btf_func_linkage(const struct btf_type *t)
{
	return BTF_INFO_VLEN(t->info);
}

> ---
>   Documentation/bpf/btf.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/Documentation/bpf/btf.rst b/Documentation/bpf/btf.rst
> index f49aeef62d0c..b3a9d5ac882c 100644
> --- a/Documentation/bpf/btf.rst
> +++ b/Documentation/bpf/btf.rst
> @@ -369,7 +369,7 @@ No additional type data follow ``btf_type``.
>     * ``name_off``: offset to a valid C identifier
>     * ``info.kind_flag``: 0
>     * ``info.kind``: BTF_KIND_FUNC
> -  * ``info.vlen``: 0
> +  * ``info.vlen``: linkage information (static=0, global=1)
>     * ``type``: a BTF_KIND_FUNC_PROTO type

>   No additional type data follow ``btf_type``.
> --
> 2.31.1


  reply	other threads:[~2022-07-13 23:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13 22:25 [PATCH bpf-next] docs/bpf: Update documentation for BTF_KIND_FUNC Indu Bhagat
2022-07-13 23:52 ` sdf [this message]
2022-07-14  6:00 ` Andrii Nakryiko
2022-07-14  6:42   ` Yonghong Song
2022-07-14  7:10     ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ys9a1MJ3YcFqxwe4@google.com \
    --to=sdf@google.com \
    --cc=bpf@vger.kernel.org \
    --cc=indu.bhagat@oracle.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.