From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com, mlxsw@nvidia.com, saeedm@nvidia.com,
moshe@nvidia.com
Subject: Re: [patch net-next v2 2/3] net: devlink: call lockdep_assert_held() for devlink->lock directly
Date: Sat, 2 Jul 2022 17:59:15 +0200 [thread overview]
Message-ID: <YsBrUxF4ZDMMK7li@nanopsycho> (raw)
In-Reply-To: <20220701201021.400a5a83@kernel.org>
Sat, Jul 02, 2022 at 05:10:21AM CEST, kuba@kernel.org wrote:
>On Fri, 1 Jul 2022 18:40:06 +0200 Jiri Pirko wrote:
>> In devlink.c there is direct access to whole struct devlink so there is
>> no need to use helper. So obey the customs and work with lock directly
>> avoiding helpers which might obfuscate things a bit.
>
>I think you sent this as / before I replied to all the patches.
Sorry.
>Still not sure what the basis for the custom is.
Please see the reply to your comment of this patch in v1. Thanks!
next prev parent reply other threads:[~2022-07-02 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 16:40 [patch net-next v2 0/3] net: devlink: devl_* cosmetic fixes Jiri Pirko
2022-07-01 16:40 ` [patch net-next v2 1/3] net: devlink: move unlocked function prototypes alongside the locked ones Jiri Pirko
2022-07-01 16:40 ` [patch net-next v2 2/3] net: devlink: call lockdep_assert_held() for devlink->lock directly Jiri Pirko
2022-07-02 3:10 ` Jakub Kicinski
2022-07-02 15:59 ` Jiri Pirko [this message]
2022-07-01 16:40 ` [patch net-next v2 3/3] net: devlink: fix unlocked vs locked functions descriptions Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsBrUxF4ZDMMK7li@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.