From: Mike Rapoport <rppt@linux.ibm.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
loongarch@lists.linux.dev
Subject: Re: [RFC PATCH v3 2/3] mm: Add PUD level pagetable account
Date: Sun, 3 Jul 2022 17:18:17 +0300 [thread overview]
Message-ID: <YsGlKQ2AjNdDEAsz@linux.ibm.com> (raw)
In-Reply-To: <YsERO3OpZSJuC4hW@casper.infradead.org>
On Sun, Jul 03, 2022 at 04:47:07AM +0100, Matthew Wilcox wrote:
> On Thu, Jun 30, 2022 at 07:11:15PM +0800, Baolin Wang wrote:
> > +++ b/arch/loongarch/include/asm/pgalloc.h
> > @@ -89,10 +89,15 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address)
> > static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address)
> > {
> > pud_t *pud;
> > + struct page *page;
> >
> > - pud = (pud_t *) __get_free_pages(GFP_KERNEL, PUD_ORDER);
> > - if (pud)
> > - pud_init((unsigned long)pud, (unsigned long)invalid_pmd_table);
> > + page = alloc_pages(GFP_KERNEL, PUD_ORDER);
>
> Argh. I just got rid of PMD_ORDER from PA-RISC. Now Loongstupid has
> reintroduced it, and worse introduced PUD_ORDER. See commit
> 7bf82eb3873f.
Let's try and deal with all those PxD_ORDERs for once.
https://lore.kernel.org/linux-arch/20220703141203.147893-1-rppt@kernel.org/
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2022-07-03 14:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 11:11 [RFC PATCH v3 0/3] Add PUD and kernel PTE level pagetable account Baolin Wang
2022-06-30 11:11 ` [RFC PATCH v3 1/3] mm: Factor out the pagetable pages account into new helper function Baolin Wang
2022-06-30 14:11 ` Mike Rapoport
2022-07-01 8:00 ` Baolin Wang
2022-07-02 10:15 ` Mike Rapoport
2022-07-03 13:48 ` Baolin Wang
2022-06-30 11:11 ` [RFC PATCH v3 2/3] mm: Add PUD level pagetable account Baolin Wang
2022-06-30 14:17 ` Mike Rapoport
2022-07-01 8:04 ` Baolin Wang
2022-07-03 3:40 ` Matthew Wilcox
2022-07-03 14:06 ` Baolin Wang
2022-07-03 14:28 ` Mike Rapoport
2022-07-03 14:49 ` Baolin Wang
2022-07-03 14:52 ` Matthew Wilcox
2022-07-03 15:07 ` Baolin Wang
2022-07-03 3:47 ` Matthew Wilcox
2022-07-03 14:18 ` Mike Rapoport [this message]
2022-06-30 11:11 ` [RFC PATCH v3 3/3] mm: Add kernel PTE level pagetable pages account Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsGlKQ2AjNdDEAsz@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chenhuacai@kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=loongarch@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.