From: David Lamparter <equinox@diac24.net>
To: David Ahern <dsahern@kernel.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: ip6mr: add RTM_GETROUTE netlink op
Date: Mon, 4 Jul 2022 10:35:20 +0200 [thread overview]
Message-ID: <YsKmSMPRoUHeejCS@eidolon.nox.tf> (raw)
In-Reply-To: <0d18f6a3-78da-2dee-d715-39a043870eec@kernel.org>
On Sun, Jul 03, 2022 at 01:07:33PM -0600, David Ahern wrote:
> On 7/1/22 1:58 AM, David Lamparter wrote:
[...]
> > + if (!netlink_strict_get_check(skb))
> > + return nlmsg_parse_deprecated(nlh, sizeof(*rtm), tb, RTA_MAX,
> > + rtm_ipv6_policy, extack);
>
> Since this is new code, it always operates in strict mode.
>
[...]
> > + err = nlmsg_parse_deprecated_strict(nlh, sizeof(*rtm), tb, RTA_MAX,
> > + rtm_ipv6_policy, extack);
>
> nlmsg_parse here.
Thanks for the feedback! I've fixed the code, am currently retesting,
and will post a v2 shortly.
-David / equi
next prev parent reply other threads:[~2022-07-04 8:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 13:30 [PATCH net-next 0/2] ip6mr: implement RTM_GETROUTE for single entry David Lamparter
2022-06-30 13:30 ` [PATCH 1/2] ipv6: make rtm_ipv6_policy available David Lamparter
2022-06-30 13:30 ` [PATCH 2/2] net: ip6mr: add RTM_GETROUTE netlink op David Lamparter
2022-07-01 3:27 ` [PATCH net-next 0/2] ip6mr: implement RTM_GETROUTE for single entry Jakub Kicinski
2022-07-01 7:58 ` [PATCH resend " David Lamparter
2022-07-01 7:58 ` [PATCH net-next 1/2] ipv6: make rtm_ipv6_policy available David Lamparter
2022-07-01 7:58 ` [PATCH net-next 2/2] net: ip6mr: add RTM_GETROUTE netlink op David Lamparter
2022-07-03 19:07 ` David Ahern
2022-07-04 8:35 ` David Lamparter [this message]
2022-07-04 9:58 ` [PATCH net-next v2] " David Lamparter
2022-07-04 10:22 ` Nikolay Aleksandrov
2022-07-04 10:38 ` David Lamparter
2022-07-04 10:44 ` Nikolay Aleksandrov
2022-07-04 10:52 ` [PATCH net-next v3] " David Lamparter
2022-07-05 2:50 ` Jakub Kicinski
2022-07-06 9:52 ` David Lamparter
2022-07-05 3:38 ` [PATCH net-next v2] " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsKmSMPRoUHeejCS@eidolon.nox.tf \
--to=equinox@diac24.net \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.