From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25D30C43334 for ; Mon, 4 Jul 2022 11:07:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230026AbiGDLHc (ORCPT ); Mon, 4 Jul 2022 07:07:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229836AbiGDLHb (ORCPT ); Mon, 4 Jul 2022 07:07:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28560DFAC; Mon, 4 Jul 2022 04:07:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BA67F61624; Mon, 4 Jul 2022 11:07:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E4F6C3411E; Mon, 4 Jul 2022 11:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656932850; bh=ShPSNOvgzATtn2/Bsxk03dhF7u+9UjNpwSKkcGRvTT0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yg7oJSBac1jklWTdfgCXuJ3ysIGEvXrqf9/zfqWj42Iyu5IX6vLXQxNYM/N8zePVv gl+h3HeUDHDoljmR2gePU76jeomtKSKBVHs4jLc0sVpZAXzp8rEBO43+ANIOsKdZ6Y UAo9IGe43RtjSE/pzqD1J5iVI+6bU5b1kL+Sse4w= Date: Mon, 4 Jul 2022 13:07:27 +0200 From: Greg KH To: szuni chen Cc: ChiaEn Wu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , chiaen_wu@richtek.com, alice_chen@richtek.com, ChiYuan Huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" Subject: Re: [PATCH v4 08/13] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver Message-ID: References: <20220704053901.728-1-peterwu.pub@gmail.com> <20220704053901.728-9-peterwu.pub@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Mon, Jul 04, 2022 at 05:31:29PM +0800, szuni chen wrote: > Greg KH 於 2022年7月4日 週一 下午3:32寫道： > > > > On Mon, Jul 04, 2022 at 01:38:56PM +0800, ChiaEn Wu wrote: > > > From: ChiYuan Huang > > > > > > Add chip level mt6370 tcpci driver. > > > > What does this mean? Please provide more information about the hardware > > being supported here so we know how to review this. > > Dear Greg, > > MediaTek MT6370 is a highly-integrated smart power management IC, > which includes a single cell Li-Ion/Li-Polymer switching battery charger, > a USB Type-C & Power Delivery (PD) controller, dual flash LED current sources, > a RGB LED driver, a backlight WLED driver, a display bias driver and a > general LDO for portable devices. > > This driver is used for the Type-C & Power Delivery controller in > MediaTek MT6370 IC. > > If we change the commit message to > > "Add MediaTek MT6370 tcpci driver. > MediaTek MT6370 is a multi-functional IC that includes USB Type-C. > It works with Type-C Port Controller Manager to provide USB PD and USB > Type-C functionalities." > > does this meet your requirements? What would you want to see if you were reading a changelog text for an unfamiliar hardware device? More text is always better! thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A0C5C433EF for ; Mon, 4 Jul 2022 11:35:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IfnfzXHoNwI2qIyUJQ/N0Wlj7ujFxF9hyzvJF7/LriE=; b=uwGZ0b3NRQCwcz q5Je1X7a+zWVWdsjhQSIQ8N6DKjCrdYiz9mWmCOaqgwKt3nmvMisd24WLeIDHiQS+M0y6t7hWkZyv 7m6NKbqLdfUAQG+gSnx1cNHxxxPQfPhCwOyf7Xee4fRdc8aoRYc2uI+xhN6XfyG2l8oyWPSjY8xPP /sOAJkR4EI6optXW4rRxFjFU58+cp6N1sbO8w9rn680dCRr3S/yt6zPE4Ra0TX5JdTLasNvE3g1pX rwFERqtafBxT5Mptcwy8jBilnjbpc9bw6POMgAiVlK3YjnHdkS7zdXuXHwuuxfGMLzpiK8gkxPFBw t6dVKPYK8s/wQIiuZynQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8KLR-007p2U-2U; Mon, 04 Jul 2022 11:34:25 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8JvR-007SvC-5i; Mon, 04 Jul 2022 11:07:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BBF07615F6; Mon, 4 Jul 2022 11:07:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E4F6C3411E; Mon, 4 Jul 2022 11:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656932850; bh=ShPSNOvgzATtn2/Bsxk03dhF7u+9UjNpwSKkcGRvTT0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yg7oJSBac1jklWTdfgCXuJ3ysIGEvXrqf9/zfqWj42Iyu5IX6vLXQxNYM/N8zePVv gl+h3HeUDHDoljmR2gePU76jeomtKSKBVHs4jLc0sVpZAXzp8rEBO43+ANIOsKdZ6Y UAo9IGe43RtjSE/pzqD1J5iVI+6bU5b1kL+Sse4w= Date: Mon, 4 Jul 2022 13:07:27 +0200 From: Greg KH To: szuni chen Cc: ChiaEn Wu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , chiaen_wu@richtek.com, alice_chen@richtek.com, ChiYuan Huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" Subject: Re: [PATCH v4 08/13] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver Message-ID: References: <20220704053901.728-1-peterwu.pub@gmail.com> <20220704053901.728-9-peterwu.pub@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220704_040733_358979_A3F93359 X-CRM114-Status: GOOD ( 20.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdWwgMDQsIDIwMjIgYXQgMDU6MzE6MjlQTSArMDgwMCwgc3p1bmkgY2hlbiB3cm90 ZToKPiBHcmVnIEtIIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4g5pa8IDIwMjLlubQ35pyI NOaXpSDpgLHkuIAg5LiL5Y2IMzozMuWvq+mBk++8mgo+ID4KPiA+IE9uIE1vbiwgSnVsIDA0LCAy MDIyIGF0IDAxOjM4OjU2UE0gKzA4MDAsIENoaWFFbiBXdSB3cm90ZToKPiA+ID4gRnJvbTogQ2hp WXVhbiBIdWFuZyA8Y3lfaHVhbmdAcmljaHRlay5jb20+Cj4gPiA+Cj4gPiA+IEFkZCBjaGlwIGxl dmVsIG10NjM3MCB0Y3BjaSBkcml2ZXIuCj4gPgo+ID4gV2hhdCBkb2VzIHRoaXMgbWVhbj8gIFBs ZWFzZSBwcm92aWRlIG1vcmUgaW5mb3JtYXRpb24gYWJvdXQgdGhlIGhhcmR3YXJlCj4gPiBiZWlu ZyBzdXBwb3J0ZWQgaGVyZSBzbyB3ZSBrbm93IGhvdyB0byByZXZpZXcgdGhpcy4KPiAKPiBEZWFy IEdyZWcsCj4gCj4gTWVkaWFUZWsgTVQ2MzcwIGlzIGEgaGlnaGx5LWludGVncmF0ZWQgc21hcnQg cG93ZXIgbWFuYWdlbWVudCBJQywKPiB3aGljaCBpbmNsdWRlcyBhIHNpbmdsZSBjZWxsIExpLUlv bi9MaS1Qb2x5bWVyIHN3aXRjaGluZyBiYXR0ZXJ5IGNoYXJnZXIsCj4gYSBVU0IgVHlwZS1DICYg UG93ZXIgRGVsaXZlcnkgKFBEKSBjb250cm9sbGVyLCBkdWFsIGZsYXNoIExFRCBjdXJyZW50IHNv dXJjZXMsCj4gYSBSR0IgTEVEIGRyaXZlciwgYSBiYWNrbGlnaHQgV0xFRCBkcml2ZXIsIGEgZGlz cGxheSBiaWFzIGRyaXZlciBhbmQgYQo+IGdlbmVyYWwgTERPIGZvciBwb3J0YWJsZSBkZXZpY2Vz Lgo+IAo+IFRoaXMgZHJpdmVyIGlzIHVzZWQgZm9yIHRoZSBUeXBlLUMgJiBQb3dlciBEZWxpdmVy eSBjb250cm9sbGVyIGluCj4gTWVkaWFUZWsgTVQ2MzcwIElDLgo+IAo+IElmIHdlIGNoYW5nZSB0 aGUgY29tbWl0IG1lc3NhZ2UgdG8KPiAKPiAiQWRkIE1lZGlhVGVrIE1UNjM3MCB0Y3BjaSBkcml2 ZXIuCj4gTWVkaWFUZWsgTVQ2MzcwIGlzIGEgbXVsdGktZnVuY3Rpb25hbCBJQyB0aGF0IGluY2x1 ZGVzIFVTQiBUeXBlLUMuCj4gSXQgd29ya3Mgd2l0aCBUeXBlLUMgUG9ydCBDb250cm9sbGVyIE1h bmFnZXIgdG8gcHJvdmlkZSBVU0IgUEQgYW5kIFVTQgo+IFR5cGUtQyBmdW5jdGlvbmFsaXRpZXMu Igo+IAo+IGRvZXMgdGhpcyBtZWV0IHlvdXIgcmVxdWlyZW1lbnRzPwoKV2hhdCB3b3VsZCB5b3Ug d2FudCB0byBzZWUgaWYgeW91IHdlcmUgcmVhZGluZyBhIGNoYW5nZWxvZyB0ZXh0IGZvciBhbgp1 bmZhbWlsaWFyIGhhcmR3YXJlIGRldmljZT8gIE1vcmUgdGV4dCBpcyBhbHdheXMgYmV0dGVyIQoK dGhhbmtzLAoKZ3JlZyBrLWgKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABC63C43334 for ; Mon, 4 Jul 2022 16:19:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE43910EDB9; Mon, 4 Jul 2022 16:15:27 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8223810E02D for ; Mon, 4 Jul 2022 11:07:33 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BBF07615F6; Mon, 4 Jul 2022 11:07:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E4F6C3411E; Mon, 4 Jul 2022 11:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656932850; bh=ShPSNOvgzATtn2/Bsxk03dhF7u+9UjNpwSKkcGRvTT0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yg7oJSBac1jklWTdfgCXuJ3ysIGEvXrqf9/zfqWj42Iyu5IX6vLXQxNYM/N8zePVv gl+h3HeUDHDoljmR2gePU76jeomtKSKBVHs4jLc0sVpZAXzp8rEBO43+ANIOsKdZ6Y UAo9IGe43RtjSE/pzqD1J5iVI+6bU5b1kL+Sse4w= Date: Mon, 4 Jul 2022 13:07:27 +0200 From: Greg KH To: szuni chen Subject: Re: [PATCH v4 08/13] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver Message-ID: References: <20220704053901.728-1-peterwu.pub@gmail.com> <20220704053901.728-9-peterwu.pub@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:FRAMEBUFFER LAYER" , "Krogerus, Heikki" , Pavel Machek , alice_chen@richtek.com, linux-iio , dri-devel , Liam Girdwood , ChiYuan Huang , Krzysztof Kozlowski , Lee Jones , Linux LED Subsystem , Daniel Thompson , Helge Deller , Rob Herring , Chunfeng Yun , Guenter Roeck , devicetree , Linux PM , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , ChiaEn Wu , linux-arm Mailing List , Jingoo Han , USB , Sebastian Reichel , Linux Kernel Mailing List , chiaen_wu@richtek.com, Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jul 04, 2022 at 05:31:29PM +0800, szuni chen wrote: > Greg KH 於 2022年7月4日 週一 下午3:32寫道： > > > > On Mon, Jul 04, 2022 at 01:38:56PM +0800, ChiaEn Wu wrote: > > > From: ChiYuan Huang > > > > > > Add chip level mt6370 tcpci driver. > > > > What does this mean? Please provide more information about the hardware > > being supported here so we know how to review this. > > Dear Greg, > > MediaTek MT6370 is a highly-integrated smart power management IC, > which includes a single cell Li-Ion/Li-Polymer switching battery charger, > a USB Type-C & Power Delivery (PD) controller, dual flash LED current sources, > a RGB LED driver, a backlight WLED driver, a display bias driver and a > general LDO for portable devices. > > This driver is used for the Type-C & Power Delivery controller in > MediaTek MT6370 IC. > > If we change the commit message to > > "Add MediaTek MT6370 tcpci driver. > MediaTek MT6370 is a multi-functional IC that includes USB Type-C. > It works with Type-C Port Controller Manager to provide USB PD and USB > Type-C functionalities." > > does this meet your requirements? What would you want to see if you were reading a changelog text for an unfamiliar hardware device? More text is always better! thanks, greg k-h