From: Roland Kammerer <roland.kammerer@linbit.com>
To: drbd-announce@lists.linbit.com, drbd-user@lists.linbit.com
Subject: [DRBD-announce] linstor-proxmox v6.0.1-rc.1
Date: Tue, 5 Jul 2022 09:52:13 +0200 [thread overview]
Message-ID: <YsPtrarONjoc0bo6@rck.sh> (raw)
[-- Attachment #1: Type: text/plain, Size: 1869 bytes --]
Dear DRBD/LINSTOR/PVE users,
this is RC1 of the linstor-proxmox plugin 6.0.1. This was triggered by a
bug report[1] and fixes cloning container storage from snapshots in
several ways:
When one clones a container from a snapshot, PVE does:
- activate_volume() a new LINSTOR resource based on the snapshot
(snap_$snapname...).
- create the new image vm-$id... (alloc_image()).
- internally copies the content from that "temporary" snapshot resource
to the new image.
This had several problems:
- if a second clone was created we failed as the "temporary" snapshot
DRBD resource already existed.
- we never removed that "temporary" resource.
The first part is easy, only create that LINSTOR/DRBD resource when
needed, otherwise skip it, that resource is supposed to be read-only.
Deleting is more involved as to my best knowledge we don't get any
"deactivate" call to delete that resource after the copy finished. The
best we can do is to keep that resource and delete it on
volume_snapshot_delete(). We saw that problem already when implementing
vzdump support. I think we can assume that we always want to delete that
snapshot resource when the actual snapshot is removed.
This means that between the clone(s) and the time the base snapshot gets
removed, we keep that temporary/unnecessary resource. But IMO that is
the best we can do and certainly better than not deleting it at all.
Please test, if there aren't any complaints this will be released in
about a week from now. Fetching LINTORPlugin.pm, overwriting the
existing one, and 'systemctl restart pvedaemon.service' should be good
enough to test.
Regards, rck
GIT: https://github.com/LINBIT/linstor-proxmox/commit/c432fb16aac26d6d510ad7f2a689146d2d2c1f95
TGZ: https://pkg.linbit.com//downloads/connectors/linstor-proxmox-6.0.1-rc.1.tar.gz
[1] https://github.com/LINBIT/linstor-proxmox/issues/51
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
reply other threads:[~2022-07-05 7:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsPtrarONjoc0bo6@rck.sh \
--to=roland.kammerer@linbit.com \
--cc=drbd-announce@lists.linbit.com \
--cc=drbd-user@lists.linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.