From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54E2DC43334 for ; Tue, 5 Jul 2022 19:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231681AbiGETgb (ORCPT ); Tue, 5 Jul 2022 15:36:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230135AbiGETgb (ORCPT ); Tue, 5 Jul 2022 15:36:31 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F5FE13FB2; Tue, 5 Jul 2022 12:36:30 -0700 (PDT) Received: from zn.tnic (p200300ea970ff625329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:970f:f625:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DE0E71EC0628; Tue, 5 Jul 2022 21:36:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1657049785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=s8J8d5ZD1NtUU5JRSS/ItcYuS6F4P47XpllivMzf87o=; b=CYAJFqLPSx1ehm7wcUphSX9EWalTFYzy2s5e2vW1knuJ2MgMxhOyXFZiKJxRnn65i1LTXx z6QxxfrgCmuNCUqEFoukAoKTL/2V6JEeQCCX4HCRrDpCeDWCRbeLyIZPGE82Hs3kg+czu+ 9EUDiQHULEW8UFb3P8zZIkSHwIX4AB8= Date: Tue, 5 Jul 2022 21:36:20 +0200 From: Borislav Petkov To: "Jason A. Donenfeld" Cc: linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Catalin Marinas , Will Deacon , Michael Ellerman , Heiko Carstens , Alexander Gordeev , Thomas Gleixner , "H . Peter Anvin" , Greg Kroah-Hartman , Arnd Bergmann Subject: Re: [PATCH] random: remove CONFIG_ARCH_RANDOM and "nordrand" Message-ID: References: <20220705190121.293703-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220705190121.293703-1-Jason@zx2c4.com> Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Tue, Jul 05, 2022 at 09:01:21PM +0200, Jason A. Donenfeld wrote: > @@ -26,7 +18,6 @@ __setup("nordrand", x86_rdrand_setup); > */ > #define SANITY_CHECK_LOOPS 8 > > -#ifdef CONFIG_ARCH_RANDOM > void x86_init_rdrand(struct cpuinfo_x86 *c) > { > unsigned int changed = 0; > @@ -59,8 +50,6 @@ void x86_init_rdrand(struct cpuinfo_x86 *c) > } > > if (WARN_ON_ONCE(!changed)) > - pr_emerg( > -"RDRAND gives funky smelling output, might consider not using it by booting with \"nordrand\""); > + pr_emerg("RDRAND gives funky smelling output; update microcode or firmware."); It is highly unlikely to get a BIOS or microcode update for that matter, for old systems: 7879fc4bdc75 ("x86/rdrand: Sanity-check RDRAND output") so I guess here you're better off saying that the kernel simply disables rdrand support and do clear_cpu_cap(c, X86_FEATURE_RDRAND); here too. If I read the commit message above correctly, it sounds like RDRAND output is not that important anyway... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E80EC43334 for ; Tue, 5 Jul 2022 19:46:45 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LctTw0k6vz3btl for ; Wed, 6 Jul 2022 05:46:44 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=alien8.de header.i=@alien8.de header.a=rsa-sha256 header.s=dkim header.b=CYAJFqLP; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=alien8.de (client-ip=5.9.137.197; helo=mail.skyhub.de; envelope-from=bp@alien8.de; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=alien8.de header.i=@alien8.de header.a=rsa-sha256 header.s=dkim header.b=CYAJFqLP; dkim-atps=neutral X-Greylist: delayed 565 seconds by postgrey-1.36 at boromir; Wed, 06 Jul 2022 05:46:06 AEST Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LctTB2KSnz2yn5 for ; Wed, 6 Jul 2022 05:46:06 +1000 (AEST) Received: from zn.tnic (p200300ea970ff625329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:970f:f625:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DE0E71EC0628; Tue, 5 Jul 2022 21:36:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1657049785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=s8J8d5ZD1NtUU5JRSS/ItcYuS6F4P47XpllivMzf87o=; b=CYAJFqLPSx1ehm7wcUphSX9EWalTFYzy2s5e2vW1knuJ2MgMxhOyXFZiKJxRnn65i1LTXx z6QxxfrgCmuNCUqEFoukAoKTL/2V6JEeQCCX4HCRrDpCeDWCRbeLyIZPGE82Hs3kg+czu+ 9EUDiQHULEW8UFb3P8zZIkSHwIX4AB8= Date: Tue, 5 Jul 2022 21:36:20 +0200 From: Borislav Petkov To: "Jason A. Donenfeld" Subject: Re: [PATCH] random: remove CONFIG_ARCH_RANDOM and "nordrand" Message-ID: References: <20220705190121.293703-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220705190121.293703-1-Jason@zx2c4.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, "H . Peter Anvin" , Arnd Bergmann , Will Deacon , Greg Kroah-Hartman , Catalin Marinas , Heiko Carstens , x86@kernel.org, linux-kernel@vger.kernel.org, Alexander Gordeev , linuxppc-dev@lists.ozlabs.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jul 05, 2022 at 09:01:21PM +0200, Jason A. Donenfeld wrote: > @@ -26,7 +18,6 @@ __setup("nordrand", x86_rdrand_setup); > */ > #define SANITY_CHECK_LOOPS 8 > > -#ifdef CONFIG_ARCH_RANDOM > void x86_init_rdrand(struct cpuinfo_x86 *c) > { > unsigned int changed = 0; > @@ -59,8 +50,6 @@ void x86_init_rdrand(struct cpuinfo_x86 *c) > } > > if (WARN_ON_ONCE(!changed)) > - pr_emerg( > -"RDRAND gives funky smelling output, might consider not using it by booting with \"nordrand\""); > + pr_emerg("RDRAND gives funky smelling output; update microcode or firmware."); It is highly unlikely to get a BIOS or microcode update for that matter, for old systems: 7879fc4bdc75 ("x86/rdrand: Sanity-check RDRAND output") so I guess here you're better off saying that the kernel simply disables rdrand support and do clear_cpu_cap(c, X86_FEATURE_RDRAND); here too. If I read the commit message above correctly, it sounds like RDRAND output is not that important anyway... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E102C433EF for ; Tue, 5 Jul 2022 19:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e3XxEtCGcwYxZ+o3tdRSWuaRmZD6i5MDaLXdrdn+aFM=; b=uGM81YxwB08kP1 MRQP7ph68+6kGi95JL46LF4S/O4YtsGMvRjp6QBEoGjLjahI8E32wXZPrTMcYIje+jySCTcqW3Olp ZWEAoeFjZDzZyLL4TTFlxwS8aPk8m4c1UhMI95pNkUBgWKk+AY5BRbBzGeikm9TB9WXTFXlDP8y3X JhuKjzAvePxGz8LIgMhOKnTLfhgZoQNbEJki9HCaR0CHlI9uYRLmMCQBHGXMdq0Bg0mo8Tah0dMvJ WfWTcyqew8LBodV3zx4mYLVEr/J2FP4ypwyOUOFZkJqYglzzD2l1jvlqqFzwdl0EVEM9YYERoEaXa 8NqZGV3s4IsefNv3k41Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8oLf-002PGA-MH; Tue, 05 Jul 2022 19:36:39 +0000 Received: from mail.skyhub.de ([2a01:4f8:190:11c2::b:1457]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8oLc-002PED-CS for linux-arm-kernel@lists.infradead.org; Tue, 05 Jul 2022 19:36:37 +0000 Received: from zn.tnic (p200300ea970ff625329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:970f:f625:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DE0E71EC0628; Tue, 5 Jul 2022 21:36:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1657049785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=s8J8d5ZD1NtUU5JRSS/ItcYuS6F4P47XpllivMzf87o=; b=CYAJFqLPSx1ehm7wcUphSX9EWalTFYzy2s5e2vW1knuJ2MgMxhOyXFZiKJxRnn65i1LTXx z6QxxfrgCmuNCUqEFoukAoKTL/2V6JEeQCCX4HCRrDpCeDWCRbeLyIZPGE82Hs3kg+czu+ 9EUDiQHULEW8UFb3P8zZIkSHwIX4AB8= Date: Tue, 5 Jul 2022 21:36:20 +0200 From: Borislav Petkov To: "Jason A. Donenfeld" Cc: linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Catalin Marinas , Will Deacon , Michael Ellerman , Heiko Carstens , Alexander Gordeev , Thomas Gleixner , "H . Peter Anvin" , Greg Kroah-Hartman , Arnd Bergmann Subject: Re: [PATCH] random: remove CONFIG_ARCH_RANDOM and "nordrand" Message-ID: References: <20220705190121.293703-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220705190121.293703-1-Jason@zx2c4.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_123636_644230_819344C8 X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 05, 2022 at 09:01:21PM +0200, Jason A. Donenfeld wrote: > @@ -26,7 +18,6 @@ __setup("nordrand", x86_rdrand_setup); > */ > #define SANITY_CHECK_LOOPS 8 > > -#ifdef CONFIG_ARCH_RANDOM > void x86_init_rdrand(struct cpuinfo_x86 *c) > { > unsigned int changed = 0; > @@ -59,8 +50,6 @@ void x86_init_rdrand(struct cpuinfo_x86 *c) > } > > if (WARN_ON_ONCE(!changed)) > - pr_emerg( > -"RDRAND gives funky smelling output, might consider not using it by booting with \"nordrand\""); > + pr_emerg("RDRAND gives funky smelling output; update microcode or firmware."); It is highly unlikely to get a BIOS or microcode update for that matter, for old systems: 7879fc4bdc75 ("x86/rdrand: Sanity-check RDRAND output") so I guess here you're better off saying that the kernel simply disables rdrand support and do clear_cpu_cap(c, X86_FEATURE_RDRAND); here too. If I read the commit message above correctly, it sounds like RDRAND output is not that important anyway... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel