All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Gang Li <ligang.bdlg@bytedance.com>
Cc: Muchun Song <songmuchun@bytedance.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm, hugetlb: skip irrelevant nodes in show_free_areas()
Date: Tue, 5 Jul 2022 15:54:25 -0700	[thread overview]
Message-ID: <YsTBIWFLiHuc6BRQ@monkey> (raw)
In-Reply-To: <20220705092120.2158-1-ligang.bdlg@bytedance.com>

On 07/05/22 17:21, Gang Li wrote:
> show_free_areas() allows to filter out node specific data which is
> irrelevant to the allocation request. But hugetlb_show_meminfo() still
> shows hugetlb on all nodes, which is redundant and unnecessary.
> 
> Use show_mem_node_skip() to skip irrelevant nodes. And replace
> hugetlb_show_meminfo() with hugetlb_show_meminfo_node(nid).
> 
> Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
> ---
> v3: move for_each_hstate() into hugetlb_show_meminfo_node().
> v2: replace hugetlb_show_meminfo() with hugetlb_show_meminfo_node(nid) to avoid
>     exporting show_mem_node_skip.
> ---
>  include/linux/hugetlb.h |  4 ++--
>  mm/hugetlb.c            | 18 ++++++++----------
>  mm/page_alloc.c         |  8 ++++++--
>  3 files changed, 16 insertions(+), 14 deletions(-)

Thanks.  That should make hugetlb information produced by show_free_areas
consistent with other node specific information.

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz


      parent reply	other threads:[~2022-07-05 22:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05  9:21 [PATCH v3] mm, hugetlb: skip irrelevant nodes in show_free_areas() Gang Li
2022-07-05  9:33 ` Muchun Song
2022-07-05 21:25 ` Andrew Morton
2022-07-05 22:06   ` Mike Kravetz
2022-07-05 22:54 ` Mike Kravetz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YsTBIWFLiHuc6BRQ@monkey \
    --to=mike.kravetz@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=ligang.bdlg@bytedance.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=songmuchun@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.