From: Vinod Koul <vkoul@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: nathan@kernel.org, dmaengine@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] dmaengine: imx-dma: Silence a clang warning
Date: Wed, 6 Jul 2022 11:05:55 +0530 [thread overview]
Message-ID: <YsUfOweQimrROAPd@matsya> (raw)
In-Reply-To: <20220526005422.1162090-1-festevam@gmail.com>
On 25-05-22, 21:54, Fabio Estevam wrote:
> Change the of_device_get_match_data() cast to (uintptr_t)
> to silence the following clang warning:
Patch title should describe the change and not the effect of the change.
Pls revise
>
> drivers/dma/imx-dma.c:1048:20: warning: cast to smaller integer type 'enum imx_dma_type' from 'const void *' [-Wvoid-pointer-to-enum-cast]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 0ab785c894e6 ("dmaengine: imx-dma: Remove unused .id_table")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/dma/imx-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index 3bffe3ecbd1b..65c6094ce063 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -1047,7 +1047,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> imxdma->dev = &pdev->dev;
> - imxdma->devtype = (enum imx_dma_type)of_device_get_match_data(&pdev->dev);
> + imxdma->devtype = (uintptr_t)of_device_get_match_data(&pdev->dev);
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> imxdma->base = devm_ioremap_resource(&pdev->dev, res);
> --
> 2.25.1
--
~Vinod
prev parent reply other threads:[~2022-07-06 5:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 0:54 [PATCH] dmaengine: imx-dma: Silence a clang warning Fabio Estevam
2022-07-06 5:35 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsUfOweQimrROAPd@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=lkp@intel.com \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.