From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58BF5CCA473 for ; Wed, 6 Jul 2022 11:38:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E6FB283E30; Wed, 6 Jul 2022 11:38:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E6FB283E30 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lP7e48uUUfXU; Wed, 6 Jul 2022 11:38:41 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id C30D683E0D; Wed, 6 Jul 2022 11:38:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C30D683E0D Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id AA908C0035; Wed, 6 Jul 2022 11:38:40 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 365B9C002D for ; Wed, 6 Jul 2022 11:38:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0320D404C5 for ; Wed, 6 Jul 2022 11:38:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 0320D404C5 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mKHpvTUlBp6h for ; Wed, 6 Jul 2022 11:38:39 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 55C9E400AC Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by smtp2.osuosl.org (Postfix) with ESMTPS id 55C9E400AC for ; Wed, 6 Jul 2022 11:38:39 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 4018F4CC; Wed, 6 Jul 2022 13:38:37 +0200 (CEST) Date: Wed, 6 Jul 2022 13:38:36 +0200 From: Joerg Roedel To: Bo Liu Subject: Re: [PATCH] iommu/amd: Handle return of iommu_device_sysfs_add Message-ID: References: <20220701062008.6988-1-liubo03@inspur.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220701062008.6988-1-liubo03@inspur.com> Cc: iommu@lists.linux-foundation.org, will@kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Fri, Jul 01, 2022 at 02:20:08AM -0400, Bo Liu wrote: > As iommu_device_sysfs_add() can fail, we should check the return value. > > Signed-off-by: Bo Liu > --- > drivers/iommu/amd/init.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Applied, thanks. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DC712F3A for ; Wed, 6 Jul 2022 11:38:39 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 4018F4CC; Wed, 6 Jul 2022 13:38:37 +0200 (CEST) Date: Wed, 6 Jul 2022 13:38:36 +0200 From: Joerg Roedel To: Bo Liu Cc: will@kernel.org, suravee.suthikulpanit@amd.com, iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/amd: Handle return of iommu_device_sysfs_add Message-ID: References: <20220701062008.6988-1-liubo03@inspur.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220701062008.6988-1-liubo03@inspur.com> Message-ID: <20220706113836.9pwqfmVltbth3uYm58Pi0T9qtzBfLasq4nLwnr75oIU@z> On Fri, Jul 01, 2022 at 02:20:08AM -0400, Bo Liu wrote: > As iommu_device_sysfs_add() can fail, we should check the return value. > > Signed-off-by: Bo Liu > --- > drivers/iommu/amd/init.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Applied, thanks.