Re: [PATCH v11 00/36] v4l: routing and streams support

[Tomasz Figa <tfiga@chromium.org>]

On Tue, Mar 01, 2022 at 06:11:20PM +0200, Tomi Valkeinen wrote:
> Hi,
> 
> Here's v11 of the streams series (used to be "multiplexed streams").
> 
> v10 can be found from:
> 
> https://lore.kernel.org/all/20211130141536.891878-1-tomi.valkeinen@ideasonboard.com/
> 
> This series is based on the v5 of the subdev active state:
> 
> https://lore.kernel.org/all/20220301105548.305191-1-tomi.valkeinen@ideasonboard.com/
> 
> My work branch with additional drivers can be found from:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git streams/work-v11
> 
> And there's also the v4l-utils series to add support to v4l2-ctl and
> media-ctl:
> 
> https://lore.kernel.org/all/20211130141815.892354-1-tomi.valkeinen@ideasonboard.com/
> 
> The main changes compared to v10:
> 
> - Rebased on the v5 of the active state series, which has different
>   locking system than what we had in v10 of this series.
> - Moved code around in v4l2-subdev.[ch] so that the functions are inside
>   the correct ifdefs
> - A better route validation helper v4l2_subdev_routing_validate
> - Subdev enable/disable_streams ops (see "media: v4l2-subdev: Add subdev
>   .(enable|disable)_streams() operations")
> 
> There are still some comments I haven't addressed from the v10 review,
> and I'd like to change the route flags a bit. We've also thought about
> adding more support for drivers that don't need multiple streams but
> would still use the new streams APIs to simplify the drivers.
> 
> However, as the v10 is already quite old, and I posted the v5 for the
> active state, I thought it's better to also post the current version of
> the streams series.

Thanks Tomi and everyone for working on this series. With the few nits I
posted addressed:

Reviewed-by: Tomasz Figa <tfiga@chromium.org>

Best regards,
Tomasz