From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70BF1C433EF for ; Thu, 7 Jul 2022 08:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233372AbiGGI5P (ORCPT ); Thu, 7 Jul 2022 04:57:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230211AbiGGI5O (ORCPT ); Thu, 7 Jul 2022 04:57:14 -0400 Received: from gofer.mess.org (gofer.mess.org [IPv6:2a02:8011:d000:212::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 147604D4DC for ; Thu, 7 Jul 2022 01:57:13 -0700 (PDT) Received: by gofer.mess.org (Postfix, from userid 1000) id E827E100071; Thu, 7 Jul 2022 09:57:10 +0100 (BST) Date: Thu, 7 Jul 2022 09:57:10 +0100 From: Sean Young To: Marko =?iso-8859-1?B?TeRrZWzk?= Cc: linux-media@vger.kernel.org Subject: Re: [PATCH] media: rc: Always report LIRC repeat flag Message-ID: References: <20220705085358.44418-1-marko.makela@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Marko, On Wed, Jul 06, 2022 at 07:39:17PM +0300, Marko Mäkelä wrote: > Tue, Jul 05, 2022 at 06:43:55PM +0100, Sean Young wrote: > > On Tue, Jul 05, 2022 at 11:53:58AM +0300, Marko Mäkelä wrote: > > > The flag LIRC_SCANCODE_FLAG_REPEAT was never set by rc_keydown(). > > > Previously it was only set by rc_repeat(), but not all protocol > > > decoders invoke that function. > > > > This should say _why_ you are making this change, not _what_ the change > > is. > > How would you find the following? > > --- > media: lirc: ensure lirc device receives repeats > > Commit de142c32410649e64d44928505ffad2176a96a9e ("media: lirc: implement > reading scancode") would never set the LIRC_SCANCODE_FLAG_REPEAT flag in the > LIRC messages. > > Commit b66218fddfd29f315a103db811152ab0c95fb054 > ("media: lirc: ensure lirc device receives nec repeats") fixed it up for > those protocol drivers that may call rc_repeat(). > --- That's no good. See: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes The heading is called "Describe your changes". Sean