From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD355CCA47B for ; Mon, 11 Jul 2022 09:43:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5E3804BB84; Mon, 11 Jul 2022 05:43:00 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@linux.dev Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TayW2wrBIs31; Mon, 11 Jul 2022 05:42:59 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D2B284BB34; Mon, 11 Jul 2022 05:42:57 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DB04E4B569 for ; Fri, 8 Jul 2022 15:33:57 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BxoEvDPcdXjb for ; Fri, 8 Jul 2022 15:33:56 -0400 (EDT) Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id C85264B531 for ; Fri, 8 Jul 2022 15:33:56 -0400 (EDT) Date: Fri, 8 Jul 2022 12:33:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1657308835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UvsXJEG9CqDhZlAkduXKwdOpQV4TuAtiKD98aN6QoR4=; b=MOIeH5Qx8XM9bKH7gcUX6UVc0q9d9VoT4qCEl+P/TkisvUkENUSmfb0ItDEnLaAeBzvdCv hTtvWEHy/DPDX/iPBJ3eDLJtOpQsuuCvTjAIjkKlmOvEVTep+M6iBb9cxI9rZlRAm0vAQx Qz7ZhcPUnCWYSu8Jyzv2V7DQrA4t8N0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Subject: Re: [PATCH 05/19] KVM: arm64: Consolidate sysreg userspace accesses Message-ID: References: <20220706164304.1582687-1-maz@kernel.org> <20220706164304.1582687-6-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220706164304.1582687-6-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Mailman-Approved-At: Mon, 11 Jul 2022 05:42:55 -0400 Cc: kvm@vger.kernel.org, kernel-team@android.com, Schspa Shi , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Marc, On Wed, Jul 06, 2022 at 05:42:50PM +0100, Marc Zyngier wrote: > Until now, the .set_user and .get_user callbacks have to implement > (directly or not) the userspace memory accesses. Although this gives > us maximem flexibility, this is also a maintenance burden, making it typo: maximum > hard to audit, and I'd feel much better if it was all located in > a single place. > > So let's do just that, simplifying most of the function signatures > in the process (the callbacks are now only concerned with the > data itself, and not with userspace). Much cleaner! > Signed-off-by: Marc Zyngier Reviewed-by: Oliver Upton _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F1D0C43334 for ; Fri, 8 Jul 2022 19:34:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rQL6y9J8DuKQ+ybTe1VxIZ1GBsJkvPwSOj9kCMXyCHs=; b=Rby3BtV9ufN+b3 eBv3RqTAXjQxR93oKs+iwTpsNCZMGfIcJl4+ZN8HM1o6k90j8ABdCTsc0ldgYrOuPYvq6R4Xw/TjK eFuOlAiTjcI9CkJsgEYPZK6ZV0GQ40RE91heXNHN+Jie8TKDA5jbmd8R7LPkA8k2tE/LAzqGEoyRM eBLdGbZgCnej/zaUApo4ehkU8+XzK2S0ftfNmbMT1eiAf1qGTFAMHLOIRmeQl+ds18hhvHrn5mIt5 Tf4vPyfGfeJNCv6c+DTqY4jEo9jBOppMVsWiWFPaQsABMzWvKP3FzAWhf+FPMdqSszYBDX4ZKEOP+ ce6w3BQCXNGOqgLfvwkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9tjm-005cdh-Vw; Fri, 08 Jul 2022 19:34:03 +0000 Received: from out1.migadu.com ([91.121.223.63]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9tjj-005cd4-QI for linux-arm-kernel@lists.infradead.org; Fri, 08 Jul 2022 19:34:01 +0000 Date: Fri, 8 Jul 2022 12:33:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1657308835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UvsXJEG9CqDhZlAkduXKwdOpQV4TuAtiKD98aN6QoR4=; b=MOIeH5Qx8XM9bKH7gcUX6UVc0q9d9VoT4qCEl+P/TkisvUkENUSmfb0ItDEnLaAeBzvdCv hTtvWEHy/DPDX/iPBJ3eDLJtOpQsuuCvTjAIjkKlmOvEVTep+M6iBb9cxI9rZlRAm0vAQx Qz7ZhcPUnCWYSu8Jyzv2V7DQrA4t8N0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Alexandru Elisei , Schspa Shi , kernel-team@android.com Subject: Re: [PATCH 05/19] KVM: arm64: Consolidate sysreg userspace accesses Message-ID: References: <20220706164304.1582687-1-maz@kernel.org> <20220706164304.1582687-6-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220706164304.1582687-6-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220708_123400_284543_455E4007 X-CRM114-Status: GOOD ( 12.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, On Wed, Jul 06, 2022 at 05:42:50PM +0100, Marc Zyngier wrote: > Until now, the .set_user and .get_user callbacks have to implement > (directly or not) the userspace memory accesses. Although this gives > us maximem flexibility, this is also a maintenance burden, making it typo: maximum > hard to audit, and I'd feel much better if it was all located in > a single place. > > So let's do just that, simplifying most of the function signatures > in the process (the callbacks are now only concerned with the > data itself, and not with userspace). Much cleaner! > Signed-off-by: Marc Zyngier Reviewed-by: Oliver Upton _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F2FC433EF for ; Fri, 8 Jul 2022 19:34:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239578AbiGHTeB (ORCPT ); Fri, 8 Jul 2022 15:34:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239775AbiGHTd7 (ORCPT ); Fri, 8 Jul 2022 15:33:59 -0400 Received: from out1.migadu.com (out1.migadu.com [IPv6:2001:41d0:2:863f::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4693101D7 for ; Fri, 8 Jul 2022 12:33:57 -0700 (PDT) Date: Fri, 8 Jul 2022 12:33:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1657308835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UvsXJEG9CqDhZlAkduXKwdOpQV4TuAtiKD98aN6QoR4=; b=MOIeH5Qx8XM9bKH7gcUX6UVc0q9d9VoT4qCEl+P/TkisvUkENUSmfb0ItDEnLaAeBzvdCv hTtvWEHy/DPDX/iPBJ3eDLJtOpQsuuCvTjAIjkKlmOvEVTep+M6iBb9cxI9rZlRAm0vAQx Qz7ZhcPUnCWYSu8Jyzv2V7DQrA4t8N0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Alexandru Elisei , Schspa Shi , kernel-team@android.com Subject: Re: [PATCH 05/19] KVM: arm64: Consolidate sysreg userspace accesses Message-ID: References: <20220706164304.1582687-1-maz@kernel.org> <20220706164304.1582687-6-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220706164304.1582687-6-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Marc, On Wed, Jul 06, 2022 at 05:42:50PM +0100, Marc Zyngier wrote: > Until now, the .set_user and .get_user callbacks have to implement > (directly or not) the userspace memory accesses. Although this gives > us maximem flexibility, this is also a maintenance burden, making it typo: maximum > hard to audit, and I'd feel much better if it was all located in > a single place. > > So let's do just that, simplifying most of the function signatures > in the process (the callbacks are now only concerned with the > data itself, and not with userspace). Much cleaner! > Signed-off-by: Marc Zyngier Reviewed-by: Oliver Upton