From: Sam Ravnborg <sam@ravnborg.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Ondrej Jirman" <megous@megous.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org,
"Jonas Karlman" <jonas@kwiboo.se>,
"Guido Günther" <agx@sigxcpu.org>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Robert Foss" <robert.foss@linaro.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
kernel@pengutronix.de,
"Thierry Reding" <thierry.reding@gmail.com>,
"Purism Kernel Team" <kernel@puri.sm>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Robert Chiras" <robert.chiras@nxp.com>,
"Icenowy Zheng" <icenowy@aosc.io>,
"Jerry Han" <hanxu5@huaqin.corp-partner.google.com>,
"Jagan Teki" <jagan@amarulasolutions.com>
Subject: Re: [PATCH 3/3] drm/mipi-dsi: Make remove callback return void
Date: Sat, 9 Jul 2022 10:50:55 +0200 [thread overview]
Message-ID: <YslBbzfNQgNwUcIm@ravnborg.org> (raw)
In-Reply-To: <20220708094922.1408248-4-u.kleine-koenig@pengutronix.de>
On Fri, Jul 08, 2022 at 11:49:22AM +0200, Uwe Kleine-König wrote:
> All implementations return 0 and the return value of mipi_dsi_drv_remove()
> is ignored anyhow.
>
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed and applied to drm-misc (drm-misc-next).
While applying updating panel-ebbg-ft8719
Sam
next prev parent reply other threads:[~2022-07-09 8:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 9:49 [PATCH 0/3] drm/mipi-dsi: Make remove callback return void Uwe Kleine-König
2022-07-08 9:49 ` [PATCH 1/3] drm/panel: simple: Make panel_simple_remove() " Uwe Kleine-König
2022-07-09 8:51 ` Sam Ravnborg
2022-07-08 9:49 ` [PATCH 2/3] drm/panel-novatek-nt35510: Emit an error message if power off fails Uwe Kleine-König
2022-07-09 8:51 ` Sam Ravnborg
2022-07-08 9:49 ` [PATCH 3/3] drm/mipi-dsi: Make remove callback return void Uwe Kleine-König
2022-07-09 8:50 ` Sam Ravnborg [this message]
2022-07-09 16:28 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YslBbzfNQgNwUcIm@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=agx@sigxcpu.org \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hanxu5@huaqin.corp-partner.google.com \
--cc=icenowy@aosc.io \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=megous@megous.com \
--cc=narmstrong@baylibre.com \
--cc=robert.chiras@nxp.com \
--cc=robert.foss@linaro.org \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.