From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1C1AC433EF for ; Mon, 11 Jul 2022 14:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ES+tnJuZJhqU5y6XhBlqWFVzjYsnyoNAq8uO9QCLNrw=; b=IxSBsTMCWrNppK 0nSQf9Y7PSzG9DWAzVoVnvVE1O6on+/9j6hl8D0qfCRNY0YtZAuHN6n/TVrIEw05katN4K85PXI3W T4YPD0xsI74LWcNDIGHRzqTViaLsgFS9PsqghLH/MeLXvSZvKVaeBT0/nOcRsy5axn9q/pbCzKnbg bndrKXZVeOoYIPJoBuEpq45FOBfk7lySdfDvJSzc23D5m7Q0MNKBRBoIR2rSwIYfZ/3BEvsHX4NOf 9Edf42MV2T5iJ4Bau0VG1TulUgqeqTfDh3PYEisgX0bHtPPVTr/YzMU7sxmR55ImtXMRQCzbEKqn/ 4jvYhCNpClQPQqZo7ghQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAukP-002Za7-7E; Mon, 11 Jul 2022 14:50:53 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAukD-002ZPz-Mx; Mon, 11 Jul 2022 14:50:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 39FF861544; Mon, 11 Jul 2022 14:50:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E29EC3411C; Mon, 11 Jul 2022 14:50:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657551040; bh=MX80YwmblA+v/61UuXjnsNDDbo5cN2GQE6qtQk7/qnk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OO2E9gHGUI8pAsye9LKImxPqcZ+lOe39N3fNLx7J0ta3A0hdy7u6xT3q8dxDCqr1H zebW4Ms/bYVlaWgX7tO8sNgaU39U8/EcVC31dgw2GjNM8fsjp6cJlG/bI565+n7Y4G iRoixb73TYxQV3p9oeKSpNrJ/PKy+T4b2RC1xF4c= Date: Mon, 11 Jul 2022 16:50:38 +0200 From: Greg Kroah-Hartman To: Sudeep Holla Cc: Conor Dooley , Paul Walmsley , Palmer Dabbelt , Palmer Dabbelt , Albert Ou , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Daire McNamara , Conor Dooley , Niklas Cassel , Damien Le Moal , Geert Uytterhoeven , Zong Li , Emil Renner Berthing , Jonas Hahnfeld , Guo Ren , Anup Patel , Atish Patra , Heiko Stuebner , Philipp Tomsich , Rob Herring , Marc Zyngier , Viresh Kumar , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Brice Goglin Subject: Re: [PATCH v3 1/2] arm64: topology: move store_cpu_topology() to shared code Message-ID: References: <20220709152354.2856586-1-mail@conchuod.ie> <20220709152354.2856586-2-mail@conchuod.ie> <20220711143542.nlq6a5nuh4nouomo@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220711143542.nlq6a5nuh4nouomo@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220711_075041_808689_F0062DF3 X-CRM114-Status: GOOD ( 19.06 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Jul 11, 2022 at 03:35:42PM +0100, Sudeep Holla wrote: > On Sat, Jul 09, 2022 at 04:23:54PM +0100, Conor Dooley wrote: > > From: Conor Dooley > > > > arm64's method of defining a default cpu topology requires only minimal > > changes to apply to RISC-V also. The current arm64 implementation exits > > early in a uniprocessor configuration by reading MPIDR & claiming that > > uniprocessor can rely on the default values. > > > > This is appears to be a hangover from prior to '3102bc0e6ac7 ("arm64: > > topology: Stop using MPIDR for topology information")', because the > > current code just assigns default values for multiprocessor systems. > > > > With the MPIDR references removed, store_cpu_topolgy() can be moved to > > the common arch_topology code. > > > > Looks good. FWIW, > > Reviewed-by: Sudeep Holla > > > CC: stable@vger.kernel.org > > However, while I understand the reason why this is needed in stable trees > for RISC-V, I am not sure if we want this for stable tree at-least on arm64. > I leave that part to Greg and Will. Why would it be good for one arch but bad for another? _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D6DDC433EF for ; Mon, 11 Jul 2022 14:51:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wk1orggIcM1Tk0kKobFaGqTu9ORDOC2KxfQ6+eg07LE=; b=feo6kXa2CE+rsN MDtDSepTuEJRtBxl29qWzvl9pLDIbtBuegRcwCNE8M2KWIzJsZ8JsnB5AxlE+4UBaRC0Tzp+/OmOC T2kCGJ4WZ4G4X2fwaSbRj5bnfS0vDg87kZvBNu6axeNn67nyt4SISL8q01WZOvC2rDSo5FZ/7/jdv BW3Y43LbV1kviYrphe230r0uxbO44Y0g/BoXlwk5X419X2Ib4PBYcrOKNlLMB6dG+r5iLz/OcV9Ug rBrVmbBGfmr5XqgCEPYrMMe+TNh4tHaUMblMNF/7ZY8E07Ykn2RaHyxwal5ziIKr1hqZNrjcCVA5O PsvESixMiMNxtR3nCPzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAukG-002ZQv-Sa; Mon, 11 Jul 2022 14:50:45 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAukD-002ZPz-Mx; Mon, 11 Jul 2022 14:50:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 39FF861544; Mon, 11 Jul 2022 14:50:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E29EC3411C; Mon, 11 Jul 2022 14:50:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657551040; bh=MX80YwmblA+v/61UuXjnsNDDbo5cN2GQE6qtQk7/qnk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OO2E9gHGUI8pAsye9LKImxPqcZ+lOe39N3fNLx7J0ta3A0hdy7u6xT3q8dxDCqr1H zebW4Ms/bYVlaWgX7tO8sNgaU39U8/EcVC31dgw2GjNM8fsjp6cJlG/bI565+n7Y4G iRoixb73TYxQV3p9oeKSpNrJ/PKy+T4b2RC1xF4c= Date: Mon, 11 Jul 2022 16:50:38 +0200 From: Greg Kroah-Hartman To: Sudeep Holla Cc: Conor Dooley , Paul Walmsley , Palmer Dabbelt , Palmer Dabbelt , Albert Ou , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Daire McNamara , Conor Dooley , Niklas Cassel , Damien Le Moal , Geert Uytterhoeven , Zong Li , Emil Renner Berthing , Jonas Hahnfeld , Guo Ren , Anup Patel , Atish Patra , Heiko Stuebner , Philipp Tomsich , Rob Herring , Marc Zyngier , Viresh Kumar , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Brice Goglin Subject: Re: [PATCH v3 1/2] arm64: topology: move store_cpu_topology() to shared code Message-ID: References: <20220709152354.2856586-1-mail@conchuod.ie> <20220709152354.2856586-2-mail@conchuod.ie> <20220711143542.nlq6a5nuh4nouomo@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220711143542.nlq6a5nuh4nouomo@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220711_075041_808689_F0062DF3 X-CRM114-Status: GOOD ( 19.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 11, 2022 at 03:35:42PM +0100, Sudeep Holla wrote: > On Sat, Jul 09, 2022 at 04:23:54PM +0100, Conor Dooley wrote: > > From: Conor Dooley > > > > arm64's method of defining a default cpu topology requires only minimal > > changes to apply to RISC-V also. The current arm64 implementation exits > > early in a uniprocessor configuration by reading MPIDR & claiming that > > uniprocessor can rely on the default values. > > > > This is appears to be a hangover from prior to '3102bc0e6ac7 ("arm64: > > topology: Stop using MPIDR for topology information")', because the > > current code just assigns default values for multiprocessor systems. > > > > With the MPIDR references removed, store_cpu_topolgy() can be moved to > > the common arch_topology code. > > > > Looks good. FWIW, > > Reviewed-by: Sudeep Holla > > > CC: stable@vger.kernel.org > > However, while I understand the reason why this is needed in stable trees > for RISC-V, I am not sure if we want this for stable tree at-least on arm64. > I leave that part to Greg and Will. Why would it be good for one arch but bad for another? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBCA1C43334 for ; Mon, 11 Jul 2022 14:50:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231818AbiGKOut (ORCPT ); Mon, 11 Jul 2022 10:50:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230255AbiGKOuo (ORCPT ); Mon, 11 Jul 2022 10:50:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 529ED63939 for ; Mon, 11 Jul 2022 07:50:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 03A7DB81022 for ; Mon, 11 Jul 2022 14:50:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E29EC3411C; Mon, 11 Jul 2022 14:50:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657551040; bh=MX80YwmblA+v/61UuXjnsNDDbo5cN2GQE6qtQk7/qnk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OO2E9gHGUI8pAsye9LKImxPqcZ+lOe39N3fNLx7J0ta3A0hdy7u6xT3q8dxDCqr1H zebW4Ms/bYVlaWgX7tO8sNgaU39U8/EcVC31dgw2GjNM8fsjp6cJlG/bI565+n7Y4G iRoixb73TYxQV3p9oeKSpNrJ/PKy+T4b2RC1xF4c= Date: Mon, 11 Jul 2022 16:50:38 +0200 From: Greg Kroah-Hartman To: Sudeep Holla Cc: Conor Dooley , Paul Walmsley , Palmer Dabbelt , Palmer Dabbelt , Albert Ou , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Daire McNamara , Conor Dooley , Niklas Cassel , Damien Le Moal , Geert Uytterhoeven , Zong Li , Emil Renner Berthing , Jonas Hahnfeld , Guo Ren , Anup Patel , Atish Patra , Heiko Stuebner , Philipp Tomsich , Rob Herring , Marc Zyngier , Viresh Kumar , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Brice Goglin Subject: Re: [PATCH v3 1/2] arm64: topology: move store_cpu_topology() to shared code Message-ID: References: <20220709152354.2856586-1-mail@conchuod.ie> <20220709152354.2856586-2-mail@conchuod.ie> <20220711143542.nlq6a5nuh4nouomo@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220711143542.nlq6a5nuh4nouomo@bogus> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 11, 2022 at 03:35:42PM +0100, Sudeep Holla wrote: > On Sat, Jul 09, 2022 at 04:23:54PM +0100, Conor Dooley wrote: > > From: Conor Dooley > > > > arm64's method of defining a default cpu topology requires only minimal > > changes to apply to RISC-V also. The current arm64 implementation exits > > early in a uniprocessor configuration by reading MPIDR & claiming that > > uniprocessor can rely on the default values. > > > > This is appears to be a hangover from prior to '3102bc0e6ac7 ("arm64: > > topology: Stop using MPIDR for topology information")', because the > > current code just assigns default values for multiprocessor systems. > > > > With the MPIDR references removed, store_cpu_topolgy() can be moved to > > the common arch_topology code. > > > > Looks good. FWIW, > > Reviewed-by: Sudeep Holla > > > CC: stable@vger.kernel.org > > However, while I understand the reason why this is needed in stable trees > for RISC-V, I am not sure if we want this for stable tree at-least on arm64. > I leave that part to Greg and Will. Why would it be good for one arch but bad for another?