* [f2fs-dev] [PATCH v2] f2fs: allow compression of files without blocks
@ 2022-07-07 9:09 ` Chao Liu
0 siblings, 0 replies; 8+ messages in thread
From: Chao Liu @ 2022-07-07 9:09 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu
Cc: Chao Liu, Wayne Zhang, Yue Hu, linux-kernel, linux-f2fs-devel
From: Chao Liu <liuchao@coolpad.com>
Files created by truncate(1) have a size but no blocks, so
they can be allowed to enable compression.
Signed-off-by: Chao Liu <liuchao@coolpad.com>
---
v2:
- update commit message: truncate -> truncate(1)
fs/f2fs/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 0f29af7876a6..f7a82858486a 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1879,7 +1879,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
if (iflags & F2FS_COMPR_FL) {
if (!f2fs_may_compress(inode))
return -EINVAL;
- if (S_ISREG(inode->i_mode) && inode->i_size)
+ if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode))
return -EINVAL;
set_compress_context(inode);
--
2.36.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2] f2fs: allow compression of files without blocks
@ 2022-07-07 9:09 ` Chao Liu
0 siblings, 0 replies; 8+ messages in thread
From: Chao Liu @ 2022-07-07 9:09 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu
Cc: linux-f2fs-devel, linux-kernel, Yue Hu, Wayne Zhang, Chao Liu
From: Chao Liu <liuchao@coolpad.com>
Files created by truncate(1) have a size but no blocks, so
they can be allowed to enable compression.
Signed-off-by: Chao Liu <liuchao@coolpad.com>
---
v2:
- update commit message: truncate -> truncate(1)
fs/f2fs/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 0f29af7876a6..f7a82858486a 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1879,7 +1879,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
if (iflags & F2FS_COMPR_FL) {
if (!f2fs_may_compress(inode))
return -EINVAL;
- if (S_ISREG(inode->i_mode) && inode->i_size)
+ if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode))
return -EINVAL;
set_compress_context(inode);
--
2.36.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [f2fs-dev] [PATCH v2] f2fs: allow compression of files without blocks
2022-07-07 9:09 ` Chao Liu
@ 2022-07-07 13:32 ` Chao Yu
-1 siblings, 0 replies; 8+ messages in thread
From: Chao Yu @ 2022-07-07 13:32 UTC (permalink / raw)
To: Chao Liu, Jaegeuk Kim
Cc: Chao Liu, Wayne Zhang, Yue Hu, linux-kernel, linux-f2fs-devel
On 2022/7/7 17:09, Chao Liu wrote:
> From: Chao Liu <liuchao@coolpad.com>
>
> Files created by truncate(1) have a size but no blocks, so
> they can be allowed to enable compression.
>
> Signed-off-by: Chao Liu <liuchao@coolpad.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [f2fs-dev] [PATCH v2] f2fs: allow compression of files without blocks
2022-07-07 9:09 ` Chao Liu
@ 2022-07-12 1:36 ` Jaegeuk Kim
-1 siblings, 0 replies; 8+ messages in thread
From: Jaegeuk Kim @ 2022-07-12 1:36 UTC (permalink / raw)
To: Chao Liu; +Cc: Chao Liu, linux-kernel, Wayne Zhang, Yue Hu, linux-f2fs-devel
On 07/07, Chao Liu wrote:
> From: Chao Liu <liuchao@coolpad.com>
>
> Files created by truncate(1) have a size but no blocks, so
> they can be allowed to enable compression.
>
> Signed-off-by: Chao Liu <liuchao@coolpad.com>
> ---
> v2:
> - update commit message: truncate -> truncate(1)
>
> fs/f2fs/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 0f29af7876a6..f7a82858486a 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1879,7 +1879,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
> if (iflags & F2FS_COMPR_FL) {
> if (!f2fs_may_compress(inode))
> return -EINVAL;
> - if (S_ISREG(inode->i_mode) && inode->i_size)
> + if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode))
What about inline_data case?
> return -EINVAL;
>
> set_compress_context(inode);
> --
> 2.36.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] f2fs: allow compression of files without blocks
@ 2022-07-12 1:36 ` Jaegeuk Kim
0 siblings, 0 replies; 8+ messages in thread
From: Jaegeuk Kim @ 2022-07-12 1:36 UTC (permalink / raw)
To: Chao Liu
Cc: Chao Yu, linux-f2fs-devel, linux-kernel, Yue Hu, Wayne Zhang,
Chao Liu
On 07/07, Chao Liu wrote:
> From: Chao Liu <liuchao@coolpad.com>
>
> Files created by truncate(1) have a size but no blocks, so
> they can be allowed to enable compression.
>
> Signed-off-by: Chao Liu <liuchao@coolpad.com>
> ---
> v2:
> - update commit message: truncate -> truncate(1)
>
> fs/f2fs/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 0f29af7876a6..f7a82858486a 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1879,7 +1879,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
> if (iflags & F2FS_COMPR_FL) {
> if (!f2fs_may_compress(inode))
> return -EINVAL;
> - if (S_ISREG(inode->i_mode) && inode->i_size)
> + if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode))
What about inline_data case?
> return -EINVAL;
>
> set_compress_context(inode);
> --
> 2.36.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [f2fs-dev] [PATCH v2] f2fs: allow compression of files without blocks
2022-07-12 1:36 ` Jaegeuk Kim
@ 2022-07-12 3:20 ` Chao Yu
-1 siblings, 0 replies; 8+ messages in thread
From: Chao Yu @ 2022-07-12 3:20 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Liu
Cc: Chao Liu, Wayne Zhang, Yue Hu, linux-kernel, linux-f2fs-devel
On 2022/7/12 9:36, Jaegeuk Kim wrote:
> On 07/07, Chao Liu wrote:
>> From: Chao Liu <liuchao@coolpad.com>
>>
>> Files created by truncate(1) have a size but no blocks, so
>> they can be allowed to enable compression.
>>
>> Signed-off-by: Chao Liu <liuchao@coolpad.com>
>> ---
>> v2:
>> - update commit message: truncate -> truncate(1)
>>
>> fs/f2fs/file.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
>> index 0f29af7876a6..f7a82858486a 100644
>> --- a/fs/f2fs/file.c
>> +++ b/fs/f2fs/file.c
>> @@ -1879,7 +1879,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
>> if (iflags & F2FS_COMPR_FL) {
>> if (!f2fs_may_compress(inode))
>> return -EINVAL;
>> - if (S_ISREG(inode->i_mode) && inode->i_size)
>> + if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode))
>
> What about inline_data case?
How about fixing this w/ a separated patch?
f2fs: fix to check inline_data during compressed inode conversion
Thanks,
>
>> return -EINVAL;
>>
>> set_compress_context(inode);
>> --
>> 2.36.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] f2fs: allow compression of files without blocks
@ 2022-07-12 3:20 ` Chao Yu
0 siblings, 0 replies; 8+ messages in thread
From: Chao Yu @ 2022-07-12 3:20 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Liu
Cc: linux-f2fs-devel, linux-kernel, Yue Hu, Wayne Zhang, Chao Liu
On 2022/7/12 9:36, Jaegeuk Kim wrote:
> On 07/07, Chao Liu wrote:
>> From: Chao Liu <liuchao@coolpad.com>
>>
>> Files created by truncate(1) have a size but no blocks, so
>> they can be allowed to enable compression.
>>
>> Signed-off-by: Chao Liu <liuchao@coolpad.com>
>> ---
>> v2:
>> - update commit message: truncate -> truncate(1)
>>
>> fs/f2fs/file.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
>> index 0f29af7876a6..f7a82858486a 100644
>> --- a/fs/f2fs/file.c
>> +++ b/fs/f2fs/file.c
>> @@ -1879,7 +1879,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
>> if (iflags & F2FS_COMPR_FL) {
>> if (!f2fs_may_compress(inode))
>> return -EINVAL;
>> - if (S_ISREG(inode->i_mode) && inode->i_size)
>> + if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode))
>
> What about inline_data case?
How about fixing this w/ a separated patch?
f2fs: fix to check inline_data during compressed inode conversion
Thanks,
>
>> return -EINVAL;
>>
>> set_compress_context(inode);
>> --
>> 2.36.1
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-12 3:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-07 9:09 [f2fs-dev] [PATCH v2] f2fs: allow compression of files without blocks Chao Liu
2022-07-07 9:09 ` Chao Liu
2022-07-07 13:32 ` [f2fs-dev] " Chao Yu
2022-07-07 13:32 ` Chao Yu
2022-07-12 1:36 ` [f2fs-dev] " Jaegeuk Kim
2022-07-12 1:36 ` Jaegeuk Kim
2022-07-12 3:20 ` [f2fs-dev] " Chao Yu
2022-07-12 3:20 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.