From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org,
Domingo Dirutigliano <pwnzer0tt1@proton.me>
Subject: Re: [PATCH nf] netfilter: nf_queue: do not allow packet truncation below transport header offset
Date: Tue, 26 Jul 2022 15:26:58 +0200 [thread overview]
Message-ID: <Yt/roiIPwtTFbVXk@salvia> (raw)
In-Reply-To: <20220726104206.2036-1-fw@strlen.de>
On Tue, Jul 26, 2022 at 12:42:06PM +0200, Florian Westphal wrote:
> Domingo Dirutigliano and Nicola Guerrera report kernel panic when
> sending nf_queue verdict with 1-byte nfta_payload attribute.
>
> The IP/IPv6 stack pulls the IP(v6) header from the packet after the
> input hook.
>
> If user truncates the packet below the header size, this skb_pull() will
> result in a malformed skb (skb->len < 0).
>
> Fixes: 7af4cc3fa158 ("[NETFILTER]: Add "nfnetlink_queue" netfilter queue handler over nfnetlink")
> Reported-by: Domingo Dirutigliano <pwnzer0tt1@proton.me>
Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>
> Signed-off-by: Florian Westphal <fw@strlen.de>
prev parent reply other threads:[~2022-07-26 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 10:42 [PATCH nf] netfilter: nf_queue: do not allow packet truncation below transport header offset Florian Westphal
2022-07-26 13:26 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yt/roiIPwtTFbVXk@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pwnzer0tt1@proton.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.