From: Borislav Petkov <bp@suse.de>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-efi <linux-efi@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Thadeu Lima de Souza Cascardo <cascardo@canonical.com>,
Peter Zijlstra <peterz@infradead.org>,
Josh Poimboeuf <jpoimboe@kernel.org>
Subject: Re: [PATCH] efi/x86-mixed: leave RET unmitigated but move it into .rodata
Date: Sun, 24 Jul 2022 19:27:56 +0200 [thread overview]
Message-ID: <Yt2BHIMhXPd0cuMt@zn.tnic> (raw)
In-Reply-To: <CAMj1kXGT7OEZc3Y6B-AcWWmec2POZFYb+UpE1eMcHuVag9LSew@mail.gmail.com>
On Sun, Jul 24, 2022 at 10:39:45AM +0200, Ard Biesheuvel wrote:
> Fair enough. I still think it is better for general hygiene to apply
> these changes, but if there is no urgency, I'll leave this for now and
> revisit+rebase somewhere during the next cycle.
Best it would be if you do that early in the cycle so that it gets
maximum testing in linux-next.
Oh, and my compiler doesn't like it for whatever reason:
/tmp/ccLB2vIC.s: Assembler messages:
/tmp/ccLB2vIC.s: Error: invalid operands (.rodata and .text sections) for `-' when setting `.L__sym_size___efi64_thunk'
make[3]: *** [scripts/Makefile.build:322: arch/x86/platform/efi/efi_thunk_64.o] Error 1
make[3]: *** Waiting for unfinished jobs....
But otherwise, I like the direction where this is going, of us not
mapping as much into the EFI PGT. But I've said that already...
Thx.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
(HRB 36809, AG Nürnberg)
next prev parent reply other threads:[~2022-07-24 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 16:06 [PATCH] efi/x86-mixed: leave RET unmitigated but move it into .rodata Ard Biesheuvel
2022-07-23 17:20 ` Linus Torvalds
2022-07-24 8:39 ` Ard Biesheuvel
2022-07-24 17:27 ` Borislav Petkov [this message]
2022-07-24 18:34 ` Ard Biesheuvel
2022-07-24 19:17 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yt2BHIMhXPd0cuMt@zn.tnic \
--to=bp@suse.de \
--cc=ardb@kernel.org \
--cc=cascardo@canonical.com \
--cc=jpoimboe@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.