All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 7/7] opeposix: pthread_barrierattr_getpshared/2-1: Simplify codeflow
Date: Thu, 14 Jul 2022 15:03:44 +0200	[thread overview]
Message-ID: <YtAUMCRnpM1zHug1@yuki> (raw)
In-Reply-To: <0168e60b-9c56-af45-d754-75ce09b359fc@suse.cz>

Hi!
> > +	} else {
> > +		return serial;
> 
> The return can be unconditional.

I changed the code a bit more in the end to make it even more readable,
now it's structured as:

	if (pid == 0)
		return serial;

	/* parent */
	if (wait(&status) != pid) {
		...
	}
	...

	printf("Test PASSED\n");
	return PTS_PASS;

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2022-07-14 13:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20  9:21 [LTP] [PATCH 0/7] openposix: Fix 'no return in nonvoid function' warnings Cyril Hrubis
2022-06-20  9:21 ` [LTP] [PATCH 1/7] openposix: pthread_rwlockattr_getpshared/2-1: Fix Cyril Hrubis
2022-07-05  5:16   ` Richard Palethorpe
2022-06-20  9:21 ` [LTP] [PATCH 2/7] openposix: pthread_spin_init/{2-1,2-2}: Fix Cyril Hrubis
2022-07-05  5:20   ` Richard Palethorpe
2022-06-20  9:21 ` [LTP] [PATCH 3/7] openposix: sem_destroy/3-1: Fix Cyril Hrubis
2022-07-05  5:23   ` Richard Palethorpe
2022-06-20  9:21 ` [LTP] [PATCH 4/7] openposix: sem_timedwait/11-1: Fix Cyril Hrubis
2022-06-23  9:57   ` Martin Doucha
2022-07-05  5:34     ` Richard Palethorpe
2022-06-20  9:21 ` [LTP] [PATCH 5/7] openposix: aio_h/2-1: Add return at the end of main() Cyril Hrubis
2022-07-05  5:24   ` Richard Palethorpe
2022-06-20  9:21 ` [LTP] [PATCH 6/7] openposix: mq_timedreceive: Silence warning Cyril Hrubis
2022-07-05  5:25   ` Richard Palethorpe
2022-06-20  9:21 ` [LTP] [PATCH 7/7] opeposix: pthread_barrierattr_getpshared/2-1: Simplify codeflow Cyril Hrubis
2022-06-23 12:38   ` Martin Doucha
2022-07-05  5:35     ` Richard Palethorpe
2022-07-14 13:03     ` Cyril Hrubis [this message]
2022-06-23  8:49 ` [LTP] [PATCH 0/7] openposix: Fix 'no return in nonvoid function' warnings Li Wang
2022-07-14 13:05   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtAUMCRnpM1zHug1@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.