From: Greg KH <greg@kroah.com>
To: James Morse <james.morse@arm.com>
Cc: stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Sumit Gupta <sumitg@nvidia.com>
Subject: Re: [stable:PATCH v4.9.323] arm64: entry: Restore tramp_map_kernel ISB
Date: Thu, 14 Jul 2022 20:33:56 +0200 [thread overview]
Message-ID: <YtBhlADgSRAnLePW@kroah.com> (raw)
In-Reply-To: <20220714162225.280073-1-james.morse@arm.com>
On Thu, Jul 14, 2022 at 05:22:25PM +0100, James Morse wrote:
> Summit reports that the BHB backports for v4.9 prevent vulnerable
> platforms from booting when CONFIG_RANDOMIZE_BASE is enabled.
>
> This is because the trampoline code takes a translation fault when
> accessing the data page, because the TTBR write hasn't been completed
> by an ISB before the access is made.
>
> Upstream has a complex erratum workaround for QCOM_FALKOR_E1003 in
> this area, which removes the ISB when the workaround has been applied.
> v4.9 lacks this workaround, but should still have the ISB.
>
> Restore the barrier.
>
> Fixes: aee10c2dd013 ("arm64: entry: Add macro for reading symbol addresses from the trampoline")
> Reported-by: Sumit Gupta <sumitg@nvidia.com>
> Tested-by: Sumit Gupta <sumitg@nvidia.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
> This only applies to the v4.9 backport, as v4.14 has the QCOM_FALKOR_E1003
> workaround.
>
> arch/arm64/kernel/entry.S | 1 +
> 1 file changed, 1 insertion(+)
Now queued up, thanks.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: James Morse <james.morse@arm.com>
Cc: stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Sumit Gupta <sumitg@nvidia.com>
Subject: Re: [stable:PATCH v4.9.323] arm64: entry: Restore tramp_map_kernel ISB
Date: Thu, 14 Jul 2022 20:33:56 +0200 [thread overview]
Message-ID: <YtBhlADgSRAnLePW@kroah.com> (raw)
In-Reply-To: <20220714162225.280073-1-james.morse@arm.com>
On Thu, Jul 14, 2022 at 05:22:25PM +0100, James Morse wrote:
> Summit reports that the BHB backports for v4.9 prevent vulnerable
> platforms from booting when CONFIG_RANDOMIZE_BASE is enabled.
>
> This is because the trampoline code takes a translation fault when
> accessing the data page, because the TTBR write hasn't been completed
> by an ISB before the access is made.
>
> Upstream has a complex erratum workaround for QCOM_FALKOR_E1003 in
> this area, which removes the ISB when the workaround has been applied.
> v4.9 lacks this workaround, but should still have the ISB.
>
> Restore the barrier.
>
> Fixes: aee10c2dd013 ("arm64: entry: Add macro for reading symbol addresses from the trampoline")
> Reported-by: Sumit Gupta <sumitg@nvidia.com>
> Tested-by: Sumit Gupta <sumitg@nvidia.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
> This only applies to the v4.9 backport, as v4.14 has the QCOM_FALKOR_E1003
> workaround.
>
> arch/arm64/kernel/entry.S | 1 +
> 1 file changed, 1 insertion(+)
Now queued up, thanks.
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-14 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 16:22 [stable:PATCH v4.9.323] arm64: entry: Restore tramp_map_kernel ISB James Morse
2022-07-14 16:22 ` James Morse
2022-07-14 18:33 ` Patch "arm64: entry: Restore tramp_map_kernel ISB" has been added to the 4.9-stable tree gregkh
2022-07-14 18:33 ` Greg KH [this message]
2022-07-14 18:33 ` [stable:PATCH v4.9.323] arm64: entry: Restore tramp_map_kernel ISB Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtBhlADgSRAnLePW@kroah.com \
--to=greg@kroah.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=sumitg@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.