From: Mike Snitzer <snitzer@redhat.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: hch@infradead.org, dm-devel@redhat.com
Subject: Re: [dm-devel] [PATCH 2/3] dm: Start pr_reserve from the same starting path
Date: Thu, 14 Jul 2022 14:49:16 -0400 [thread overview]
Message-ID: <YtBlLDShzLdW8xDx@redhat.com> (raw)
In-Reply-To: <0c2c37c2-84f0-d6c7-b060-be7c5ba6dede@oracle.com>
On Sat, Jul 09 2022 at 11:06P -0400,
Mike Christie <michael.christie@oracle.com> wrote:
> On 7/7/22 3:27 PM, Mike Christie wrote:
> > When an app does a pr_reserve it will go to whatever path we happen to
> > be using at the time. This can result in errors where the app does a
> > second pr_reserve call and expects success but gets a failure becuase
> > the reserve is not done on the holder's path. This patch has us always
> > start trying to do reserves from the first path in the first group.
> >
>
> Hi,
>
> Giving myself a review comment. pr_preempt can also establish a reservation.
> I meant to send a patch for that as well. If the approach in this patchset is
> ok, I'll send a patch for that as well.
>
It'd be nice to have Christoph weigh-in on these changes but I'm OK
with them in general.
But please give details on what you've tested them against. I assume
the Windows cluster? How about pacemaker? And all looks good on other
systems that don't have the requirement to pin the PR to a device?
Once I have this context on testing I can then work through the
changes more closely and get them staged. Please do feel free to send
a v2 that conveys what testing was done and you're welcome to sned the
patch for pr_preempt too.
Thanks,
Mike
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-07-14 18:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 20:27 [dm-devel] [PATCH 0/3] dm pr_ops fixes Mike Christie
2022-07-07 20:27 ` [dm-devel] [PATCH 1/3] dm: Allow dm_call_pr to be used for path searches Mike Christie
2022-07-07 20:27 ` [dm-devel] [PATCH 2/3] dm: Start pr_reserve from the same starting path Mike Christie
2022-07-09 15:06 ` Mike Christie
2022-07-14 18:49 ` Mike Snitzer [this message]
2022-07-15 0:34 ` Mike Christie
2022-07-15 20:38 ` michael.christie
2022-07-18 5:55 ` Christoph Hellwig
2022-07-18 17:39 ` Mike Christie
2022-07-18 18:28 ` michael.christie
2022-07-20 6:16 ` Christoph Hellwig
2022-07-20 17:02 ` Mike Christie
2022-07-07 20:27 ` [dm-devel] [PATCH 3/3] dm: Fix PR release handling for non All Registrants Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtBlLDShzLdW8xDx@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=michael.christie@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.