From: Stephan Gerhold <stephan@gerhold.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Stephan Gerhold <stephan.gerhold@kernkonzept.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sireesh Kodali <sireeshkodali1@gmail.com>,
Luca Weiss <luca@z3ntu.xyz>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: remoteproc: qcom,q6v5: Move MSM8916 to schema
Date: Fri, 15 Jul 2022 10:00:20 +0200 [thread overview]
Message-ID: <YtEeay9JCaG2NMdT@gerhold.net> (raw)
In-Reply-To: <cd8a2b66-ba7c-768c-f5b0-2728f0a8be99@linaro.org>
On Fri, Jul 15, 2022 at 08:33:53AM +0200, Krzysztof Kozlowski wrote:
> On 14/07/2022 20:48, Stephan Gerhold wrote:
> > On Thu, Jul 14, 2022 at 11:50:30AM +0200, Krzysztof Kozlowski wrote:
> >> On 12/07/2022 14:44, Stephan Gerhold wrote:
> >>> [...]
> >>> +properties:
> >>> + compatible:
> >>> + oneOf:
> >>> + - enum:
> >>> + - qcom,msm8916-mss-pil
> >>> +
> >>> + - const: qcom,q6v5-pil
> >>> + description: Deprecated, prefer using qcom,msm8916-mss-pil
> >>> + deprecated: true
> >>
> >> The last compatible does not seem applicable here. Aren't you moving
> >> only MSM8916 to new schema?
> >>
> >
> > "qcom,q6v5-pil" is exactly the same as "qcom,msm8916-mss-pil". It's just
> > a deprecated quite unfortunately chosen old name for the same thing. :)
> >
> > See these lines in the driver:
> >
> > { .compatible = "qcom,q6v5-pil", .data = &msm8916_mss},
> > { .compatible = "qcom,msm8916-mss-pil", .data = &msm8916_mss},
>
> Yeah, but previous bindings were not mentioning it alone, so this would
> not be a direct conversion.
>
Sorry, I'm not sure I understand you correctly: What do you mean with
"the previous bindings were not mentioning it alone"? "qcom,q6v5-pil"
was listed as standalone compatible just like all the other compatibles:
- compatible:
Usage: required
Value type: <string>
Definition: must be one of:
"qcom,q6v5-pil", <----
"qcom,ipq8074-wcss-pil"
"qcom,qcs404-wcss-pil"
"qcom,msm8916-mss-pil", <----
"qcom,msm8974-mss-pil"
"qcom,msm8996-mss-pil"
"qcom,msm8998-mss-pil"
"qcom,sc7180-mss-pil"
"qcom,sc7280-mss-pil"
"qcom,sdm845-mss-pil"
The only non-conversion steps I did was to mark some of the redundant
bindings as deprecated (e.g. "memory-region" with 2 items vs "mba" and
"mpss" subnode, "qcom,msm8916-mss-pil" vs "qcom,q6v5-pil"). I can put
the deprecations in a separate patch if that clarifies the situation.
Thanks,
Stephan
next prev parent reply other threads:[~2022-07-15 8:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 12:44 [PATCH 0/6] remoteproc: qcom_q6v5_mss: Add MSM8909 Stephan Gerhold
2022-07-12 12:44 ` [PATCH 1/6] arm64: dts: qcom: msm8916: Drop MSS fallback compatible Stephan Gerhold
2022-07-14 9:45 ` Krzysztof Kozlowski
2022-07-12 12:44 ` [PATCH 2/6] dt-bindings: remoteproc: qcom,q6v5: Move MSM8916 to schema Stephan Gerhold
2022-07-12 14:26 ` Rob Herring
2022-07-14 9:50 ` Krzysztof Kozlowski
2022-07-14 18:48 ` Stephan Gerhold
2022-07-15 6:33 ` Krzysztof Kozlowski
2022-07-15 8:00 ` Stephan Gerhold [this message]
2022-07-15 8:09 ` Krzysztof Kozlowski
2022-07-12 12:44 ` [PATCH 3/6] ARM: dts: qcom: msm8974: Disable remoteprocs by default Stephan Gerhold
2022-07-14 9:55 ` Krzysztof Kozlowski
2022-07-14 19:01 ` Stephan Gerhold
2022-07-15 6:44 ` Krzysztof Kozlowski
2022-07-17 3:08 ` (subset) " Bjorn Andersson
2022-07-12 12:44 ` [PATCH 4/6] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8974 Stephan Gerhold
2022-07-14 9:56 ` Krzysztof Kozlowski
2022-07-12 12:44 ` [PATCH 5/6] dt-bindings: remoteproc: qcom,q6v5-pil: Add MSM8909 Stephan Gerhold
2022-07-14 9:57 ` Krzysztof Kozlowski
2022-07-12 12:44 ` [PATCH 6/6] remoteproc: qcom_q6v5_mss: Add support for MSM8909 Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtEeay9JCaG2NMdT@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sireeshkodali1@gmail.com \
--cc=stephan.gerhold@kernkonzept.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.