From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
netdev@vger.kernel.org, rafael@kernel.org,
sean.wang@mediatek.com, Landen.Chao@mediatek.com,
linus.walleij@linaro.org, andrew@lunn.ch,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk,
hkallweit1@gmail.com, gjb@semihalf.com, jaz@semihalf.com,
tn@semihalf.com, Samer.El-Haj-Mahmoud@arm.com,
upstream@semihalf.com
Subject: Re: [net-next: PATCH v2 5/8] device property: introduce fwnode_dev_node_match
Date: Fri, 15 Jul 2022 22:36:29 +0300 [thread overview]
Message-ID: <YtHBvb/kh/Sl0cmz@smile.fi.intel.com> (raw)
In-Reply-To: <20220715085012.2630214-6-mw@semihalf.com>
On Fri, Jul 15, 2022 at 10:50:09AM +0200, Marcin Wojtas wrote:
> This patch adds a new generic routine fwnode_dev_node_match
> that can be used e.g. as a callback for class_find_device().
> It searches for the struct device corresponding to a
> struct fwnode_handle by iterating over device and
> its parents.
Implementation
1) misses the word 'parent';
2) located outside of the group of fwnode APIs operating on parents.
I would suggest to rename to fwnode_get_next_parent_node() and place
near to fwnode_get_next_parent_dev() (either before or after, where
it makes more sense).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-07-15 19:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 8:50 [net-next: PATCH v2 0/8] DSA: switch to fwnode_/device_ Marcin Wojtas
2022-07-15 8:50 ` [net-next: PATCH v2 1/8] net: phy: fixed_phy: switch to fwnode_ API Marcin Wojtas
2022-07-15 17:20 ` Florian Fainelli
2022-07-15 19:10 ` Marcin Wojtas
2022-07-15 8:50 ` [net-next: PATCH v2 2/8] net: mdio: switch fixed-link PHYs API to fwnode_ Marcin Wojtas
2022-07-15 8:50 ` [net-next: PATCH v2 3/8] net: dsa: switch to device_/fwnode_ APIs Marcin Wojtas
2022-07-15 19:25 ` Andy Shevchenko
2022-07-15 19:36 ` Marcin Wojtas
2022-07-15 8:50 ` [net-next: PATCH v2 4/8] net: mvpp2: initialize port fwnode pointer Marcin Wojtas
2022-07-15 8:50 ` [net-next: PATCH v2 5/8] device property: introduce fwnode_dev_node_match Marcin Wojtas
2022-07-15 19:36 ` Andy Shevchenko [this message]
2022-07-15 19:42 ` Andy Shevchenko
2022-07-15 23:15 ` Marcin Wojtas
2022-07-18 12:26 ` Andy Shevchenko
2022-07-15 8:50 ` [net-next: PATCH v2 6/8] net: core: switch to fwnode_find_net_device_by_node() Marcin Wojtas
2022-07-15 8:50 ` [net-next: PATCH v2 7/8] net: mdio: introduce fwnode_mdiobus_register_device() Marcin Wojtas
2022-07-15 8:50 ` [net-next: PATCH v2 8/8] net: dsa: mv88e6xxx: switch to device_/fwnode_ APIs Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtHBvb/kh/Sl0cmz@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Landen.Chao@mediatek.com \
--cc=Samer.El-Haj-Mahmoud@arm.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gjb@semihalf.com \
--cc=hkallweit1@gmail.com \
--cc=jaz@semihalf.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=tn@semihalf.com \
--cc=upstream@semihalf.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.