From: Andrew Lunn <andrew@lunn.ch>
To: Andrey Turkin <andrey.turkin@gmail.com>
Cc: netdev@vger.kernel.org, Ronak Doshi <doshir@vmware.com>,
VMware PV-Drivers Reviewers <pv-drivers@vmware.com>
Subject: Re: [PATCH] vmxnet3: Implement ethtool's get_channels command
Date: Sun, 17 Jul 2022 16:54:20 +0200 [thread overview]
Message-ID: <YtQinGiQHiSg1oiC@lunn.ch> (raw)
In-Reply-To: <20220717022050.822766-1-andrey.turkin@gmail.com>
> +#if defined(CONFIG_PCI_MSI)
> + if (adapter->intr.type == VMXNET3_IT_MSIX) {
> + if (adapter->share_intr == VMXNET3_INTR_BUDDYSHARE) {
> + ec->combined_count = adapter->num_tx_queues;
> + ec->rx_count = 0;
> + ec->tx_count = 0;
> + } else {
> + ec->combined_count = 0;
> + ec->rx_count = adapter->num_rx_queues;
> + ec->tx_count =
> + adapter->share_intr == VMXNET3_INTR_TXSHARE ?
> + 1 : adapter->num_tx_queues;
> + }
> + } else {
> +#endif
> + ec->rx_count = 0;
> + ec->tx_count = 0;
> + ec->combined_count = 1;
> +#if defined(CONFIG_PCI_MSI)
> + }
> +#endif
This is pretty messy. Could you use IS_ENABLED(CONFIG_PCE_MSI)
instead?
Andrew
next prev parent reply other threads:[~2022-07-17 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-17 2:20 [PATCH] vmxnet3: Implement ethtool's get_channels command Andrey Turkin
2022-07-17 2:20 ` [PATCH] vmxnet3: Record queue number to incoming packets Andrey Turkin
2022-07-19 3:50 ` patchwork-bot+netdevbpf
2022-07-17 3:37 ` [PATCH] vmxnet3: Implement ethtool's get_channels command kernel test robot
2022-07-17 5:22 ` kernel test robot
2022-07-17 14:54 ` Andrew Lunn [this message]
2022-07-17 16:03 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtQinGiQHiSg1oiC@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrey.turkin@gmail.com \
--cc=doshir@vmware.com \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.