From: Leon Romanovsky <leon@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Roland Dreier <rolandd@cisco.com>,
Ralph Campbell <ralph.campbell@qlogic.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/qib: Use the bitmap API when applicable
Date: Sun, 17 Jul 2022 21:05:29 +0300 [thread overview]
Message-ID: <YtRPaSNV0UPn/nMk@unreal> (raw)
In-Reply-To: <33d8992586d382bec8b8efd83e4729fb7feaf89e.1656834106.git.christophe.jaillet@wanadoo.fr>
On Sun, Jul 03, 2022 at 09:42:48AM +0200, Christophe JAILLET wrote:
> Using the bitmap API is less verbose than hand writing them.
> It also improves the semantic.
>
> While at it, initialize the bitmaps. It can't hurt.
>
> Fixes: f931551bafe1 ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand adapters")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/infiniband/hw/qib/qib_iba7322.c | 23 ++++++++---------------
> 1 file changed, 8 insertions(+), 15 deletions(-)
>
I removed the Fixes line as there is no bug in changed code, just update
to use better in-kernel API.
Thanks, applied.
next prev parent reply other threads:[~2022-07-17 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-03 7:42 [PATCH] RDMA/qib: Use the bitmap API when applicable Christophe JAILLET
2022-07-17 18:05 ` Leon Romanovsky [this message]
2022-07-19 5:48 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtRPaSNV0UPn/nMk@unreal \
--to=leon@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=ralph.campbell@qlogic.com \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.