From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 479DBC43334 for ; Mon, 18 Jul 2022 10:54:19 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.369596.601038 (Exim 4.92) (envelope-from ) id 1oDOO2-0001sB-Dw; Mon, 18 Jul 2022 10:54:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369596.601038; Mon, 18 Jul 2022 10:54:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOO2-0001s4-9E; Mon, 18 Jul 2022 10:54:02 +0000 Received: by outflank-mailman (input) for mailman id 369596; Mon, 18 Jul 2022 10:54:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOO1-0001rt-PU for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:54:01 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id edfbcf0e-0687-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 12:54:00 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id BDD355C00B0; Mon, 18 Jul 2022 06:53:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 18 Jul 2022 06:53:59 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 06:53:58 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: edfbcf0e-0687-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658141639; x= 1658228039; bh=sQWR+ymapTCFmzQplP+QcaxkiCDXShRilBBu23MQdkk=; b=S Olmy5OsuyHvi2HHMEKNy9KCBc4damsN8BW0aF+QEHj/G1xmo6g0lpj2TVralJkND YOS+t9suUDm0L8n9zCU2aCQ+2I+K1YqUvIBv3iQZmXabqRutNSJWgp+rWUAjkFxc Nhi5ovxHBwE01DAJXiKYV/2Kqi2vitG0Vj8dwa9W9MraLCQBxp9/ePa/qLwrAdDf vYgt7Atve2d9XzfJ+xgYsnQTmwZjt+rNDHEHOWCyFnMmoJG6UuLHn512knwvtm3D ub8spSwIU1dfCukV3saCnCXto7drmCaxAk2MWEdvLcKduO2wZGE0CeoR5gxUtGl/ Im/XdHBLnUUGMPTLGZPJw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658141639; x=1658228039; bh=sQWR+ymapTCFmzQplP+QcaxkiCDX ShRilBBu23MQdkk=; b=FGxUW+lp+3HBB8u+Hz6vHndiuglkSW53AzAl1jehqGUx 5Q7ThY2IC+Lgoj8sG816f2aKaNN8ELOgOZiQMWn/Oq0yMOg/DGI4PRD2w/n7DH/q 9lC03SoEe9Eiu5U82DCk0K3/4S0loDYZPvAkAfM+1GQSe/0SH9bpYCufafv3Qfcl Mj9PYfeuO8QH3sgGWFaL4qlER4EiUhCTTdWfoJKG2vStvPpID1UpYgxBMpQiaCIx rsjjMgATB1zKqr8LnOFy7WztuKcfBG0+psxaLT0Bxfm1KRfNUHwl5uhlKhUgEjGU qdzEpgJ7wNgJeTL900Q04ezl0QaSemRMHhx0bSvzBQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekkedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 18 Jul 2022 12:53:55 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Paul Durrant , Roger Pau =?utf-8?B?TW9ubsOp?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 5/9] IOMMU: add common API for device reserved memory Message-ID: References: <2538c56f6881e4e2a3e5cee3cbdeebb88a59ccb5.1657121519.git-series.marmarek@invisiblethingslab.com> <38020a5e-121a-932e-691b-6eaf435be7d2@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="q3so7Phe/MZSuiIN" Content-Disposition: inline In-Reply-To: <38020a5e-121a-932e-691b-6eaf435be7d2@suse.com> --q3so7Phe/MZSuiIN Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 18 Jul 2022 12:53:55 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Paul Durrant , Roger Pau =?utf-8?B?TW9ubsOp?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 5/9] IOMMU: add common API for device reserved memory On Thu, Jul 14, 2022 at 12:17:53PM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-G=C3=B3recki wrote: > > --- a/xen/drivers/passthrough/iommu.c > > +++ b/xen/drivers/passthrough/iommu.c > > @@ -651,6 +651,46 @@ bool_t iommu_has_feature(struct domain *d, enum io= mmu_feature feature) > > return is_iommu_enabled(d) && test_bit(feature, dom_iommu(d)->feat= ures); > > } > > =20 > > +#define MAX_EXTRA_RESERVED_RANGES 20 > > +struct extra_reserved_range { > > + xen_pfn_t start; >=20 > Why not unsigned long? Isn't this the correct type for the page number? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --q3so7Phe/MZSuiIN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLVO8QACgkQ24/THMrX 1ywtYgf/XkJOy87gUCbJv6JUZD8O+3QMYQ83kXPLbSS0Ke7O17F6cwL62vDPHNgh rsNNUZJ1twrTinp8ri2aswsMTfibvxOKFySBEDqWtmdb5svthP+a1ktqWUW3ni65 Bha+zWDOPiQbfr7xAVISVk1R5bNclh1dm1bTD+4FXrVRGgt3697edWvD0gTqrSFg 8j6t1a3vIkKMJf9G7NwEtCIAWbP363TzabnJFM0q1q8tIU7OCXi+7j+g0xcXo7aw V3uGdUmbhPszIyCDo7x66WyBSpTBUWUyAieMOgIgB8Id9GBhhq7wTyVkNYXSg7Sp BYpNIVHUFpZCn1EoFuzFzYeheDgwfg== =qVrJ -----END PGP SIGNATURE----- --q3so7Phe/MZSuiIN--