From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A32C43334 for ; Mon, 18 Jul 2022 11:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234029AbiGRLcf (ORCPT ); Mon, 18 Jul 2022 07:32:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234034AbiGRLce (ORCPT ); Mon, 18 Jul 2022 07:32:34 -0400 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 370E21A802 for ; Mon, 18 Jul 2022 04:32:33 -0700 (PDT) Date: Mon, 18 Jul 2022 13:32:30 +0200 From: Pablo Neira Ayuso To: Phil Sutter , netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft] parser_bison: bail out on too long names Message-ID: References: <20220716080549.162980-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Sat, Jul 16, 2022 at 01:56:28PM +0200, Phil Sutter wrote: > Hi, > > On Sat, Jul 16, 2022 at 10:05:49AM +0200, Pablo Neira Ayuso wrote: > > If user specifies a too long object name, bail out. > > Shouldn't this be done in eval phase or so? As-is, this patch introduces > a standard syntax-specific limitation people may circumvent using JSON, > no? I can do it from eval phase. I will have to add more eval functions though, because eval is not always called from for every command.