From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99EA7C433EF for ; Mon, 18 Jul 2022 17:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XMsgjbSkZ2VYbgeVsP08cQ7dq5ONsygFhbPjf8y5qLE=; b=TxaQNnEH85d7yT rdxsNPX7KPwYEjVyoss0H35swneEonFfYx2/MNfQG3z+rdBUBj32adElj5rWd7e74QkDITKzh/A1E CUSujtJWJsCzQYfXnaSYTRhw7xJyWE9zDgKBLecqD0IHYpVEyudrCYo7idr+ogK/IAQH96xkgSTFf LOmnvzeqdjq8VoASYm0PnYI5R6rH5+s8W88NyQZIsxrsoDQ9V3/ChK43nYScSSDTvsr37/JNq3KlN rjPVLPuPcl153dj9HAf26oM56VjUDBxNEzz9z5WGPlSWFk186PEEh+d8sZ1FFaCuA+RD30P2wm1Du Y4WNgfNyciLGGMzdbWuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDUwN-00HM5W-O7; Mon, 18 Jul 2022 17:53:55 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDUwL-00HM3r-18 for linux-arm-kernel@lists.infradead.org; Mon, 18 Jul 2022 17:53:54 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F1C41B816E6; Mon, 18 Jul 2022 17:53:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7CC5C341CA; Mon, 18 Jul 2022 17:53:46 +0000 (UTC) Date: Mon, 18 Jul 2022 18:53:43 +0100 From: Catalin Marinas To: Herbert Xu Cc: Isaac Manjarres , Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" , Saravana Kannan , kernel-team@android.com Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220718_105353_253323_D4605D48 X-CRM114-Status: GOOD ( 18.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 16, 2022 at 11:25:35AM +0800, Herbert Xu wrote: > On Fri, Jul 15, 2022 at 03:23:25PM -0700, Isaac Manjarres wrote: > > isn't present. So, the current behavior that crypto is relying on > > wouldn't change, so I agree with Catalin that we wouldn't be lying to > > the compiler if we move forward with getting rid of kmalloc-192. > > There is no guarantee that crypto will always be allocating > structures > 128 bytes. > > But thanks for the reminder, I do need to push the patches along. So do I but holidays get in the way ;). I plan to refresh my kmalloc minalign series at the end of August. One significant change I have though is that now ARCH_KMALLOC_MINALIGN now goes down all the way to 8 and using swiotlb bounce buffering if the DMA mapping size is small. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01911C433EF for ; Mon, 18 Jul 2022 17:53:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 957326B0072; Mon, 18 Jul 2022 13:53:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 907596B0073; Mon, 18 Jul 2022 13:53:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F8C66B0074; Mon, 18 Jul 2022 13:53:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6FDF46B0072 for ; Mon, 18 Jul 2022 13:53:53 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4750234D2D for ; Mon, 18 Jul 2022 17:53:53 +0000 (UTC) X-FDA: 79700968746.12.DB5B393 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf24.hostedemail.com (Postfix) with ESMTP id C9A8A180087 for ; Mon, 18 Jul 2022 17:53:52 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F1C41B816E6; Mon, 18 Jul 2022 17:53:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7CC5C341CA; Mon, 18 Jul 2022 17:53:46 +0000 (UTC) Date: Mon, 18 Jul 2022 18:53:43 +0100 From: Catalin Marinas To: Herbert Xu Cc: Isaac Manjarres , Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" , Saravana Kannan , kernel-team@android.com Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658166833; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cpHBMw54SzMoVs52kZsAki3jjPfIE4TrjHjivVUOmCM=; b=s6flJXxYYRdOfQ5tm4pd6j5YKJRuSVtrcNni2Exr8qtyVF0zPtNI5QivKz70Whg8w2HU7R 6KYdWBzoYWS95wQPLaASiV48jnKx6A/DVhpci63ujuWGbxPfQoouk8by5jR+R0LkMO10Aa rVlVhxE7TDhPN2xcqEzBBt6mMr9kJTk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658166833; a=rsa-sha256; cv=none; b=LzGdw35geUX/MHRdDcZpmZGCKxLx/C6vivEoI27A+6uGzuJICf78FB+8lmvzI3yyL0yScf 5FXnNIZV4QAukbLMrP2kfYBwstLnEP6pslOKgF8tAaZKhtAmDQLrGaDn5G+Ofk8DC3wKfE ap+Bpi2odSlErzrV8alXPGjN4pw/uek= Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C9A8A180087 X-Stat-Signature: eohge66dk3goshz5imzyzitt3tjdmr1u X-Rspam-User: X-HE-Tag: 1658166832-986161 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 16, 2022 at 11:25:35AM +0800, Herbert Xu wrote: > On Fri, Jul 15, 2022 at 03:23:25PM -0700, Isaac Manjarres wrote: > > isn't present. So, the current behavior that crypto is relying on > > wouldn't change, so I agree with Catalin that we wouldn't be lying to > > the compiler if we move forward with getting rid of kmalloc-192. > > There is no guarantee that crypto will always be allocating > structures > 128 bytes. > > But thanks for the reminder, I do need to push the patches along. So do I but holidays get in the way ;). I plan to refresh my kmalloc minalign series at the end of August. One significant change I have though is that now ARCH_KMALLOC_MINALIGN now goes down all the way to 8 and using swiotlb bounce buffering if the DMA mapping size is small. -- Catalin