From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F34D3D9D for ; Mon, 18 Jul 2022 21:49:51 +0000 (UTC) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-10cf9f5b500so26348841fac.2 for ; Mon, 18 Jul 2022 14:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YRegPlGkAgnXCQS+56XrhwlChkX0WERwCF78v3+dEDE=; b=tx4wDsqJpNDyDy+RoCSOngclATfOSZSGSNqXermhdzAgWIJQzVv0Sma93TTt5PbTRY +e7j74ZUKxge80dMCD6hCLmAJ2hJBFc3zvXypaiavIDgrvxyXj1DjZQdv7wvxR1Wxoxk 4+rGISmGIRqAt8HpsKy75keqQh+uErIt/MgHLMjTRI2ItvOLvWYMS5l0MstP+DAKkbzD cnRaXQS6t2qZe6WYsf8Y+oGTp3+xwjJ1crHibSHTjBN6Y73d8RHByBcdPS0VB24OCp9h 0ndrMFGKb1W0GUoTKLkZNswK44qbXle4hLt5CkaXZ6tWaHq08rpmzz+QP9mgMrtl3oks nf8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YRegPlGkAgnXCQS+56XrhwlChkX0WERwCF78v3+dEDE=; b=WCRIs9rIgUQpqslc87NNvOK//fnquEXTLXlpxanDB2RDWlIBXIeqtqQmMOfajNfEMM hQ0g3bf8k1u1Gkn4aRI2yj6S5+SaQEKhoj7FQJ+Gju6aanCHoXK1mrLt1gcx7Rcew71N LdJHGCYbV4HogFkdM+5lRRwOa53CSlddSrXNCIGa2CZyVWH2WekORljsBjQYGbLjiDQr rL59Qx9xYUSBac/eWfGuxqt9UjhxEYmh1Z5i1OTZ0Hx9AvmD4Cu1R28JB7OLlC82QEsN Kam/vPmNxCX0qUEwrBr50PvlrlNhXAzlGmJYDMF2gjMlfuxDFJCKwAbEykkIwKGYUZN9 t+wQ== X-Gm-Message-State: AJIora96nS3SNU2XQN1WhzR6bDlSrWgYflPiO1h+UsRZOLT/3r5L4LBz Lg2oPjG25iWf1hB4ROUzYQFrfg== X-Google-Smtp-Source: AGRyM1vz+73Xt/EprCxr0glRx7mlW8o0gR7RQ50oLzXGipGpGPDEmsqZtjvD/fY5SFshUU/R35B23w== X-Received: by 2002:a05:6808:1691:b0:2f9:4bd7:581e with SMTP id bb17-20020a056808169100b002f94bd7581emr16545639oib.144.1658180990517; Mon, 18 Jul 2022 14:49:50 -0700 (PDT) Received: from eze-laptop ([190.190.187.68]) by smtp.gmail.com with ESMTPSA id c127-20020a4a0585000000b00431003ca076sm5472932ooc.44.2022.07.18.14.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 14:49:50 -0700 (PDT) Date: Mon, 18 Jul 2022 18:49:44 -0300 From: Ezequiel Garcia To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: mripard@kernel.org, paul.kocialkowski@bootlin.com, Nicolas Dufresne , mchehab@kernel.org, gregkh@linuxfoundation.org, wens@csie.org, samuel@sholland.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: cedrus: hevc: Add check for invalid timestamp Message-ID: References: <20220718165649.16407-1-jernej.skrabec@gmail.com> <4725382.GXAFRqVoOG@kista> <1795344.atdPhlSkOF@jernej-laptop> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1795344.atdPhlSkOF@jernej-laptop> Hi Jernej, On Mon, Jul 18, 2022 at 10:34:37PM +0200, Jernej Škrabec wrote: > Dne ponedeljek, 18. julij 2022 ob 21:37:31 CEST je Nicolas Dufresne > napisal(a): > > Le lundi 18 juillet 2022 à 19:57 +0200, Jernej Škrabec a écrit : > > > Dne ponedeljek, 18. julij 2022 ob 19:41:48 CEST je Nicolas Dufresne > > > > > > napisal(a): > > > > Le lundi 18 juillet 2022 à 18:56 +0200, Jernej Skrabec a écrit : > > > > > Not all DPB entries will be used most of the time. Unused entries will > > > > > thus have invalid timestamps. They will produce negative buffer index > > > > > which is not specifically handled. This works just by chance in > > > > > current > > > > > code. It will even produce bogus pointer, but since it's not used, it > > > > > won't do any harm. > > > > > > > > > > Let's fix that brittle design by skipping writing DPB entry altogether > > > > > if timestamp is invalid. > > > > > > > > > > Fixes: 86caab29da78 ("media: cedrus: Add HEVC/H.265 decoding support") > > > > > Signed-off-by: Jernej Skrabec > > > > > --- > > > > > > > > > > drivers/staging/media/sunxi/cedrus/cedrus_h265.c | 3 +++ > > > > > 1 file changed, 3 insertions(+) > > > > > > > > > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_h265.c > > > > > b/drivers/staging/media/sunxi/cedrus/cedrus_h265.c index > > > > > 1afc6797d806..687f87598f78 100644 > > > > > --- a/drivers/staging/media/sunxi/cedrus/cedrus_h265.c > > > > > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_h265.c > > > > > @@ -147,6 +147,9 @@ static void > > > > > cedrus_h265_frame_info_write_dpb(struct > > > > > cedrus_ctx *ctx,> > > > > > > > > > > dpb[i].pic_order_cnt_val > > > > > > > > > > }; > > > > > > > > > > + if (buffer_index < 0) > > > > > + continue; > > > > > > > > When I compare to other codecs, when the buffer_index does not exist, > > > > the > > > > addr 0 is being programmed into the HW. With this implementation is is > > > > left > > > > to whatever it was set for the previous decode operation. I think its is > > > > nicer done the other way. > > > > > > It's done the same way as it's done in vendor lib. As I stated in commit > > > message, actual values don't matter for unused entries. If it is used by > > > accident, HW reaction on all zero pointers can only be worse than using > > > old, but valid entry. > > > > > > Due to no real documentation and Allwinner unwillingness to share details, > > > we'll probably never know what's best response for each error. Some things > > > can be deduced from vendor code, but not all. > > > > > > I would rather not complicate this fix, especially since it's candidate > > > for > > > backporting. I think this makes sense, since it allows to fix the bug for the time being. Reviewed-by: Ezequiel Garcia Thanks! Ezequiel > > > > I am simply trying to highlight that this is not consistant with how the > > H264 part is done. Why do we reset the register for one codec and not the > > other ? > > While H264 and HEVC are similar in many ways, Cedrus uses two different cores > or in Cedrus slang, engines, for them. They have their own quirks. One of the > most apparent is handling of DPB array. H264 requires that same entry is > always at the same position in HW DPB. That's not required by HEVC. > > Additional reasons for differences come from the fact that it's from two > different authors (Maxime and Paul). Those differences were created at the > beginning and it is what it is. > > > > > Perhaps you should sync to your preference the driver as a whole. It also > > seems that before your patch, some bits would be 0 and some other would be > > very large values. Between this and leaving random value, I don't really > > see any gain or reason for a backport. It neither break or fix anything as > > far as I understand. > > Maybe there is no need to backport, but the change is nevertheless useful. As > I explained, current code works only by chance, as we noticed with Ezequiel's > rework. It's certainly worthwhile to make code less brittle. As far as I'm > concerned, fixes tag can be dropped or even Ezequiel can squash this change > into his commit, with appropriate adjustments, of course. > > I'm not completely sure what do you mean by syncing driver preference. Code > changes always need a good reason to be accepted. Moving code around and > renaming things just to be similar with something else is not. > > Best regards, > Jernej > > > > > My general opinion, is that we fixe the unused address (like to 0) then when > > something goes wrong, as least it will go wrong consistently. > > > > > Best regards, > > > Jernej > > > > > > > > + > > > > > > > > > > cedrus_h265_frame_info_write_single(ctx, i, > > > > > > dpb[i].field_pic, > > > > > > > > > pic_order_cnt, > > > > > > buffer_index); > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E103DC433EF for ; Mon, 18 Jul 2022 21:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zTb6RlBsrZCDZ9Yj1P4brJm9fh48Z385WQJZ3KoivfM=; b=WmlZi3wU1M1NnZ q/IGwmgnyK6mqa6oVbZezOiSMHyd7AnEgSety5DJb848xQ0Xk7YdHVsK89JLXFZMpD1auTQ1dcZW0 l9jTxTbsC2IrS8GfsYITo2snwyT1zk75p/UO9uihzLpAHvPW3oo13hNHuHEFp8M8B5VF8NGbP7y+t +nRytnusFYzmNfAgmYVU7+quNlLDj4lugtrh5xcY0cF2LWv/bLAd212BshGnUvpmQNGqdgGaPKRYM J8vmEYSm7xF1iKOGAZQxvjyLIN8BfqYkmMAPy1WboMcGBplEzAL78OwC3Y9ILR7vB9sQy959gU5wQ /mPKzeialcQch/hBa0Fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDYcn-001iIV-2M; Mon, 18 Jul 2022 21:49:57 +0000 Received: from mail-oa1-x32.google.com ([2001:4860:4864:20::32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDYck-001iHO-HY for linux-arm-kernel@lists.infradead.org; Mon, 18 Jul 2022 21:49:56 +0000 Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-10bec750eedso27481969fac.8 for ; Mon, 18 Jul 2022 14:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YRegPlGkAgnXCQS+56XrhwlChkX0WERwCF78v3+dEDE=; b=tx4wDsqJpNDyDy+RoCSOngclATfOSZSGSNqXermhdzAgWIJQzVv0Sma93TTt5PbTRY +e7j74ZUKxge80dMCD6hCLmAJ2hJBFc3zvXypaiavIDgrvxyXj1DjZQdv7wvxR1Wxoxk 4+rGISmGIRqAt8HpsKy75keqQh+uErIt/MgHLMjTRI2ItvOLvWYMS5l0MstP+DAKkbzD cnRaXQS6t2qZe6WYsf8Y+oGTp3+xwjJ1crHibSHTjBN6Y73d8RHByBcdPS0VB24OCp9h 0ndrMFGKb1W0GUoTKLkZNswK44qbXle4hLt5CkaXZ6tWaHq08rpmzz+QP9mgMrtl3oks nf8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YRegPlGkAgnXCQS+56XrhwlChkX0WERwCF78v3+dEDE=; b=c4wz+jK5ALA3Kic7fRIqdVEUa1js5A2WZlS3LFqHVLmASKrZ+G7jWa8JPO9smzHx/2 r2Dh/aevOcRk623K3lIYnij098bVI7cPe9fR581jZ7iiChKHCe3F6nhpgPmz5x1YcSP6 yyo6sKNIsbvLOS1Bw7ZKxrKFDAv6e4k9jYgcuZjQcnlNlnQEM3eNPDIN3kJVIjpCom8l YZAhHFMrHc6+savjJg+5fwJCTaF+V7DlMxR8xyYNh3ZPEZ+oZ2qdVbN4xJ93GbwHiOpt 5dSuDxsjgT20W+Sv63PIW1dRcZILo+0zN1QQBGUdEPAVKDJW4kdHcri5kKYjhPKe0K2+ 34cA== X-Gm-Message-State: AJIora+SOLosJDjvvGtiVLX+rKdtwd6M7vOv+XSuRJOb8KcIwt9a4I78 7tQXrr+EYUAOBpJLf2U2SWZ+YA== X-Google-Smtp-Source: AGRyM1vz+73Xt/EprCxr0glRx7mlW8o0gR7RQ50oLzXGipGpGPDEmsqZtjvD/fY5SFshUU/R35B23w== X-Received: by 2002:a05:6808:1691:b0:2f9:4bd7:581e with SMTP id bb17-20020a056808169100b002f94bd7581emr16545639oib.144.1658180990517; Mon, 18 Jul 2022 14:49:50 -0700 (PDT) Received: from eze-laptop ([190.190.187.68]) by smtp.gmail.com with ESMTPSA id c127-20020a4a0585000000b00431003ca076sm5472932ooc.44.2022.07.18.14.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 14:49:50 -0700 (PDT) Date: Mon, 18 Jul 2022 18:49:44 -0300 From: Ezequiel Garcia To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: mripard@kernel.org, paul.kocialkowski@bootlin.com, Nicolas Dufresne , mchehab@kernel.org, gregkh@linuxfoundation.org, wens@csie.org, samuel@sholland.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: cedrus: hevc: Add check for invalid timestamp Message-ID: References: <20220718165649.16407-1-jernej.skrabec@gmail.com> <4725382.GXAFRqVoOG@kista> <1795344.atdPhlSkOF@jernej-laptop> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1795344.atdPhlSkOF@jernej-laptop> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220718_144954_608293_7B8E8399 X-CRM114-Status: GOOD ( 48.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmVybmVqLAoKT24gTW9uLCBKdWwgMTgsIDIwMjIgYXQgMTA6MzQ6MzdQTSArMDIwMCwgSmVy bmVqIMWga3JhYmVjIHdyb3RlOgo+IERuZSBwb25lZGVsamVrLCAxOC4ganVsaWogMjAyMiBvYiAy MTozNzozMSBDRVNUIGplIE5pY29sYXMgRHVmcmVzbmUgCj4gbmFwaXNhbChhKToKPiA+IExlIGx1 bmRpIDE4IGp1aWxsZXQgMjAyMiDDoCAxOTo1NyArMDIwMCwgSmVybmVqIMWga3JhYmVjIGEgw6lj cml0IDoKPiA+ID4gRG5lIHBvbmVkZWxqZWssIDE4LiBqdWxpaiAyMDIyIG9iIDE5OjQxOjQ4IENF U1QgamUgTmljb2xhcyBEdWZyZXNuZQo+ID4gPiAKPiA+ID4gbmFwaXNhbChhKToKPiA+ID4gPiBM ZSBsdW5kaSAxOCBqdWlsbGV0IDIwMjIgw6AgMTg6NTYgKzAyMDAsIEplcm5laiBTa3JhYmVjIGEg w6ljcml0IDoKPiA+ID4gPiA+IE5vdCBhbGwgRFBCIGVudHJpZXMgd2lsbCBiZSB1c2VkIG1vc3Qg b2YgdGhlIHRpbWUuIFVudXNlZCBlbnRyaWVzIHdpbGwKPiA+ID4gPiA+IHRodXMgaGF2ZSBpbnZh bGlkIHRpbWVzdGFtcHMuIFRoZXkgd2lsbCBwcm9kdWNlIG5lZ2F0aXZlIGJ1ZmZlciBpbmRleAo+ ID4gPiA+ID4gd2hpY2ggaXMgbm90IHNwZWNpZmljYWxseSBoYW5kbGVkLiBUaGlzIHdvcmtzIGp1 c3QgYnkgY2hhbmNlIGluCj4gPiA+ID4gPiBjdXJyZW50Cj4gPiA+ID4gPiBjb2RlLiBJdCB3aWxs IGV2ZW4gcHJvZHVjZSBib2d1cyBwb2ludGVyLCBidXQgc2luY2UgaXQncyBub3QgdXNlZCwgaXQK PiA+ID4gPiA+IHdvbid0IGRvIGFueSBoYXJtLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBMZXQncyBm aXggdGhhdCBicml0dGxlIGRlc2lnbiBieSBza2lwcGluZyB3cml0aW5nIERQQiBlbnRyeSBhbHRv Z2V0aGVyCj4gPiA+ID4gPiBpZiB0aW1lc3RhbXAgaXMgaW52YWxpZC4KPiA+ID4gPiA+IAo+ID4g PiA+ID4gRml4ZXM6IDg2Y2FhYjI5ZGE3OCAoIm1lZGlhOiBjZWRydXM6IEFkZCBIRVZDL0guMjY1 IGRlY29kaW5nIHN1cHBvcnQiKQo+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogSmVybmVqIFNrcmFi ZWMgPGplcm5lai5za3JhYmVjQGdtYWlsLmNvbT4KPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gCj4g PiA+ID4gPiAgZHJpdmVycy9zdGFnaW5nL21lZGlhL3N1bnhpL2NlZHJ1cy9jZWRydXNfaDI2NS5j IHwgMyArKysKPiA+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCj4gPiA+ ID4gPiAKPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3N0YWdpbmcvbWVkaWEvc3VueGkv Y2VkcnVzL2NlZHJ1c19oMjY1LmMKPiA+ID4gPiA+IGIvZHJpdmVycy9zdGFnaW5nL21lZGlhL3N1 bnhpL2NlZHJ1cy9jZWRydXNfaDI2NS5jIGluZGV4Cj4gPiA+ID4gPiAxYWZjNjc5N2Q4MDYuLjY4 N2Y4NzU5OGY3OCAxMDA2NDQKPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9z dW54aS9jZWRydXMvY2VkcnVzX2gyNjUuYwo+ID4gPiA+ID4gKysrIGIvZHJpdmVycy9zdGFnaW5n L21lZGlhL3N1bnhpL2NlZHJ1cy9jZWRydXNfaDI2NS5jCj4gPiA+ID4gPiBAQCAtMTQ3LDYgKzE0 Nyw5IEBAIHN0YXRpYyB2b2lkCj4gPiA+ID4gPiBjZWRydXNfaDI2NV9mcmFtZV9pbmZvX3dyaXRl X2RwYihzdHJ1Y3QKPiA+ID4gPiA+IGNlZHJ1c19jdHggKmN0eCw+Cj4gPiA+ID4gPiAKPiA+ID4g PiA+ICAJCQlkcGJbaV0ucGljX29yZGVyX2NudF92YWwKPiA+ID4gPiA+ICAJCQo+ID4gPiA+ID4g IAkJfTsKPiA+ID4gPiA+IAo+ID4gPiA+ID4gKwkJaWYgKGJ1ZmZlcl9pbmRleCA8IDApCj4gPiA+ ID4gPiArCQkJY29udGludWU7Cj4gPiA+ID4gCj4gPiA+ID4gV2hlbiBJIGNvbXBhcmUgdG8gb3Ro ZXIgY29kZWNzLCB3aGVuIHRoZSBidWZmZXJfaW5kZXggZG9lcyBub3QgZXhpc3QsCj4gPiA+ID4g dGhlCj4gPiA+ID4gYWRkciAwIGlzIGJlaW5nIHByb2dyYW1tZWQgaW50byB0aGUgSFcuIFdpdGgg dGhpcyBpbXBsZW1lbnRhdGlvbiBpcyBpcwo+ID4gPiA+IGxlZnQKPiA+ID4gPiB0byB3aGF0ZXZl ciBpdCB3YXMgc2V0IGZvciB0aGUgcHJldmlvdXMgZGVjb2RlIG9wZXJhdGlvbi4gSSB0aGluayBp dHMgaXMKPiA+ID4gPiBuaWNlciBkb25lIHRoZSBvdGhlciB3YXkuCj4gPiA+IAo+ID4gPiBJdCdz IGRvbmUgdGhlIHNhbWUgd2F5IGFzIGl0J3MgZG9uZSBpbiB2ZW5kb3IgbGliLiBBcyBJIHN0YXRl ZCBpbiBjb21taXQKPiA+ID4gbWVzc2FnZSwgYWN0dWFsIHZhbHVlcyBkb24ndCBtYXR0ZXIgZm9y IHVudXNlZCBlbnRyaWVzLiBJZiBpdCBpcyB1c2VkIGJ5Cj4gPiA+IGFjY2lkZW50LCBIVyByZWFj dGlvbiBvbiBhbGwgemVybyBwb2ludGVycyBjYW4gb25seSBiZSB3b3JzZSB0aGFuIHVzaW5nCj4g PiA+IG9sZCwgYnV0IHZhbGlkIGVudHJ5Lgo+ID4gPiAKPiA+ID4gRHVlIHRvIG5vIHJlYWwgZG9j dW1lbnRhdGlvbiBhbmQgQWxsd2lubmVyIHVud2lsbGluZ25lc3MgdG8gc2hhcmUgZGV0YWlscywK PiA+ID4gd2UnbGwgcHJvYmFibHkgbmV2ZXIga25vdyB3aGF0J3MgYmVzdCByZXNwb25zZSBmb3Ig ZWFjaCBlcnJvci4gU29tZSB0aGluZ3MKPiA+ID4gY2FuIGJlIGRlZHVjZWQgZnJvbSB2ZW5kb3Ig Y29kZSwgYnV0IG5vdCBhbGwuCj4gPiA+IAo+ID4gPiBJIHdvdWxkIHJhdGhlciBub3QgY29tcGxp Y2F0ZSB0aGlzIGZpeCwgZXNwZWNpYWxseSBzaW5jZSBpdCdzIGNhbmRpZGF0ZQo+ID4gPiBmb3IK PiA+ID4gYmFja3BvcnRpbmcuCgpJIHRoaW5rIHRoaXMgbWFrZXMgc2Vuc2UsIHNpbmNlIGl0IGFs bG93cyB0byBmaXggdGhlIGJ1ZyBmb3IgdGhlIHRpbWUKYmVpbmcuCgpSZXZpZXdlZC1ieTogRXpl cXVpZWwgR2FyY2lhIDxlemVxdWllbEB2YW5ndWFyZGlhc3VyLmNvbS5hcj4KClRoYW5rcyEKRXpl cXVpZWwKCj4gPiAKPiA+IEkgYW0gc2ltcGx5IHRyeWluZyB0byBoaWdobGlnaHQgdGhhdCB0aGlz IGlzIG5vdCBjb25zaXN0YW50IHdpdGggaG93IHRoZQo+ID4gSDI2NCBwYXJ0IGlzIGRvbmUuIFdo eSBkbyB3ZSByZXNldCB0aGUgcmVnaXN0ZXIgZm9yIG9uZSBjb2RlYyBhbmQgbm90IHRoZQo+ID4g b3RoZXIgPwo+IAo+IFdoaWxlIEgyNjQgYW5kIEhFVkMgYXJlIHNpbWlsYXIgaW4gbWFueSB3YXlz LCBDZWRydXMgdXNlcyB0d28gZGlmZmVyZW50IGNvcmVzIAo+IG9yIGluIENlZHJ1cyBzbGFuZywg ZW5naW5lcywgZm9yIHRoZW0uIFRoZXkgaGF2ZSB0aGVpciBvd24gcXVpcmtzLiBPbmUgb2YgdGhl IAo+IG1vc3QgYXBwYXJlbnQgaXMgaGFuZGxpbmcgb2YgRFBCIGFycmF5LiBIMjY0IHJlcXVpcmVz IHRoYXQgc2FtZSBlbnRyeSBpcyAKPiBhbHdheXMgYXQgdGhlIHNhbWUgcG9zaXRpb24gaW4gSFcg RFBCLiBUaGF0J3Mgbm90IHJlcXVpcmVkIGJ5IEhFVkMuCj4gCj4gQWRkaXRpb25hbCByZWFzb25z IGZvciBkaWZmZXJlbmNlcyBjb21lIGZyb20gdGhlIGZhY3QgdGhhdCBpdCdzIGZyb20gdHdvIAo+ IGRpZmZlcmVudCBhdXRob3JzIChNYXhpbWUgYW5kIFBhdWwpLiBUaG9zZSBkaWZmZXJlbmNlcyB3 ZXJlIGNyZWF0ZWQgYXQgdGhlIAo+IGJlZ2lubmluZyBhbmQgaXQgaXMgd2hhdCBpdCBpcy4KPiAK PiA+IAo+ID4gUGVyaGFwcyB5b3Ugc2hvdWxkIHN5bmMgdG8geW91ciBwcmVmZXJlbmNlIHRoZSBk cml2ZXIgYXMgYSB3aG9sZS4gSXQgYWxzbwo+ID4gc2VlbXMgdGhhdCBiZWZvcmUgeW91ciBwYXRj aCwgc29tZSBiaXRzIHdvdWxkIGJlIDAgYW5kIHNvbWUgb3RoZXIgd291bGQgYmUKPiA+IHZlcnkg bGFyZ2UgdmFsdWVzLiBCZXR3ZWVuIHRoaXMgYW5kIGxlYXZpbmcgcmFuZG9tIHZhbHVlLCBJIGRv bid0IHJlYWxseQo+ID4gc2VlIGFueSBnYWluIG9yIHJlYXNvbiBmb3IgYSBiYWNrcG9ydC4gSXQg bmVpdGhlciBicmVhayBvciBmaXggYW55dGhpbmcgYXMKPiA+IGZhciBhcyBJIHVuZGVyc3RhbmQu Cj4gCj4gTWF5YmUgdGhlcmUgaXMgbm8gbmVlZCB0byBiYWNrcG9ydCwgYnV0IHRoZSBjaGFuZ2Ug aXMgbmV2ZXJ0aGVsZXNzIHVzZWZ1bC4gQXMgCj4gSSBleHBsYWluZWQsIGN1cnJlbnQgY29kZSB3 b3JrcyBvbmx5IGJ5IGNoYW5jZSwgYXMgd2Ugbm90aWNlZCB3aXRoIEV6ZXF1aWVsJ3MgCj4gcmV3 b3JrLiBJdCdzIGNlcnRhaW5seSB3b3J0aHdoaWxlIHRvIG1ha2UgY29kZSBsZXNzIGJyaXR0bGUu IEFzIGZhciBhcyBJJ20gCj4gY29uY2VybmVkLCBmaXhlcyB0YWcgY2FuIGJlIGRyb3BwZWQgb3Ig ZXZlbiBFemVxdWllbCBjYW4gc3F1YXNoIHRoaXMgY2hhbmdlIAo+IGludG8gaGlzIGNvbW1pdCwg d2l0aCBhcHByb3ByaWF0ZSBhZGp1c3RtZW50cywgb2YgY291cnNlLgo+IAo+IEknbSBub3QgY29t cGxldGVseSBzdXJlIHdoYXQgZG8geW91IG1lYW4gYnkgc3luY2luZyBkcml2ZXIgcHJlZmVyZW5j ZS4gQ29kZSAKPiBjaGFuZ2VzIGFsd2F5cyBuZWVkIGEgZ29vZCByZWFzb24gdG8gYmUgYWNjZXB0 ZWQuIE1vdmluZyBjb2RlIGFyb3VuZCBhbmQgCj4gcmVuYW1pbmcgdGhpbmdzIGp1c3QgdG8gYmUg c2ltaWxhciB3aXRoIHNvbWV0aGluZyBlbHNlIGlzIG5vdC4KPiAKPiBCZXN0IHJlZ2FyZHMsCj4g SmVybmVqCj4gCj4gPiAKPiA+IE15IGdlbmVyYWwgb3BpbmlvbiwgaXMgdGhhdCB3ZSBmaXhlIHRo ZSB1bnVzZWQgYWRkcmVzcyAobGlrZSB0byAwKSB0aGVuIHdoZW4KPiA+IHNvbWV0aGluZyBnb2Vz IHdyb25nLCBhcyBsZWFzdCBpdCB3aWxsIGdvIHdyb25nIGNvbnNpc3RlbnRseS4KPiA+IAo+ID4g PiBCZXN0IHJlZ2FyZHMsCj4gPiA+IEplcm5lago+ID4gPiAKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ IAo+ID4gPiA+ID4gIAkJY2VkcnVzX2gyNjVfZnJhbWVfaW5mb193cml0ZV9zaW5nbGUoY3R4LCBp LAo+ID4gPiAKPiA+ID4gZHBiW2ldLmZpZWxkX3BpYywKPiA+ID4gCj4gPiA+IAo+ID4gPiBwaWNf b3JkZXJfY250LAo+ID4gPiAKPiA+ID4gYnVmZmVyX2luZGV4KTsKPiAKPiAKPiAKPiAKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK