From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12E76C433EF for ; Tue, 19 Jul 2022 14:24:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 839924CE2D; Tue, 19 Jul 2022 10:24:24 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fLLRh5nwd9Cx; Tue, 19 Jul 2022 10:24:23 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 659744CE51; Tue, 19 Jul 2022 10:24:23 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0F5AB4CE2F for ; Tue, 19 Jul 2022 10:24:22 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P8TtM+Be8jak for ; Tue, 19 Jul 2022 10:24:20 -0400 (EDT) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id C7B0C4CE2D for ; Tue, 19 Jul 2022 10:24:20 -0400 (EDT) Received: by mail-wr1-f44.google.com with SMTP id bu1so21827195wrb.9 for ; Tue, 19 Jul 2022 07:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WNzGE1u5XBqK6Mb53sKBN5FU4Tw9+8CwrSdfuz5XdPs=; b=bfJEy/cnbMf7Dd+3HUkkFGC74hUVFhvhiX6RtKyPK1wNJDjzvZWDt9+QS+wz40FrTN HztEGcPqJAgSYKG5Ud5mP6WUgE5Vsy1Ey8x4vwxGGzkErc+F/f4zZMXKV0W4AoLMIYlK rdK+I8odxO/LtKbwOdwbk6RtcEFXy0MMU564JRUEqezINa/PYfR4wFoBfsx6h291tdla 2u52mftckZzlk3NyzHKaePzs+dBYbx4O1KOBoQc6OldLHSFib9f4w0hUX9pjQsZ2PO21 3eHZvRyOltIeXzszeKsuuBmjOvDQD9I5sMAE3gYJJv6Epw3/x+G4XvUt9Ds5GsvWij9u 3y9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WNzGE1u5XBqK6Mb53sKBN5FU4Tw9+8CwrSdfuz5XdPs=; b=KuIPZ7Lu2ZN3fyAnx8dFHNKvgdNVyc3SyVqy/KXqnbWX/vLpDAsnhrAB0BVFu6W6xW Svy4bCWFvtJeVv+UhD/Fj2hPiPxfBAH2MHXtlpoYB5jR8ZfvAxwh0bT5s8X05rkK/4im DvS0bdwkJhYZaXKvx/dy0dsxReoW5VUSymKBCezZkMtpDMFDZ0VKL9gQteREiKitiS3j nk9fdAUxX1HjE/et8AU20lQppoA3GmBo2Z7gyddUVCs+Cn41jSy4NzUP9KQto/Ask+9k 5DyAEHuZ7loP9pnAX5nCmZDGVn8hHg9z8KsdXpj++p3upoEs2hv7ijmeL0IXwfllX5S0 IrnQ== X-Gm-Message-State: AJIora+pPZ3e2QjGrmmbH8NKQYw60KLgI3cnf3dvLpBJQJfSY/9nnO5z 5+stgB/HjVlQxUl/EV874YpywA== X-Google-Smtp-Source: AGRyM1u/zzb8ihXo42fNXAW1OoFznD0EcxAfeIq6ZlSo4Z+it7CYm8RtVz9+EnpyHMxpc1irG479Bw== X-Received: by 2002:a5d:6d8f:0:b0:21d:b7d0:a913 with SMTP id l15-20020a5d6d8f000000b0021db7d0a913mr26582401wrs.462.1658240659597; Tue, 19 Jul 2022 07:24:19 -0700 (PDT) Received: from google.com (109.36.187.35.bc.googleusercontent.com. [35.187.36.109]) by smtp.gmail.com with ESMTPSA id e9-20020a05600c4e4900b0039c811077d3sm19310285wmq.22.2022.07.19.07.24.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 07:24:19 -0700 (PDT) Date: Tue, 19 Jul 2022 15:24:15 +0100 From: Vincent Donnefort To: Will Deacon Subject: Re: [PATCH v2 00/24] KVM: arm64: Introduce pKVM shadow state at EL2 Message-ID: References: <20220630135747.26983-1-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220630135747.26983-1-will@kernel.org> Cc: Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, Oliver Upton , Andy Lutomirski , linux-arm-kernel@lists.infradead.org, Michael Roth , Catalin Marinas , Chao Peng , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thu, Jun 30, 2022 at 02:57:23PM +0100, Will Deacon wrote: > Hi everyone, > > This series has been extracted from the pKVM base support series (aka > "pKVM mega-patch") previously posted here: > > https://lore.kernel.org/kvmarm/20220519134204.5379-1-will@kernel.org/ > > Unlike that more comprehensive series, this one is fairly fundamental > and does not introduce any new ABI commitments, leaving questions > involving the management of guest private memory and the creation of > protected VMs for future work. Instead, this series extends the pKVM EL2 > code so that it can dynamically instantiate and manage VM shadow > structures without the host being able to access them directly. These > shadow structures consist of a shadow VM, a set of shadow vCPUs and the > stage-2 page-table and the pages used to hold them are returned to the > host when the VM is destroyed. > > The last patch is marked as RFC because, although it plumbs in the > shadow state, it is woefully inefficient and copies to/from the host > state on every vCPU run. Without the last patch, the new structures are > unused but we move considerably closer to isolating guests from the > host. > > The series is based on Marc's rework of the flags > (kvm-arm64/burn-the-flags). > > Feedback welcome. > > Cheers, Only had few nitpicks Reviewed-by: Vincent Donnefort Also, I've been using this patchset for quite a while now. Tested-by: Vincent Donnefort [...] _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6404FC433EF for ; Tue, 19 Jul 2022 14:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=17BIEQaCD0JSoE28RVOkoxZz083Qfh7NPzpPJiS2Vco=; b=0xohH6LmlpF4zq NJ8E/OBaqTWJbQyd78sQi4qPThWtF6PvlSRBF57sj07B5L/HBbQA01/jJWtgy86/MbTLFOeWO9ddZ iEqHfH6eno/VkeV01fP1gMycoX28aX/e4TjGt52WMlO+lgXWl+AbS/dMkYxQulBjcy5cUXKq+dFFL A1pitIEfcbXZq57Texlk6i1Z5aOhH2upjwHKjMr98JXE6OuZRNwbrS1L5oOCKelqJn3g9Vbn3Ohfv JMBlroAxWWTM0ueZ48/9SxvkFdTz5zj3NA4L6hn5wjTMRNiBH6jeaG5jzRK42SssHy+epgTr2PpA8 XRzyKnkqIpK1CZ4vlDjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDo9B-009daC-Tw; Tue, 19 Jul 2022 14:24:26 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDo99-009dY1-IK for linux-arm-kernel@lists.infradead.org; Tue, 19 Jul 2022 14:24:25 +0000 Received: by mail-wr1-x432.google.com with SMTP id d8so1936818wrp.6 for ; Tue, 19 Jul 2022 07:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WNzGE1u5XBqK6Mb53sKBN5FU4Tw9+8CwrSdfuz5XdPs=; b=bfJEy/cnbMf7Dd+3HUkkFGC74hUVFhvhiX6RtKyPK1wNJDjzvZWDt9+QS+wz40FrTN HztEGcPqJAgSYKG5Ud5mP6WUgE5Vsy1Ey8x4vwxGGzkErc+F/f4zZMXKV0W4AoLMIYlK rdK+I8odxO/LtKbwOdwbk6RtcEFXy0MMU564JRUEqezINa/PYfR4wFoBfsx6h291tdla 2u52mftckZzlk3NyzHKaePzs+dBYbx4O1KOBoQc6OldLHSFib9f4w0hUX9pjQsZ2PO21 3eHZvRyOltIeXzszeKsuuBmjOvDQD9I5sMAE3gYJJv6Epw3/x+G4XvUt9Ds5GsvWij9u 3y9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WNzGE1u5XBqK6Mb53sKBN5FU4Tw9+8CwrSdfuz5XdPs=; b=yyzey5sp2GphTrWZ15j3JEAJN9ZlKMGnMqPUoMc6ecLGCYEcEcef40rgZ1BUPUv2aq tqIs5BO8FwAXbgovmBweU9uSUFN8hgc9xqzyOOo5g5RWJ72YvoaJBU7yJrj7Nu2yRatH K+fhxg7rlPdsc+ha087ngRaWMa9ltAPVgYU833s3up/5W0PWe1NRrWYaqus2AMX+n8/k pnX816iXx2RMl6aoII7TzucRArdg1SoPx5M8TudVQ1gk46SSNvqPyUHYxa8qRBDojw9M ePEB82XNeuPAQpWzpEhEAbLhVRXFyzQSDBkH97CYA0m2oL9jGKaO+l58a9zdfqPYk3Ml rtSQ== X-Gm-Message-State: AJIora/8tMbYdc/e+1erLoX9iGdxhO9n9IXmGVXAtI6SiUx4EQWzCQLK eLGg3Vn2k3LtZsi9YaaLLHERQg== X-Google-Smtp-Source: AGRyM1u/zzb8ihXo42fNXAW1OoFznD0EcxAfeIq6ZlSo4Z+it7CYm8RtVz9+EnpyHMxpc1irG479Bw== X-Received: by 2002:a5d:6d8f:0:b0:21d:b7d0:a913 with SMTP id l15-20020a5d6d8f000000b0021db7d0a913mr26582401wrs.462.1658240659597; Tue, 19 Jul 2022 07:24:19 -0700 (PDT) Received: from google.com (109.36.187.35.bc.googleusercontent.com. [35.187.36.109]) by smtp.gmail.com with ESMTPSA id e9-20020a05600c4e4900b0039c811077d3sm19310285wmq.22.2022.07.19.07.24.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 07:24:19 -0700 (PDT) Date: Tue, 19 Jul 2022 15:24:15 +0100 From: Vincent Donnefort To: Will Deacon Cc: kvmarm@lists.cs.columbia.edu, Ard Biesheuvel , Sean Christopherson , Alexandru Elisei , Andy Lutomirski , Catalin Marinas , James Morse , Chao Peng , Quentin Perret , Suzuki K Poulose , Michael Roth , Mark Rutland , Fuad Tabba , Oliver Upton , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 00/24] KVM: arm64: Introduce pKVM shadow state at EL2 Message-ID: References: <20220630135747.26983-1-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220630135747.26983-1-will@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_072423_632444_BFB25698 X-CRM114-Status: GOOD ( 20.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 30, 2022 at 02:57:23PM +0100, Will Deacon wrote: > Hi everyone, > > This series has been extracted from the pKVM base support series (aka > "pKVM mega-patch") previously posted here: > > https://lore.kernel.org/kvmarm/20220519134204.5379-1-will@kernel.org/ > > Unlike that more comprehensive series, this one is fairly fundamental > and does not introduce any new ABI commitments, leaving questions > involving the management of guest private memory and the creation of > protected VMs for future work. Instead, this series extends the pKVM EL2 > code so that it can dynamically instantiate and manage VM shadow > structures without the host being able to access them directly. These > shadow structures consist of a shadow VM, a set of shadow vCPUs and the > stage-2 page-table and the pages used to hold them are returned to the > host when the VM is destroyed. > > The last patch is marked as RFC because, although it plumbs in the > shadow state, it is woefully inefficient and copies to/from the host > state on every vCPU run. Without the last patch, the new structures are > unused but we move considerably closer to isolating guests from the > host. > > The series is based on Marc's rework of the flags > (kvm-arm64/burn-the-flags). > > Feedback welcome. > > Cheers, Only had few nitpicks Reviewed-by: Vincent Donnefort Also, I've been using this patchset for quite a while now. Tested-by: Vincent Donnefort [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123EFCCA483 for ; Tue, 19 Jul 2022 14:34:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239216AbiGSOeH (ORCPT ); Tue, 19 Jul 2022 10:34:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236043AbiGSOdw (ORCPT ); Tue, 19 Jul 2022 10:33:52 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2179E6175 for ; Tue, 19 Jul 2022 07:24:21 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id r14so21888786wrg.1 for ; Tue, 19 Jul 2022 07:24:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WNzGE1u5XBqK6Mb53sKBN5FU4Tw9+8CwrSdfuz5XdPs=; b=bfJEy/cnbMf7Dd+3HUkkFGC74hUVFhvhiX6RtKyPK1wNJDjzvZWDt9+QS+wz40FrTN HztEGcPqJAgSYKG5Ud5mP6WUgE5Vsy1Ey8x4vwxGGzkErc+F/f4zZMXKV0W4AoLMIYlK rdK+I8odxO/LtKbwOdwbk6RtcEFXy0MMU564JRUEqezINa/PYfR4wFoBfsx6h291tdla 2u52mftckZzlk3NyzHKaePzs+dBYbx4O1KOBoQc6OldLHSFib9f4w0hUX9pjQsZ2PO21 3eHZvRyOltIeXzszeKsuuBmjOvDQD9I5sMAE3gYJJv6Epw3/x+G4XvUt9Ds5GsvWij9u 3y9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WNzGE1u5XBqK6Mb53sKBN5FU4Tw9+8CwrSdfuz5XdPs=; b=7UmOT9yqaVj+/80QJMTNhcd1RGYwldhFoEVkGxrdzcRIsFNotC1A5++e6HEaORJiEj 5RK9IDnPtZfUSM9Fsowc9hoJDkU6GkZZbIS7zMFahLk9UUxG7UI1iXuTG4T5h3wNUkHc HgnG9PGDP4kx923+NLh38r8evsOcQI8LvGRqkLwjrd0LNhBz6fYbNOcUGoX47i8gmjD2 4qnRmKFqNb9ZfJXH9oUbQOqao/+luOFHKaaVh29MGMIq/VGFCwlgeBAZhAVpmJ4qR2UQ h9+/WMroEA7hcaFpUcusWhiayeXHPkU+0UvdzrdfoF0i2sXit74juNYDUqswS080T6wT nN5w== X-Gm-Message-State: AJIora/STk3VXLO/IFo3/WYi9CG1UXgbAShUwLbglN8kEPNb4dzjcWuQ wN6Kw2PUYVjJy4i1/ydxqDgybA== X-Google-Smtp-Source: AGRyM1u/zzb8ihXo42fNXAW1OoFznD0EcxAfeIq6ZlSo4Z+it7CYm8RtVz9+EnpyHMxpc1irG479Bw== X-Received: by 2002:a5d:6d8f:0:b0:21d:b7d0:a913 with SMTP id l15-20020a5d6d8f000000b0021db7d0a913mr26582401wrs.462.1658240659597; Tue, 19 Jul 2022 07:24:19 -0700 (PDT) Received: from google.com (109.36.187.35.bc.googleusercontent.com. [35.187.36.109]) by smtp.gmail.com with ESMTPSA id e9-20020a05600c4e4900b0039c811077d3sm19310285wmq.22.2022.07.19.07.24.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 07:24:19 -0700 (PDT) Date: Tue, 19 Jul 2022 15:24:15 +0100 From: Vincent Donnefort To: Will Deacon Cc: kvmarm@lists.cs.columbia.edu, Ard Biesheuvel , Sean Christopherson , Alexandru Elisei , Andy Lutomirski , Catalin Marinas , James Morse , Chao Peng , Quentin Perret , Suzuki K Poulose , Michael Roth , Mark Rutland , Fuad Tabba , Oliver Upton , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 00/24] KVM: arm64: Introduce pKVM shadow state at EL2 Message-ID: References: <20220630135747.26983-1-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220630135747.26983-1-will@kernel.org> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Jun 30, 2022 at 02:57:23PM +0100, Will Deacon wrote: > Hi everyone, > > This series has been extracted from the pKVM base support series (aka > "pKVM mega-patch") previously posted here: > > https://lore.kernel.org/kvmarm/20220519134204.5379-1-will@kernel.org/ > > Unlike that more comprehensive series, this one is fairly fundamental > and does not introduce any new ABI commitments, leaving questions > involving the management of guest private memory and the creation of > protected VMs for future work. Instead, this series extends the pKVM EL2 > code so that it can dynamically instantiate and manage VM shadow > structures without the host being able to access them directly. These > shadow structures consist of a shadow VM, a set of shadow vCPUs and the > stage-2 page-table and the pages used to hold them are returned to the > host when the VM is destroyed. > > The last patch is marked as RFC because, although it plumbs in the > shadow state, it is woefully inefficient and copies to/from the host > state on every vCPU run. Without the last patch, the new structures are > unused but we move considerably closer to isolating guests from the > host. > > The series is based on Marc's rework of the flags > (kvm-arm64/burn-the-flags). > > Feedback welcome. > > Cheers, Only had few nitpicks Reviewed-by: Vincent Donnefort Also, I've been using this patchset for quite a while now. Tested-by: Vincent Donnefort [...]