From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Leonardo Bras <leobras@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v4 0/3] Zero copy improvements (QIOChannel + multifd)
Date: Tue, 19 Jul 2022 15:10:14 +0100 [thread overview]
Message-ID: <Yta7RoAS9bV20mdg@work-vm> (raw)
In-Reply-To: <20220711211112.18951-1-leobras@redhat.com>
* Leonardo Bras (leobras@redhat.com) wrote:
> The first patch avoid spuriously returning 1 [*] when zero-copy flush is
> attempted before any buffer was sent using MSG_ZEROCOPY.
>
> [*] zero-copy not being used, even though it's enabled and supported
> by kernel
>
> The second patch introduces a new migration stat
> (dirty-sync-missed-zero-copy) that will be used to keep track of [*].
>
> The third patch keeps track of how many zero-copy flushes retured 1 [*]
>
> Changes since v3:
> - Patch#1: Also checks if no packet was queued after the last flush
> - Patch#2: Improve dirty-sync-missed-zero-copy doc and hmp print message
>
> Changes since v2:
> - Documentation release number changed from 7.2 to 7.1
> - migration stat renamed from zero-copy-copied to
> dirty-sync-missed-zero-copy
> - Updated documentation to make it more user-friendly
>
> Changes since v1:
> - Idea of using a warning replaced by using a migration stat counter
Queued
>
>
>
> Leonardo Bras (3):
> QIOChannelSocket: Fix zero-copy flush returning code 1 when nothing
> sent
> Add dirty-sync-missed-zero-copy migration stat
> migration/multifd: Report to user when zerocopy not working
>
> qapi/migration.json | 7 ++++++-
> migration/ram.h | 2 ++
> io/channel-socket.c | 8 +++++++-
> migration/migration.c | 2 ++
> migration/multifd.c | 2 ++
> migration/ram.c | 5 +++++
> monitor/hmp-cmds.c | 5 +++++
> 7 files changed, 29 insertions(+), 2 deletions(-)
>
> --
> 2.37.0
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2022-07-19 14:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 21:11 [PATCH v4 0/3] Zero copy improvements (QIOChannel + multifd) Leonardo Bras
2022-07-11 21:11 ` [PATCH v4 1/3] QIOChannelSocket: Fix zero-copy flush returning code 1 when nothing sent Leonardo Bras
2022-07-12 22:38 ` Peter Xu
2022-07-11 21:11 ` [PATCH v4 2/3] Add dirty-sync-missed-zero-copy migration stat Leonardo Bras
2022-07-12 22:42 ` Peter Xu
2022-07-11 21:11 ` [PATCH v4 3/3] migration/multifd: Report to user when zerocopy not working Leonardo Bras
2022-07-12 22:42 ` Peter Xu
2022-07-13 0:33 ` Leonardo Bras Soares Passos
2022-07-19 14:10 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yta7RoAS9bV20mdg@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.