All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] readahead01.c: turn comment into docparse and reword
Date: Tue, 19 Jul 2022 13:32:27 +0200	[thread overview]
Message-ID: <YtaWS2mPXf/Xzhlb@rei> (raw)
In-Reply-To: <20220719073911.21651-1-akumar@suse.de>

Hi!
Pushed with fixes, thanks.

> diff --git a/testcases/kernel/syscalls/readahead/readahead01.c b/testcases/kernel/syscalls/readahead/readahead01.c
> index 4355457e9..ac762aa3e 100644
> --- a/testcases/kernel/syscalls/readahead/readahead01.c
> +++ b/testcases/kernel/syscalls/readahead/readahead01.c
> @@ -3,8 +3,13 @@
>   * Copyright (C) 2012 Linux Test Project, Inc.
>   */
>  
> -/*
> - * errno tests for readahead() syscall
> +/*\
> + * [Description]
> + *
> + * Verify that readahead() syscall fails with
> + * - EBADF when fd is not a valid file descriptor or is not open for reading.
> + * - EINVAL when fd does not refer to a file type to which readahead()
> + * can be applied.

This does not render as a list unless there is empty line between the
"Verify that..." and the rest.

I've also added colon (:) after the "... with" as we usually do.

Please always check the resulting html pages to check if the end result
is rendered properly.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2022-07-19 11:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19  7:39 [LTP] [PATCH] readahead01.c: turn comment into docparse and reword Avinesh Kumar
2022-07-19 11:32 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtaWS2mPXf/Xzhlb@rei \
    --to=chrubis@suse.cz \
    --cc=akumar@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.