From: Keir Fraser <keirf@google.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
kernel-team@android.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio: Force DMA restricted devices through DMA API
Date: Tue, 19 Jul 2022 15:46:08 +0000 [thread overview]
Message-ID: <YtbRwO40CmIRWOUR@google.com> (raw)
In-Reply-To: <YtbMcBw4l0LAFn9+@infradead.org>
On Tue, Jul 19, 2022 at 08:23:28AM -0700, Christoph Hellwig wrote:
> On Tue, Jul 19, 2022 at 10:02:56AM +0000, Keir Fraser wrote:
> > +#include <linux/swiotlb.h>
>
> Drivers must never use this header. We have a few pre-existing abuses
> in the drm code, but they will go away.
>
Ok fair enough, and I'll admit I don't like my use of
swiotlb_for_alloc() a lot either.
However, if the general idea at least is acceptable, would the
implementation be acceptable if I add an explicit API for this to the
DMA subsystem, and hide the detail there?
Or a completely different approach would be to revert the patch
e41b1355508d which clears VIRTIO_F_ACCESS_PLATFORM in the balloon
driver. MST: That's back in your court, as it's your patch!
next prev parent reply other threads:[~2022-07-19 15:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 10:02 [PATCH] virtio: Force DMA restricted devices through DMA API Keir Fraser
2022-07-19 11:56 ` Michael S. Tsirkin
2022-07-19 11:56 ` Michael S. Tsirkin
2022-07-19 14:05 ` Keir Fraser
2022-07-19 21:31 ` Michael S. Tsirkin
2022-07-19 21:31 ` Michael S. Tsirkin
2022-07-19 15:23 ` Christoph Hellwig
2022-07-19 15:23 ` Christoph Hellwig
2022-07-19 15:46 ` Keir Fraser [this message]
2022-07-19 15:51 ` Christoph Hellwig
2022-07-19 15:51 ` Christoph Hellwig
2022-07-19 16:11 ` Keir Fraser
2022-07-20 5:16 ` Christoph Hellwig
2022-07-20 5:16 ` Christoph Hellwig
2022-07-20 6:59 ` Michael S. Tsirkin
2022-07-20 6:59 ` Michael S. Tsirkin
2022-07-20 8:27 ` Keir Fraser
2022-07-20 9:58 ` Michael S. Tsirkin
2022-07-20 9:58 ` Michael S. Tsirkin
2022-07-21 7:37 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtbRwO40CmIRWOUR@google.com \
--to=keirf@google.com \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.