From: Al Viro <viro@zeniv.linux.org.uk>
To: Helge Deller <deller@gmx.de>
Cc: Hillf Danton <hdanton@sina.com>,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org
Subject: Re: WARNING: CPU: 1 PID: 14735 at fs/dcache.c:365 dentry_free+0x100/0x128
Date: Wed, 20 Jul 2022 03:22:30 +0100 [thread overview]
Message-ID: <Ytdm5gk0zvU0pBaG@ZenIV> (raw)
In-Reply-To: <0aa365ca-a9f0-8d15-b515-adb8823f5d28@gmx.de>
On Tue, Jul 19, 2022 at 06:32:04PM +0200, Helge Deller wrote:
> > --- a/fs/dcache.c
> > +++ b/fs/dcache.c
> > @@ -605,8 +605,12 @@ static void __dentry_kill(struct dentry
> > spin_unlock(&parent->d_lock);
> > if (dentry->d_inode)
> > dentry_unlink_inode(dentry);
> > - else
> > + else {
> > + if (unlikely(d_in_lookup(dentry))) {
> > + __d_lookup_done(dentry);
> > + }
> > spin_unlock(&dentry->d_lock);
> > + }
Ugh... If that triggers, we really have a problem. I don't see any
way for that to happen (well, short of generally fucked refcounting -
stray dput() on wrong address and all bets are off)
next prev parent reply other threads:[~2022-07-20 2:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220709090756.2384-1-hdanton@sina.com>
2022-07-15 8:18 ` WARNING: CPU: 1 PID: 14735 at fs/dcache.c:365 dentry_free+0x100/0x128 Helge Deller
[not found] ` <20220715133300.1297-1-hdanton@sina.com>
2022-07-16 5:27 ` Helge Deller
2022-07-17 9:42 ` Helge Deller
[not found] ` <20220717113634.1552-1-hdanton@sina.com>
2022-07-19 16:32 ` Helge Deller
2022-07-19 20:59 ` John David Anglin
2022-07-19 21:25 ` Helge Deller
2022-07-20 2:00 ` Al Viro
2022-07-20 2:22 ` Al Viro [this message]
2022-07-20 2:31 ` Al Viro
2022-07-20 2:33 ` Al Viro
2022-07-20 3:29 ` Al Viro
2022-07-20 6:53 ` Helge Deller
2022-07-20 7:07 ` Al Viro
2022-07-20 9:21 ` Helge Deller
[not found] ` <20220720110032.1787-1-hdanton@sina.com>
2022-07-20 17:06 ` Al Viro
2022-07-20 23:15 ` Sam James
2022-07-21 3:54 ` Helge Deller
2022-07-30 20:21 ` Helge Deller
2022-07-09 5:33 Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ytdm5gk0zvU0pBaG@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=deller@gmx.de \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.