From: Robert Richter <rric@kernel.org>
To: Liang He <windhl@126.com>
Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/2] mmc: cavium-octeon: Add of_node_put() when breaking out of loop
Date: Wed, 20 Jul 2022 13:35:20 +0200 [thread overview]
Message-ID: <YtfoePMI7EEVd31S@rric.localdomain> (raw)
In-Reply-To: <20220719095216.1241601-1-windhl@126.com>
On 19.07.22 17:52:15, Liang He wrote:
> In octeon_mmc_probe(), we should call of_node_put() when breaking
> out of for_each_child_of_node() which has increased and decreased
> the refcount during each iteration.
>
> Fixes: 01d95843335c ("mmc: cavium: Add MMC support for Octeon SOCs.")
> Signed-off-by: Liang He <windhl@126.com>
Acked-by: Robert Richter <rric@kernel.org>
> ---
> drivers/mmc/host/cavium-octeon.c | 1 +
> 1 file changed, 1 insertion(+)
next prev parent reply other threads:[~2022-07-20 11:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 9:52 [PATCH 1/2] mmc: cavium-octeon: Add of_node_put() when breaking out of loop Liang He
2022-07-19 9:52 ` [PATCH 2/2] mmc: cavium-thunderx: " Liang He
2022-07-20 11:35 ` Robert Richter
2022-07-21 16:13 ` Ulf Hansson
2022-07-20 11:35 ` Robert Richter [this message]
2022-07-21 16:13 ` [PATCH 1/2] mmc: cavium-octeon: " Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtfoePMI7EEVd31S@rric.localdomain \
--to=rric@kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.