From: Mark Brown <broonie@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Lukas Wunner <lukas@wunner.de>,
linux-spi@vger.kernel.org, kernel@pengutronix.de,
Stefan Wahren <stefan.wahren@i2se.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jens Lindahl <jensctl@gmail.com>
Subject: Re: [PATCH] spi: bcm2835: bcm2835_spi_handle_err(): fix NULL pointer deref for non DMA transfers
Date: Wed, 20 Jul 2022 12:48:28 +0100 [thread overview]
Message-ID: <YtfrjPoqeSPWDYgH@sirena.org.uk> (raw)
In-Reply-To: <20220719075515.x2usfgiolzx4xkt5@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
On Tue, Jul 19, 2022 at 09:55:15AM +0200, Marc Kleine-Budde wrote:
> The difference is (Jens Lindahl):
>
> + if (bs->tx_dma_active) {
> + dmaengine_terminate_sync(ctlr->dma_tx);
> + bs->tx_dma_active = false;
> + }
>
> vs. (me):
>
> + if (ctlr->dma_tx) {
> + dmaengine_terminate_sync(ctlr->dma_tx);
> + bs->tx_dma_active = false;
> + }
>
> Which one is preferred?
Probably checking dma_tx is a bit more robust, though it shouldn't
matter really.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-20 11:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 7:22 [PATCH] spi: bcm2835: bcm2835_spi_handle_err(): fix NULL pointer deref for non DMA transfers Marc Kleine-Budde
2022-07-19 7:47 ` Lukas Wunner
2022-07-19 7:55 ` Marc Kleine-Budde
2022-07-20 11:48 ` Mark Brown [this message]
2022-07-19 10:33 ` Mark Brown
2022-07-20 17:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtfrjPoqeSPWDYgH@sirena.org.uk \
--to=broonie@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jensctl@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-spi@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mkl@pengutronix.de \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.