All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: airlied@linux.ie, alison.wang@nxp.com, linux@armlinux.org.uk,
	linux-graphics-maintainer@vmware.com,
	dri-devel@lists.freedesktop.org, airlied@redhat.com
Subject: Re: [PATCH 0/7] drm: Clean up plane helpers
Date: Wed, 20 Jul 2022 17:08:13 +0200	[thread overview]
Message-ID: <YtgaXaN9cc/9Q98z@ravnborg.org> (raw)
In-Reply-To: <20220720083058.15371-1-tzimmermann@suse.de>

Hi Thomas,

On Wed, Jul 20, 2022 at 10:30:51AM +0200, Thomas Zimmermann wrote:
> The plane helpers are included by dozens of files without any need. Only
> a hand full of source files need anything from drm_plane_helper.h.
> 
> Untangle everything and tidy up the code a bit. The patches were built
> on x64-64, aarch64 and arm without issues.

Build tested the final result here on a few more archs without any issues.
I like the removal of the include statements and the simpler header
file.

I did not really get what is gained by pushing out drm_plane_funcs
to the drivers but trust this is in the end a better solution.

Series is:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

	Sam

  parent reply	other threads:[~2022-07-20 15:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20  8:30 [PATCH 0/7] drm: Clean up plane helpers Thomas Zimmermann
2022-07-20  8:30 ` [PATCH 1/7] drm/vmwgfx: Remove trailing whitespace Thomas Zimmermann
2022-07-20 13:23   ` Zack Rusin
2022-07-20  8:30 ` [PATCH 2/7] drm/atomic-helper: Move DRM_PLANE_HELPER_NO_SCALING to atomic helpers Thomas Zimmermann
2022-07-20  8:30 ` [PATCH 3/7] drm/atomic-helper: Remove _HELPER_ infix from DRM_PLANE_HELPER_NO_SCALING Thomas Zimmermann
2022-07-20  8:30 ` [PATCH 4/7] drm: Remove unnecessary include statements of drm_plane_helper.h Thomas Zimmermann
2022-07-20  8:30 ` [PATCH 5/7] drm/plane-helper: Export individual helpers Thomas Zimmermann
2022-08-11 16:41   ` Daniel Vetter
2022-08-11 18:32     ` Thomas Zimmermann
2022-09-06 19:15       ` Daniel Vetter
2022-09-07  7:09         ` Thomas Zimmermann
2022-07-20  8:30 ` [PATCH 6/7] drm/armada: Use drm_plane_helper_destroy() Thomas Zimmermann
2022-07-20  8:30 ` [PATCH 7/7] drm/fsl-dcu: " Thomas Zimmermann
2022-08-11 16:46   ` Daniel Vetter
2022-07-20 15:08 ` Sam Ravnborg [this message]
2022-07-21  6:52   ` [PATCH 0/7] drm: Clean up plane helpers Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtgaXaN9cc/9Q98z@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=alison.wang@nxp.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-graphics-maintainer@vmware.com \
    --cc=linux@armlinux.org.uk \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.