From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04D5DC433EF for ; Thu, 21 Jul 2022 12:34:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232164AbiGUMea (ORCPT ); Thu, 21 Jul 2022 08:34:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233645AbiGUMe3 (ORCPT ); Thu, 21 Jul 2022 08:34:29 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDDFC74E39 for ; Thu, 21 Jul 2022 05:34:27 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D98E496; Thu, 21 Jul 2022 14:34:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1658406865; bh=4u/Wl5mxuWl6k4D4roY6y5SIN2NN8QO64TNR6Sq5plw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vfw7Et/zkla/2ATtBzgqfBnnlCaex0XfbZjJ4o5nxj0tlsMtamhGc5pKQN1UT2gNX UAw7jQZRrBsV5TsBRi0wX4M4BIkamT0pv/k+u3gYk3z2T6Ea3JSR3K4WYJgOC8acVb DLV59PwlcMxGR0vNwpchrctr/SGHj1KAPSvkfQUI= Date: Thu, 21 Jul 2022 15:34:23 +0300 From: Laurent Pinchart To: Marek Vasut Cc: devicetree@vger.kernel.org, robert.foss@linaro.org, dri-devel@lists.freedesktop.org, Guido =?utf-8?Q?G=C3=BCnther?= , Jagan Teki , Linus Walleij , Rob Herring , Sam Ravnborg , Thierry Reding Subject: Re: [PATCH] dt-bindings: vendor-prefixes: add Densitron Message-ID: References: <20220721030327.210950-1-marex@denx.de> <0b4927f7-f1e4-60a8-1eaf-6d4cbc38daec@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0b4927f7-f1e4-60a8-1eaf-6d4cbc38daec@denx.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Marek, On Thu, Jul 21, 2022 at 02:24:57PM +0200, Marek Vasut wrote: > On 7/21/22 07:41, Laurent Pinchart wrote: > > On Thu, Jul 21, 2022 at 05:03:27AM +0200, Marek Vasut wrote: > >> Densitron is a manufacturer of LCD panels. > >> https://www.densitron.com > >> > >> Signed-off-by: Marek Vasut > >> Cc: Guido Günther > >> Cc: Jagan Teki > >> Cc: Laurent Pinchart > >> Cc: Linus Walleij > >> Cc: Rob Herring > >> Cc: Sam Ravnborg > >> Cc: Thierry Reding > >> --- > >> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > >> index 88859dd4040ee..6277240536b44 100644 > >> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > >> @@ -312,6 +312,8 @@ patternProperties: > >> description: Dell Inc. > >> "^delta,.*": > >> description: Delta Electronics, Inc. > >> + "^densitron,.*": > > > > How about "dsn", to follow the practice of using stock names as vendor > > prefixes ? > > Is there any benefit to that ? All I can see is that it's making DTS > less clear and more difficult to read. It is easy to map "densitron" to > "densitron" when it is spelled out like so in the DT, but it sure isn't > immediately obvious that "dsn" means "densitron" without extra look up. > And even that extra look up of "dsn" does not return densitron, but some > woodworking company and other totally unrelated results. I don't know where that practice originates from, and if it's still the recommended naming scheme these days. All I know is that it was the recommended scheme at some point. I expect Rob will be able to tell which name is best. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73CCBC43334 for ; Thu, 21 Jul 2022 12:34:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A5A90909C3; Thu, 21 Jul 2022 12:34:27 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 215BD909C3 for ; Thu, 21 Jul 2022 12:34:27 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D98E496; Thu, 21 Jul 2022 14:34:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1658406865; bh=4u/Wl5mxuWl6k4D4roY6y5SIN2NN8QO64TNR6Sq5plw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vfw7Et/zkla/2ATtBzgqfBnnlCaex0XfbZjJ4o5nxj0tlsMtamhGc5pKQN1UT2gNX UAw7jQZRrBsV5TsBRi0wX4M4BIkamT0pv/k+u3gYk3z2T6Ea3JSR3K4WYJgOC8acVb DLV59PwlcMxGR0vNwpchrctr/SGHj1KAPSvkfQUI= Date: Thu, 21 Jul 2022 15:34:23 +0300 From: Laurent Pinchart To: Marek Vasut Subject: Re: [PATCH] dt-bindings: vendor-prefixes: add Densitron Message-ID: References: <20220721030327.210950-1-marex@denx.de> <0b4927f7-f1e4-60a8-1eaf-6d4cbc38daec@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0b4927f7-f1e4-60a8-1eaf-6d4cbc38daec@denx.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Guido =?utf-8?Q?G=C3=BCnther?= , dri-devel@lists.freedesktop.org, Rob Herring , Thierry Reding , robert.foss@linaro.org, Sam Ravnborg , Jagan Teki Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Marek, On Thu, Jul 21, 2022 at 02:24:57PM +0200, Marek Vasut wrote: > On 7/21/22 07:41, Laurent Pinchart wrote: > > On Thu, Jul 21, 2022 at 05:03:27AM +0200, Marek Vasut wrote: > >> Densitron is a manufacturer of LCD panels. > >> https://www.densitron.com > >> > >> Signed-off-by: Marek Vasut > >> Cc: Guido Günther > >> Cc: Jagan Teki > >> Cc: Laurent Pinchart > >> Cc: Linus Walleij > >> Cc: Rob Herring > >> Cc: Sam Ravnborg > >> Cc: Thierry Reding > >> --- > >> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > >> index 88859dd4040ee..6277240536b44 100644 > >> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > >> @@ -312,6 +312,8 @@ patternProperties: > >> description: Dell Inc. > >> "^delta,.*": > >> description: Delta Electronics, Inc. > >> + "^densitron,.*": > > > > How about "dsn", to follow the practice of using stock names as vendor > > prefixes ? > > Is there any benefit to that ? All I can see is that it's making DTS > less clear and more difficult to read. It is easy to map "densitron" to > "densitron" when it is spelled out like so in the DT, but it sure isn't > immediately obvious that "dsn" means "densitron" without extra look up. > And even that extra look up of "dsn" does not return densitron, but some > woodworking company and other totally unrelated results. I don't know where that practice originates from, and if it's still the recommended naming scheme these days. All I know is that it was the recommended scheme at some point. I expect Rob will be able to tell which name is best. -- Regards, Laurent Pinchart