From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6BB2C43334 for ; Thu, 21 Jul 2022 15:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rNGWBdc3sBdu6QsFvb/PJWJhFmbtKZRfn00OUv/Yam8=; b=NikoPF8U2KX+mR FIXxPZlVmCAsE/gugj+nLn4gw4BEKkYP2co2s6LMR+/Wvtley5c+Eov1uNYn8A1JUljAJ2tMuMdTv uboAUAKlXR/wJTwk41ix2sxvhvO6WCv7CYbvKoXJGqIjWkFte16ShlEkqJHTaWmH+dGoC/HNSes7c tmquXoV5vNay9dF7DFpLxXkYcBy2MYMisWww2RPeQD0cUTke8QwwDQT4pbnTwNFufD3gWduvjkDZG NYE71Cg3aM8YQ8twYbCByO5hTuj3Ou7KHv0DgenCcczgYyM3XKNG0abmFigEiDNCixhiuLxgbCEKY +Lqf6IW+GTGuqfhdO/Zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEY0A-008zTK-Q8; Thu, 21 Jul 2022 15:22:10 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEY06-008zFQ-RF for linux-arm-kernel@lists.infradead.org; Thu, 21 Jul 2022 15:22:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1A653B8257B; Thu, 21 Jul 2022 15:22:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D208DC3411E; Thu, 21 Jul 2022 15:21:59 +0000 (UTC) Date: Thu, 21 Jul 2022 16:21:55 +0100 From: Catalin Marinas To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , Mark Rutland , pcc@google.com, Ard Biesheuvel , kernel-team@android.com Subject: Re: [PATCH] arm64: Use mov_q to load KPTI_NG_PTE_FLAGS/SWAPPER_R*_MMUFLAGS Message-ID: References: <20220721124244.903567-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220721124244.903567-1-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220721_082207_044481_C5124C1F X-CRM114-Status: GOOD ( 13.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 21, 2022 at 01:42:44PM +0100, Marc Zyngier wrote: > With f7b4c3b82e7d ("arm64: set UXN on swapper page tables"), > the kernel fails to build: > > arch/arm64/kernel/head.S: Assembler messages: > arch/arm64/kernel/head.S:334: Error: immediate cannot be moved by a single instruction > arch/arm64/kernel/head.S:343: Error: immediate cannot be moved by a single instruction > arch/arm64/kernel/head.S:354: Error: immediate cannot be moved by a single instruction > arch/arm64/kernel/head.S:379: Error: immediate cannot be moved by a single instruction > > as the constants that inherit SWAPPER_P*_FLAGS cannot be loaded > using a single 'mov' instruction. Move over to mov_q to fix this. > > Signed-off-by: Marc Zyngier Thanks for the fix Marc, this only applies to -next. We could either revert Peter's patch [1] in -next but keep it for 5.19 or simply drop it from for-next/fixes and send it to stable post 5.19. I'm more inclined to do the latter. Catalin [1] https://lore.kernel.org/r/20220719234909.1398992-1-pcc@google.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel