* [f2fs-dev] [PATCH] f2fs: modify task name prefix
@ 2022-07-18 8:10 ` Guowei Du
0 siblings, 0 replies; 6+ messages in thread
From: Guowei Du @ 2022-07-18 8:10 UTC (permalink / raw)
To: jaegeuk, chao; +Cc: linux-kernel, duguowei, linux-f2fs-devel
From: duguowei <duguowei@xiaomi.com>
If there are more than one f2fs sbi, there will be more
discard threads. But the comm is too long to show dev
minor. So, change the default prefix of thread from
"f2fs_discard" to "f2fs_dcd".
Before:
$ ps -e | grep f2fs
1628 ? 00:00:00 f2fs_ckpt-7:10
1629 ? 00:00:00 f2fs_flush-7:10
1630 ? 00:00:00 f2fs_discard-7:
1631 ? 00:00:00 f2fs_gc-7:10
2030 ? 00:00:00 f2fs_ckpt-7:27
2031 ? 00:00:00 f2fs_flush-7:27
2032 ? 00:00:00 f2fs_discard-7:
2033 ? 00:00:00 f2fs_gc-7:27
After:
$ ps -e | grep f2fs
1628 ? 00:00:00 f2fs_ckpt-7:10
1629 ? 00:00:00 f2fs_flush-7:10
1630 ? 00:00:00 f2fs_dcd-7:10
1631 ? 00:00:00 f2fs_gc-7:10
2030 ? 00:00:00 f2fs_ckpt-7:27
2031 ? 00:00:00 f2fs_flush-7:27
2032 ? 00:00:00 f2fs_dcd-7:27
2033 ? 00:00:00 f2fs_gc-7:27
Signed-off-by: duguowei <duguowei@xiaomi.com>
---
fs/f2fs/segment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 874c1b9c41a2..2eeefcbe62db 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -2018,7 +2018,7 @@ int f2fs_start_discard_thread(struct f2fs_sb_info *sbi)
return 0;
dcc->f2fs_issue_discard = kthread_run(issue_discard_thread, sbi,
- "f2fs_discard-%u:%u", MAJOR(dev), MINOR(dev));
+ "f2fs_dcd-%u:%u", MAJOR(dev), MINOR(dev));
if (IS_ERR(dcc->f2fs_issue_discard))
err = PTR_ERR(dcc->f2fs_issue_discard);
--
2.36.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] f2fs: modify task name prefix
@ 2022-07-18 8:10 ` Guowei Du
0 siblings, 0 replies; 6+ messages in thread
From: Guowei Du @ 2022-07-18 8:10 UTC (permalink / raw)
To: jaegeuk, chao; +Cc: linux-f2fs-devel, linux-kernel, duguowei
From: duguowei <duguowei@xiaomi.com>
If there are more than one f2fs sbi, there will be more
discard threads. But the comm is too long to show dev
minor. So, change the default prefix of thread from
"f2fs_discard" to "f2fs_dcd".
Before:
$ ps -e | grep f2fs
1628 ? 00:00:00 f2fs_ckpt-7:10
1629 ? 00:00:00 f2fs_flush-7:10
1630 ? 00:00:00 f2fs_discard-7:
1631 ? 00:00:00 f2fs_gc-7:10
2030 ? 00:00:00 f2fs_ckpt-7:27
2031 ? 00:00:00 f2fs_flush-7:27
2032 ? 00:00:00 f2fs_discard-7:
2033 ? 00:00:00 f2fs_gc-7:27
After:
$ ps -e | grep f2fs
1628 ? 00:00:00 f2fs_ckpt-7:10
1629 ? 00:00:00 f2fs_flush-7:10
1630 ? 00:00:00 f2fs_dcd-7:10
1631 ? 00:00:00 f2fs_gc-7:10
2030 ? 00:00:00 f2fs_ckpt-7:27
2031 ? 00:00:00 f2fs_flush-7:27
2032 ? 00:00:00 f2fs_dcd-7:27
2033 ? 00:00:00 f2fs_gc-7:27
Signed-off-by: duguowei <duguowei@xiaomi.com>
---
fs/f2fs/segment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 874c1b9c41a2..2eeefcbe62db 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -2018,7 +2018,7 @@ int f2fs_start_discard_thread(struct f2fs_sb_info *sbi)
return 0;
dcc->f2fs_issue_discard = kthread_run(issue_discard_thread, sbi,
- "f2fs_discard-%u:%u", MAJOR(dev), MINOR(dev));
+ "f2fs_dcd-%u:%u", MAJOR(dev), MINOR(dev));
if (IS_ERR(dcc->f2fs_issue_discard))
err = PTR_ERR(dcc->f2fs_issue_discard);
--
2.36.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: modify task name prefix
2022-07-18 8:10 ` Guowei Du
@ 2022-07-22 2:43 ` Jaegeuk Kim
-1 siblings, 0 replies; 6+ messages in thread
From: Jaegeuk Kim @ 2022-07-22 2:43 UTC (permalink / raw)
To: Guowei Du; +Cc: linux-kernel, duguowei, linux-f2fs-devel
On 07/18, Guowei Du wrote:
> From: duguowei <duguowei@xiaomi.com>
>
> If there are more than one f2fs sbi, there will be more
> discard threads. But the comm is too long to show dev
> minor. So, change the default prefix of thread from
> "f2fs_discard" to "f2fs_dcd".
That looks quite unreadable. What about unmap?
>
> Before:
> $ ps -e | grep f2fs
> 1628 ? 00:00:00 f2fs_ckpt-7:10
> 1629 ? 00:00:00 f2fs_flush-7:10
> 1630 ? 00:00:00 f2fs_discard-7:
> 1631 ? 00:00:00 f2fs_gc-7:10
> 2030 ? 00:00:00 f2fs_ckpt-7:27
> 2031 ? 00:00:00 f2fs_flush-7:27
> 2032 ? 00:00:00 f2fs_discard-7:
> 2033 ? 00:00:00 f2fs_gc-7:27
>
> After:
> $ ps -e | grep f2fs
> 1628 ? 00:00:00 f2fs_ckpt-7:10
> 1629 ? 00:00:00 f2fs_flush-7:10
> 1630 ? 00:00:00 f2fs_dcd-7:10
> 1631 ? 00:00:00 f2fs_gc-7:10
> 2030 ? 00:00:00 f2fs_ckpt-7:27
> 2031 ? 00:00:00 f2fs_flush-7:27
> 2032 ? 00:00:00 f2fs_dcd-7:27
> 2033 ? 00:00:00 f2fs_gc-7:27
>
> Signed-off-by: duguowei <duguowei@xiaomi.com>
> ---
> fs/f2fs/segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 874c1b9c41a2..2eeefcbe62db 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -2018,7 +2018,7 @@ int f2fs_start_discard_thread(struct f2fs_sb_info *sbi)
> return 0;
>
> dcc->f2fs_issue_discard = kthread_run(issue_discard_thread, sbi,
> - "f2fs_discard-%u:%u", MAJOR(dev), MINOR(dev));
> + "f2fs_dcd-%u:%u", MAJOR(dev), MINOR(dev));
> if (IS_ERR(dcc->f2fs_issue_discard))
> err = PTR_ERR(dcc->f2fs_issue_discard);
>
> --
> 2.36.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] f2fs: modify task name prefix
@ 2022-07-22 2:43 ` Jaegeuk Kim
0 siblings, 0 replies; 6+ messages in thread
From: Jaegeuk Kim @ 2022-07-22 2:43 UTC (permalink / raw)
To: Guowei Du; +Cc: chao, linux-f2fs-devel, linux-kernel, duguowei
On 07/18, Guowei Du wrote:
> From: duguowei <duguowei@xiaomi.com>
>
> If there are more than one f2fs sbi, there will be more
> discard threads. But the comm is too long to show dev
> minor. So, change the default prefix of thread from
> "f2fs_discard" to "f2fs_dcd".
That looks quite unreadable. What about unmap?
>
> Before:
> $ ps -e | grep f2fs
> 1628 ? 00:00:00 f2fs_ckpt-7:10
> 1629 ? 00:00:00 f2fs_flush-7:10
> 1630 ? 00:00:00 f2fs_discard-7:
> 1631 ? 00:00:00 f2fs_gc-7:10
> 2030 ? 00:00:00 f2fs_ckpt-7:27
> 2031 ? 00:00:00 f2fs_flush-7:27
> 2032 ? 00:00:00 f2fs_discard-7:
> 2033 ? 00:00:00 f2fs_gc-7:27
>
> After:
> $ ps -e | grep f2fs
> 1628 ? 00:00:00 f2fs_ckpt-7:10
> 1629 ? 00:00:00 f2fs_flush-7:10
> 1630 ? 00:00:00 f2fs_dcd-7:10
> 1631 ? 00:00:00 f2fs_gc-7:10
> 2030 ? 00:00:00 f2fs_ckpt-7:27
> 2031 ? 00:00:00 f2fs_flush-7:27
> 2032 ? 00:00:00 f2fs_dcd-7:27
> 2033 ? 00:00:00 f2fs_gc-7:27
>
> Signed-off-by: duguowei <duguowei@xiaomi.com>
> ---
> fs/f2fs/segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 874c1b9c41a2..2eeefcbe62db 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -2018,7 +2018,7 @@ int f2fs_start_discard_thread(struct f2fs_sb_info *sbi)
> return 0;
>
> dcc->f2fs_issue_discard = kthread_run(issue_discard_thread, sbi,
> - "f2fs_discard-%u:%u", MAJOR(dev), MINOR(dev));
> + "f2fs_dcd-%u:%u", MAJOR(dev), MINOR(dev));
> if (IS_ERR(dcc->f2fs_issue_discard))
> err = PTR_ERR(dcc->f2fs_issue_discard);
>
> --
> 2.36.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: modify task name prefix
2022-07-22 2:43 ` Jaegeuk Kim
@ 2022-07-24 15:26 ` Chao Yu
-1 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2022-07-24 15:26 UTC (permalink / raw)
To: Jaegeuk Kim, Guowei Du; +Cc: linux-kernel, duguowei, linux-f2fs-devel
On 2022/7/22 10:43, Jaegeuk Kim wrote:
> On 07/18, Guowei Du wrote:
>> From: duguowei <duguowei@xiaomi.com>
>>
>> If there are more than one f2fs sbi, there will be more
>> discard threads. But the comm is too long to show dev
>> minor. So, change the default prefix of thread from
>> "f2fs_discard" to "f2fs_dcd".
>
> That looks quite unreadable. What about unmap?
FYI,
With commit d6986ce24fc0 ("kthread: dynamically allocate memory to store
kthread's full name"), it has chance to show full name of kthread when
it's not in low memory scenario.
Thanks,
>
>>
>> Before:
>> $ ps -e | grep f2fs
>> 1628 ? 00:00:00 f2fs_ckpt-7:10
>> 1629 ? 00:00:00 f2fs_flush-7:10
>> 1630 ? 00:00:00 f2fs_discard-7:
>> 1631 ? 00:00:00 f2fs_gc-7:10
>> 2030 ? 00:00:00 f2fs_ckpt-7:27
>> 2031 ? 00:00:00 f2fs_flush-7:27
>> 2032 ? 00:00:00 f2fs_discard-7:
>> 2033 ? 00:00:00 f2fs_gc-7:27
>>
>> After:
>> $ ps -e | grep f2fs
>> 1628 ? 00:00:00 f2fs_ckpt-7:10
>> 1629 ? 00:00:00 f2fs_flush-7:10
>> 1630 ? 00:00:00 f2fs_dcd-7:10
>> 1631 ? 00:00:00 f2fs_gc-7:10
>> 2030 ? 00:00:00 f2fs_ckpt-7:27
>> 2031 ? 00:00:00 f2fs_flush-7:27
>> 2032 ? 00:00:00 f2fs_dcd-7:27
>> 2033 ? 00:00:00 f2fs_gc-7:27
>>
>> Signed-off-by: duguowei <duguowei@xiaomi.com>
>> ---
>> fs/f2fs/segment.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>> index 874c1b9c41a2..2eeefcbe62db 100644
>> --- a/fs/f2fs/segment.c
>> +++ b/fs/f2fs/segment.c
>> @@ -2018,7 +2018,7 @@ int f2fs_start_discard_thread(struct f2fs_sb_info *sbi)
>> return 0;
>>
>> dcc->f2fs_issue_discard = kthread_run(issue_discard_thread, sbi,
>> - "f2fs_discard-%u:%u", MAJOR(dev), MINOR(dev));
>> + "f2fs_dcd-%u:%u", MAJOR(dev), MINOR(dev));
>> if (IS_ERR(dcc->f2fs_issue_discard))
>> err = PTR_ERR(dcc->f2fs_issue_discard);
>>
>> --
>> 2.36.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] f2fs: modify task name prefix
@ 2022-07-24 15:26 ` Chao Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2022-07-24 15:26 UTC (permalink / raw)
To: Jaegeuk Kim, Guowei Du; +Cc: linux-f2fs-devel, linux-kernel, duguowei
On 2022/7/22 10:43, Jaegeuk Kim wrote:
> On 07/18, Guowei Du wrote:
>> From: duguowei <duguowei@xiaomi.com>
>>
>> If there are more than one f2fs sbi, there will be more
>> discard threads. But the comm is too long to show dev
>> minor. So, change the default prefix of thread from
>> "f2fs_discard" to "f2fs_dcd".
>
> That looks quite unreadable. What about unmap?
FYI,
With commit d6986ce24fc0 ("kthread: dynamically allocate memory to store
kthread's full name"), it has chance to show full name of kthread when
it's not in low memory scenario.
Thanks,
>
>>
>> Before:
>> $ ps -e | grep f2fs
>> 1628 ? 00:00:00 f2fs_ckpt-7:10
>> 1629 ? 00:00:00 f2fs_flush-7:10
>> 1630 ? 00:00:00 f2fs_discard-7:
>> 1631 ? 00:00:00 f2fs_gc-7:10
>> 2030 ? 00:00:00 f2fs_ckpt-7:27
>> 2031 ? 00:00:00 f2fs_flush-7:27
>> 2032 ? 00:00:00 f2fs_discard-7:
>> 2033 ? 00:00:00 f2fs_gc-7:27
>>
>> After:
>> $ ps -e | grep f2fs
>> 1628 ? 00:00:00 f2fs_ckpt-7:10
>> 1629 ? 00:00:00 f2fs_flush-7:10
>> 1630 ? 00:00:00 f2fs_dcd-7:10
>> 1631 ? 00:00:00 f2fs_gc-7:10
>> 2030 ? 00:00:00 f2fs_ckpt-7:27
>> 2031 ? 00:00:00 f2fs_flush-7:27
>> 2032 ? 00:00:00 f2fs_dcd-7:27
>> 2033 ? 00:00:00 f2fs_gc-7:27
>>
>> Signed-off-by: duguowei <duguowei@xiaomi.com>
>> ---
>> fs/f2fs/segment.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>> index 874c1b9c41a2..2eeefcbe62db 100644
>> --- a/fs/f2fs/segment.c
>> +++ b/fs/f2fs/segment.c
>> @@ -2018,7 +2018,7 @@ int f2fs_start_discard_thread(struct f2fs_sb_info *sbi)
>> return 0;
>>
>> dcc->f2fs_issue_discard = kthread_run(issue_discard_thread, sbi,
>> - "f2fs_discard-%u:%u", MAJOR(dev), MINOR(dev));
>> + "f2fs_dcd-%u:%u", MAJOR(dev), MINOR(dev));
>> if (IS_ERR(dcc->f2fs_issue_discard))
>> err = PTR_ERR(dcc->f2fs_issue_discard);
>>
>> --
>> 2.36.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-24 15:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-18 8:10 [f2fs-dev] [PATCH] f2fs: modify task name prefix Guowei Du
2022-07-18 8:10 ` Guowei Du
2022-07-22 2:43 ` [f2fs-dev] " Jaegeuk Kim
2022-07-22 2:43 ` Jaegeuk Kim
2022-07-24 15:26 ` [f2fs-dev] " Chao Yu
2022-07-24 15:26 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.