From: Dan Carpenter <dan.carpenter@oracle.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Xin Ji <xji@analogixsemi.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/3] usb: typec: anx7411: Fix an array out of bounds
Date: Fri, 22 Jul 2022 09:25:42 +0300 [thread overview]
Message-ID: <YtpC5s4/AD8vFz+X@kili> (raw)
This should be ARRAY_SIZE() instead of sizeof(). ARRAY_SIZE is
4 and sizeof is 8.
Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/usb/typec/anx7411.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c
index b990376991f8..4f7a5cc968d0 100644
--- a/drivers/usb/typec/anx7411.c
+++ b/drivers/usb/typec/anx7411.c
@@ -992,7 +992,7 @@ static int anx7411_register_i2c_dummy_clients(struct anx7411_data *ctx,
int i;
u8 spi_addr;
- for (i = 0; i < sizeof(anx7411_i2c_addr); i++) {
+ for (i = 0; i < ARRAY_SIZE(anx7411_i2c_addr); i++) {
if (client->addr == (anx7411_i2c_addr[i].tcpc_address >> 1)) {
spi_addr = anx7411_i2c_addr[i].spi_address >> 1;
ctx->spi_client = i2c_new_dummy_device(client->adapter,
--
2.35.1
next reply other threads:[~2022-07-22 6:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 6:25 Dan Carpenter [this message]
2022-07-22 6:29 ` [PATCH 2/3] usb: typec: anx7411: fix error checking in anx7411_get_gpio_irq() Dan Carpenter
2022-07-22 7:16 ` Xin Ji
2022-07-22 6:29 ` [PATCH 3/3] usb: typec: anx7411: use semi-colons instead of commas Dan Carpenter
2022-07-22 7:17 ` Xin Ji
2022-07-22 7:15 ` [PATCH 1/3] usb: typec: anx7411: Fix an array out of bounds Xin Ji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtpC5s4/AD8vFz+X@kili \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.