From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BC67C433EF for ; Fri, 22 Jul 2022 17:05:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DE5314D1A1; Fri, 22 Jul 2022 13:05:15 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UHf1I5q9XAfh; Fri, 22 Jul 2022 13:05:14 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B2EDE4D156; Fri, 22 Jul 2022 13:05:14 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id AD7644D133 for ; Fri, 22 Jul 2022 13:05:13 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mDkOFQKs1CbU for ; Fri, 22 Jul 2022 13:05:12 -0400 (EDT) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 5C02F4D03B for ; Fri, 22 Jul 2022 13:05:12 -0400 (EDT) Received: by mail-pj1-f48.google.com with SMTP id v16-20020a17090abb9000b001f25244c65dso1318011pjr.2 for ; Fri, 22 Jul 2022 10:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EIQBR56/tJcNBR6OGH/TjjSrDbmF7UtKhywW9Hj0CUY=; b=ll/TN7RHrz3zet8Hb5kr/a0vsvXTl01rS1ijTZRx2gc/6AX7XZlUe25dJ6dyifZAkn Vf+suc2mp2Mo7OU49OfAsxW+vzt+VLB/Lhh9jZPHlIOKu6rw5SPMA7lwqcPFOSix23E3 xidaleqnYRsuyCOp0BBfofLrx0Wp2Js/csk6eMH+TEQ6i1btJRgPyQnM/sYt9CtFFiX0 9evjlfYud7iuG5e94WVg8HHecjPuvNJTUmjMIxGyFSb6Inhmlbfw5D9ZoAvyRw8qTdiN yv0FzfY0EXkrrnsH4/IYTex0Y7BMikYCyw6oHvxJX4k1BdSI043dkl2mssfj9SP1XxAZ TP/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EIQBR56/tJcNBR6OGH/TjjSrDbmF7UtKhywW9Hj0CUY=; b=g5iJPmOtULun8MATzdisEyGr3253CyyonsfrL5v32qHWJFfIIC61AEjUvq/FsS24Wj bdvN6NnztHGkd8Em9K+4WcYAvpkyYsYty2sMcnEAd6luPMJZi/xoPJjAMqAu7nVHtx4a rullAh5wXa3S5WnTrNFFkqxBVnKB5jpRXRxk8tImbxVOd9pq3xMMp6iyvYhjScMxk+WB TH/wIe1zOh4Xls5fQnZ/p9Egez7L2PVAtrAbexgY5DTKeWY5VQniFPTax6DeGk1Gb5O7 0Ajau6Y/50sJ3A/g3p589vZQ0Dnw33ZP/CjKdDII4XEjgc3jVuIwth1cpirXbrXF3fRq WtVQ== X-Gm-Message-State: AJIora9fooZPDl+LJY/AJ9WqiZIDkL8/CtPOCGMmXp7ebtOT2eWN7pb6 KF9VFQNmWTk3hnU8e5rqeHS02A== X-Google-Smtp-Source: AGRyM1vFlk9DkZd9UBK770fSURYjd+N7HQh0/nEt16WDmaIMu9aOsXfJxkshzokJ7v3u6ERX5w/m5A== X-Received: by 2002:a17:902:da85:b0:16c:bf2e:fac7 with SMTP id j5-20020a170902da8500b0016cbf2efac7mr784455plx.166.1658509510994; Fri, 22 Jul 2022 10:05:10 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:2571:bd04:907d:d32f]) by smtp.gmail.com with ESMTPSA id f26-20020a631f1a000000b00415320bc31dsm3632484pgf.32.2022.07.22.10.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jul 2022 10:05:10 -0700 (PDT) Date: Fri, 22 Jul 2022 10:04:59 -0700 From: Peter Collingbourne To: Marc Zyngier Subject: Re: [PATCH v2 3/7] mm: Add PG_arch_3 page flag Message-ID: References: <20220722015034.809663-1-pcc@google.com> <20220722015034.809663-4-pcc@google.com> <87leslxmf1.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87leslxmf1.wl-maz@kernel.org> Cc: kvm@vger.kernel.org, Catalin Marinas , Cornelia Huck , Steven Price , linux-arm-kernel@lists.infradead.org, Vincenzo Frascino , Will Deacon , kvmarm@lists.cs.columbia.edu, Evgenii Stepanov X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Jul 22, 2022 at 03:16:34PM +0100, Marc Zyngier wrote: > On Fri, 22 Jul 2022 02:50:29 +0100, > Peter Collingbourne wrote: > > > > As with PG_arch_2, this flag is only allowed on 64-bit architectures due > > to the shortage of bits available. It will be used by the arm64 MTE code > > in subsequent patches. > > > > Signed-off-by: Peter Collingbourne > > Cc: Will Deacon > > Cc: Marc Zyngier > > Cc: Steven Price > > [catalin.marinas@arm.com: added flag preserving in __split_huge_page_tail()] > > Signed-off-by: Catalin Marinas > > --- > > fs/proc/page.c | 1 + > > include/linux/page-flags.h | 1 + > > include/trace/events/mmflags.h | 7 ++++--- > > mm/huge_memory.c | 1 + > > 4 files changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/fs/proc/page.c b/fs/proc/page.c > > index a2873a617ae8..438b8aa7249d 100644 > > --- a/fs/proc/page.c > > +++ b/fs/proc/page.c > > @@ -220,6 +220,7 @@ u64 stable_page_flags(struct page *page) > > u |= kpf_copy_bit(k, KPF_ARCH, PG_arch_1); > > #ifdef CONFIG_64BIT > > u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_2); > > + u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_3); > > Are PG_arch_2 and PG_arch_3 supposed to share the same user bit in > /proc/kpageflags? This seems odd. No, that was an oversight, thanks for the catch. I will fix it up like so in v3. Peter diff --git a/fs/proc/page.c b/fs/proc/page.c index 438b8aa7249d..0129aa3cfb7a 100644 --- a/fs/proc/page.c +++ b/fs/proc/page.c @@ -220,7 +220,7 @@ u64 stable_page_flags(struct page *page) u |= kpf_copy_bit(k, KPF_ARCH, PG_arch_1); #ifdef CONFIG_64BIT u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_2); - u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_3); + u |= kpf_copy_bit(k, KPF_ARCH_3, PG_arch_3); #endif return u; diff --git a/include/linux/kernel-page-flags.h b/include/linux/kernel-page-flags.h index eee1877a354e..859f4b0c1b2b 100644 --- a/include/linux/kernel-page-flags.h +++ b/include/linux/kernel-page-flags.h @@ -18,5 +18,6 @@ #define KPF_UNCACHED 39 #define KPF_SOFTDIRTY 40 #define KPF_ARCH_2 41 +#define KPF_ARCH_3 42 #endif /* LINUX_KERNEL_PAGE_FLAGS_H */ diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c index 381dcc00cb62..364373f5bba0 100644 --- a/tools/vm/page-types.c +++ b/tools/vm/page-types.c @@ -79,6 +79,7 @@ #define KPF_UNCACHED 39 #define KPF_SOFTDIRTY 40 #define KPF_ARCH_2 41 +#define KPF_ARCH_3 42 /* [47-] take some arbitrary free slots for expanding overloaded flags * not part of kernel API @@ -138,6 +139,7 @@ static const char * const page_flag_names[] = { [KPF_UNCACHED] = "c:uncached", [KPF_SOFTDIRTY] = "f:softdirty", [KPF_ARCH_2] = "H:arch_2", + [KPF_ARCH_3] = "H:arch_3", [KPF_ANON_EXCLUSIVE] = "d:anon_exclusive", [KPF_READAHEAD] = "I:readahead", _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42EE6C43334 for ; Fri, 22 Jul 2022 17:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kUJdbNznVvUdPvTi2YKH7I/OA4e5l8wjJwK000+smI4=; b=SZ3WBL3ojIXEYl HzbYk4HoXXw59/for57RdE5mC8sIxCWjBEvoIknOfgtzXthh2LKwy6q9LU/lyfZkdgq/1yxweCHJP 5fOPD3XUz0F8j6y0BFR0jczFInMbKYHuUmdy53lJUinplkJRvIzVaynT36FA7GfZJsXZdg60PYgnl hy03/kvdmQuPkxh4PTO+bKYM8OHikJrgv6IN5Aoi0pH/rTsOPNGbp5dnMktBHweKjWzwi230cJ+Wb RUUEzaSFGvd3pZbgmc8ofxy63dt5h8lDf10C5rloQLX1OrW0YRffnG0B1wtagK/KfuB3qOA1fHuw6 JWM85O4YD+P+YLfg+nQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEw5Y-008CbP-1d; Fri, 22 Jul 2022 17:05:20 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEw5V-008CU5-0t for linux-arm-kernel@lists.infradead.org; Fri, 22 Jul 2022 17:05:18 +0000 Received: by mail-pj1-x1030.google.com with SMTP id o5-20020a17090a3d4500b001ef76490983so4731509pjf.2 for ; Fri, 22 Jul 2022 10:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EIQBR56/tJcNBR6OGH/TjjSrDbmF7UtKhywW9Hj0CUY=; b=ll/TN7RHrz3zet8Hb5kr/a0vsvXTl01rS1ijTZRx2gc/6AX7XZlUe25dJ6dyifZAkn Vf+suc2mp2Mo7OU49OfAsxW+vzt+VLB/Lhh9jZPHlIOKu6rw5SPMA7lwqcPFOSix23E3 xidaleqnYRsuyCOp0BBfofLrx0Wp2Js/csk6eMH+TEQ6i1btJRgPyQnM/sYt9CtFFiX0 9evjlfYud7iuG5e94WVg8HHecjPuvNJTUmjMIxGyFSb6Inhmlbfw5D9ZoAvyRw8qTdiN yv0FzfY0EXkrrnsH4/IYTex0Y7BMikYCyw6oHvxJX4k1BdSI043dkl2mssfj9SP1XxAZ TP/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EIQBR56/tJcNBR6OGH/TjjSrDbmF7UtKhywW9Hj0CUY=; b=ryvbszOIf6MdLXnEXEhrdSdoxaaphMXRNdLElQCGOtM4k4anHwhmUUaOvQnqF2u621 asbSKOZuByns06NM7cUBsyil2PQizN/1jNvpBGeObhasxTXArxTAB9WxZ6eukdezOTl5 ShPXWL4Ly9o6n9g4dv9MW304QOA7h9G+zOkRpdpFCJD6EMGa8Knva8ffyurPy7R8Rwa2 HG5d6VDpizDrobeKmuPTG9VjdrJ7kT/e0J0dBXUnUXWNM0jYnkgTQti3s/9AF3BDMek5 VONyPSlmnxRqN5xkCsPpKBgjTUwsThRM+LGrZ1QvSKDqcsI1mhKeb3+BRhFvnz8oSD5q xw5Q== X-Gm-Message-State: AJIora/ZnMCecXm1vgrKNe6ZbDb4dkwjlWS8UUew0YQEDB3S60rRSBE9 UBcenxsjfIXjjh4FIySLbYzZ6w== X-Google-Smtp-Source: AGRyM1vFlk9DkZd9UBK770fSURYjd+N7HQh0/nEt16WDmaIMu9aOsXfJxkshzokJ7v3u6ERX5w/m5A== X-Received: by 2002:a17:902:da85:b0:16c:bf2e:fac7 with SMTP id j5-20020a170902da8500b0016cbf2efac7mr784455plx.166.1658509510994; Fri, 22 Jul 2022 10:05:10 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:2571:bd04:907d:d32f]) by smtp.gmail.com with ESMTPSA id f26-20020a631f1a000000b00415320bc31dsm3632484pgf.32.2022.07.22.10.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jul 2022 10:05:10 -0700 (PDT) Date: Fri, 22 Jul 2022 10:04:59 -0700 From: Peter Collingbourne To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Cornelia Huck , Catalin Marinas , Will Deacon , Evgenii Stepanov , kvm@vger.kernel.org, Steven Price , Vincenzo Frascino Subject: Re: [PATCH v2 3/7] mm: Add PG_arch_3 page flag Message-ID: References: <20220722015034.809663-1-pcc@google.com> <20220722015034.809663-4-pcc@google.com> <87leslxmf1.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87leslxmf1.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220722_100517_092798_C6E53AB1 X-CRM114-Status: GOOD ( 20.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 22, 2022 at 03:16:34PM +0100, Marc Zyngier wrote: > On Fri, 22 Jul 2022 02:50:29 +0100, > Peter Collingbourne wrote: > > > > As with PG_arch_2, this flag is only allowed on 64-bit architectures due > > to the shortage of bits available. It will be used by the arm64 MTE code > > in subsequent patches. > > > > Signed-off-by: Peter Collingbourne > > Cc: Will Deacon > > Cc: Marc Zyngier > > Cc: Steven Price > > [catalin.marinas@arm.com: added flag preserving in __split_huge_page_tail()] > > Signed-off-by: Catalin Marinas > > --- > > fs/proc/page.c | 1 + > > include/linux/page-flags.h | 1 + > > include/trace/events/mmflags.h | 7 ++++--- > > mm/huge_memory.c | 1 + > > 4 files changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/fs/proc/page.c b/fs/proc/page.c > > index a2873a617ae8..438b8aa7249d 100644 > > --- a/fs/proc/page.c > > +++ b/fs/proc/page.c > > @@ -220,6 +220,7 @@ u64 stable_page_flags(struct page *page) > > u |= kpf_copy_bit(k, KPF_ARCH, PG_arch_1); > > #ifdef CONFIG_64BIT > > u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_2); > > + u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_3); > > Are PG_arch_2 and PG_arch_3 supposed to share the same user bit in > /proc/kpageflags? This seems odd. No, that was an oversight, thanks for the catch. I will fix it up like so in v3. Peter diff --git a/fs/proc/page.c b/fs/proc/page.c index 438b8aa7249d..0129aa3cfb7a 100644 --- a/fs/proc/page.c +++ b/fs/proc/page.c @@ -220,7 +220,7 @@ u64 stable_page_flags(struct page *page) u |= kpf_copy_bit(k, KPF_ARCH, PG_arch_1); #ifdef CONFIG_64BIT u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_2); - u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_3); + u |= kpf_copy_bit(k, KPF_ARCH_3, PG_arch_3); #endif return u; diff --git a/include/linux/kernel-page-flags.h b/include/linux/kernel-page-flags.h index eee1877a354e..859f4b0c1b2b 100644 --- a/include/linux/kernel-page-flags.h +++ b/include/linux/kernel-page-flags.h @@ -18,5 +18,6 @@ #define KPF_UNCACHED 39 #define KPF_SOFTDIRTY 40 #define KPF_ARCH_2 41 +#define KPF_ARCH_3 42 #endif /* LINUX_KERNEL_PAGE_FLAGS_H */ diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c index 381dcc00cb62..364373f5bba0 100644 --- a/tools/vm/page-types.c +++ b/tools/vm/page-types.c @@ -79,6 +79,7 @@ #define KPF_UNCACHED 39 #define KPF_SOFTDIRTY 40 #define KPF_ARCH_2 41 +#define KPF_ARCH_3 42 /* [47-] take some arbitrary free slots for expanding overloaded flags * not part of kernel API @@ -138,6 +139,7 @@ static const char * const page_flag_names[] = { [KPF_UNCACHED] = "c:uncached", [KPF_SOFTDIRTY] = "f:softdirty", [KPF_ARCH_2] = "H:arch_2", + [KPF_ARCH_3] = "H:arch_3", [KPF_ANON_EXCLUSIVE] = "d:anon_exclusive", [KPF_READAHEAD] = "I:readahead", _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F71CC43334 for ; Fri, 22 Jul 2022 17:05:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234251AbiGVRFO (ORCPT ); Fri, 22 Jul 2022 13:05:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233662AbiGVRFM (ORCPT ); Fri, 22 Jul 2022 13:05:12 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E85DD7650 for ; Fri, 22 Jul 2022 10:05:11 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id x24-20020a17090ab01800b001f21556cf48so8682173pjq.4 for ; Fri, 22 Jul 2022 10:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EIQBR56/tJcNBR6OGH/TjjSrDbmF7UtKhywW9Hj0CUY=; b=ll/TN7RHrz3zet8Hb5kr/a0vsvXTl01rS1ijTZRx2gc/6AX7XZlUe25dJ6dyifZAkn Vf+suc2mp2Mo7OU49OfAsxW+vzt+VLB/Lhh9jZPHlIOKu6rw5SPMA7lwqcPFOSix23E3 xidaleqnYRsuyCOp0BBfofLrx0Wp2Js/csk6eMH+TEQ6i1btJRgPyQnM/sYt9CtFFiX0 9evjlfYud7iuG5e94WVg8HHecjPuvNJTUmjMIxGyFSb6Inhmlbfw5D9ZoAvyRw8qTdiN yv0FzfY0EXkrrnsH4/IYTex0Y7BMikYCyw6oHvxJX4k1BdSI043dkl2mssfj9SP1XxAZ TP/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EIQBR56/tJcNBR6OGH/TjjSrDbmF7UtKhywW9Hj0CUY=; b=0zgRZ+AO672icIisJNfLYbK8kV/ZFUsj0YzAT0rles/1rBrfyF8oRa/ySpcXVP1Mfl YFb00dlgn9A35JMJh2oJWyrQQ75go0puGurHd9n17x5Iqmin8B4RmCxgYdvxaisFhUlC krbjiL3EE1lriTRs+IcTpPQ+pUb0eNj0PC6nTnsnrlM8vA3p3CMiIS4S7QYThUlg3u0p SNUNGrqxd1SdqiQq3zqPs8K4CUToRUB9UcmmSek9TS4SJRo/91pKuqeB2sIlmvqPky7Y FcRPcB/exta0lGt8mYb52gdok1ZsW44D0OJLToDrGCH86haxCxH/W78nzDcWLzrzeelF NdWw== X-Gm-Message-State: AJIora8L4JciaLVHHU+Fwx8Bu81YzWVl1FThODlGUzeihZuTa4ktaq29 96ltrfoKsTPdNvUS8t3mTitY3g== X-Google-Smtp-Source: AGRyM1vFlk9DkZd9UBK770fSURYjd+N7HQh0/nEt16WDmaIMu9aOsXfJxkshzokJ7v3u6ERX5w/m5A== X-Received: by 2002:a17:902:da85:b0:16c:bf2e:fac7 with SMTP id j5-20020a170902da8500b0016cbf2efac7mr784455plx.166.1658509510994; Fri, 22 Jul 2022 10:05:10 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:2571:bd04:907d:d32f]) by smtp.gmail.com with ESMTPSA id f26-20020a631f1a000000b00415320bc31dsm3632484pgf.32.2022.07.22.10.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jul 2022 10:05:10 -0700 (PDT) Date: Fri, 22 Jul 2022 10:04:59 -0700 From: Peter Collingbourne To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Cornelia Huck , Catalin Marinas , Will Deacon , Evgenii Stepanov , kvm@vger.kernel.org, Steven Price , Vincenzo Frascino Subject: Re: [PATCH v2 3/7] mm: Add PG_arch_3 page flag Message-ID: References: <20220722015034.809663-1-pcc@google.com> <20220722015034.809663-4-pcc@google.com> <87leslxmf1.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87leslxmf1.wl-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Jul 22, 2022 at 03:16:34PM +0100, Marc Zyngier wrote: > On Fri, 22 Jul 2022 02:50:29 +0100, > Peter Collingbourne wrote: > > > > As with PG_arch_2, this flag is only allowed on 64-bit architectures due > > to the shortage of bits available. It will be used by the arm64 MTE code > > in subsequent patches. > > > > Signed-off-by: Peter Collingbourne > > Cc: Will Deacon > > Cc: Marc Zyngier > > Cc: Steven Price > > [catalin.marinas@arm.com: added flag preserving in __split_huge_page_tail()] > > Signed-off-by: Catalin Marinas > > --- > > fs/proc/page.c | 1 + > > include/linux/page-flags.h | 1 + > > include/trace/events/mmflags.h | 7 ++++--- > > mm/huge_memory.c | 1 + > > 4 files changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/fs/proc/page.c b/fs/proc/page.c > > index a2873a617ae8..438b8aa7249d 100644 > > --- a/fs/proc/page.c > > +++ b/fs/proc/page.c > > @@ -220,6 +220,7 @@ u64 stable_page_flags(struct page *page) > > u |= kpf_copy_bit(k, KPF_ARCH, PG_arch_1); > > #ifdef CONFIG_64BIT > > u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_2); > > + u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_3); > > Are PG_arch_2 and PG_arch_3 supposed to share the same user bit in > /proc/kpageflags? This seems odd. No, that was an oversight, thanks for the catch. I will fix it up like so in v3. Peter diff --git a/fs/proc/page.c b/fs/proc/page.c index 438b8aa7249d..0129aa3cfb7a 100644 --- a/fs/proc/page.c +++ b/fs/proc/page.c @@ -220,7 +220,7 @@ u64 stable_page_flags(struct page *page) u |= kpf_copy_bit(k, KPF_ARCH, PG_arch_1); #ifdef CONFIG_64BIT u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_2); - u |= kpf_copy_bit(k, KPF_ARCH_2, PG_arch_3); + u |= kpf_copy_bit(k, KPF_ARCH_3, PG_arch_3); #endif return u; diff --git a/include/linux/kernel-page-flags.h b/include/linux/kernel-page-flags.h index eee1877a354e..859f4b0c1b2b 100644 --- a/include/linux/kernel-page-flags.h +++ b/include/linux/kernel-page-flags.h @@ -18,5 +18,6 @@ #define KPF_UNCACHED 39 #define KPF_SOFTDIRTY 40 #define KPF_ARCH_2 41 +#define KPF_ARCH_3 42 #endif /* LINUX_KERNEL_PAGE_FLAGS_H */ diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c index 381dcc00cb62..364373f5bba0 100644 --- a/tools/vm/page-types.c +++ b/tools/vm/page-types.c @@ -79,6 +79,7 @@ #define KPF_UNCACHED 39 #define KPF_SOFTDIRTY 40 #define KPF_ARCH_2 41 +#define KPF_ARCH_3 42 /* [47-] take some arbitrary free slots for expanding overloaded flags * not part of kernel API @@ -138,6 +139,7 @@ static const char * const page_flag_names[] = { [KPF_UNCACHED] = "c:uncached", [KPF_SOFTDIRTY] = "f:softdirty", [KPF_ARCH_2] = "H:arch_2", + [KPF_ARCH_3] = "H:arch_3", [KPF_ANON_EXCLUSIVE] = "d:anon_exclusive", [KPF_READAHEAD] = "I:readahead",