From: Wolfram Sang <wsa@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@somainline.org>,
Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] i2c: qcom-geni: Silence NACK and GENI_TIMEOUT
Date: Sun, 24 Jul 2022 07:23:07 +0200 [thread overview]
Message-ID: <YtzXO71zIAUThyF1@shikoro> (raw)
In-Reply-To: <20220717035027.2135106-4-bjorn.andersson@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
On Sat, Jul 16, 2022 at 08:50:27PM -0700, Bjorn Andersson wrote:
> Turn NACK and GENI_TIMEOUT into debug prints to silence the kernel log
> when running things such as i2cdetect to scan the bus.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
As mentioned, I squashed it with the previous patch.
> + case NACK:
> + case GENI_TIMEOUT:
> + dev_dbg(gi2c->se.dev, "%s\n", gi2c_log[err].msg);
> + break;
Additional note: the dbg messages in this function are superfluous. We
already have all this information with the tracepoints in i2c_transfer.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-07-24 5:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-17 3:50 [PATCH 0/3] i2c: qcom-geni: Make it possible to run i2cdetect Bjorn Andersson
2022-07-17 3:50 ` [PATCH 1/3] i2c: qcom-geni: Use the correct return value Bjorn Andersson
2022-07-18 5:36 ` Vinod Koul
2022-07-18 22:28 ` Bjorn Andersson
2022-07-19 20:36 ` Andrew Halaney
2022-07-20 4:31 ` Vinod Koul
2022-07-24 5:04 ` Wolfram Sang
2022-07-24 7:30 ` Johan Hovold
2022-07-24 18:37 ` Wolfram Sang
2022-07-24 18:39 ` Wolfram Sang
2022-07-17 3:50 ` [PATCH 2/3] i2c: qcom-geni: Propagate GENI_ABORT_DONE to geni_i2c_abort_xfer() Bjorn Andersson
2022-07-18 5:36 ` Vinod Koul
2022-07-19 20:50 ` Andrew Halaney
2022-07-19 20:57 ` Andrew Halaney
2022-07-24 5:15 ` Wolfram Sang
2022-07-24 5:15 ` Wolfram Sang
2022-07-17 3:50 ` [PATCH 3/3] i2c: qcom-geni: Silence NACK and GENI_TIMEOUT Bjorn Andersson
2022-07-18 5:37 ` Vinod Koul
2022-07-24 5:23 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtzXO71zIAUThyF1@shikoro \
--to=wsa@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.