From: Liam Beguin <liambeguin@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 1/2] iio: test: Mark file local structure arrays static.
Date: Sun, 7 Aug 2022 11:52:29 -0400 [thread overview]
Message-ID: <Yu/fvT62LkY0b94V@shaak> (raw)
In-Reply-To: <20220807145457.646062-2-jic23@kernel.org>
On Sun, Aug 07, 2022 at 03:54:56PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Warning cleanup:
> drivers/iio/test/iio-test-rescale.c:32:30: warning: symbol 'scale_cases' was not declared. Should it be static?
> drivers/iio/test/iio-test-rescale.c:480:30: warning: symbol 'offset_cases' was not declared. Should it be static?
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Liam Beguin <liambeguin@gmail.com>
Reviewed-by: Liam Beguin <liambeguin@gmail.com>
> ---
> drivers/iio/test/iio-test-rescale.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/test/iio-test-rescale.c b/drivers/iio/test/iio-test-rescale.c
> index cc782ccff880..31ee55a6faed 100644
> --- a/drivers/iio/test/iio-test-rescale.c
> +++ b/drivers/iio/test/iio-test-rescale.c
> @@ -29,7 +29,7 @@ struct rescale_tc_data {
> const char *expected_off;
> };
>
> -const struct rescale_tc_data scale_cases[] = {
> +static const struct rescale_tc_data scale_cases[] = {
> /*
> * Typical use cases
> */
> @@ -477,7 +477,7 @@ const struct rescale_tc_data scale_cases[] = {
> },
> };
>
> -const struct rescale_tc_data offset_cases[] = {
> +static const struct rescale_tc_data offset_cases[] = {
> /*
> * Typical use cases
> */
> --
> 2.37.1
>
next prev parent reply other threads:[~2022-08-07 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-07 14:54 [PATCH 0/2] IIO: Clean up a couple of warnings that snuck in Jonathan Cameron
2022-08-07 14:54 ` [PATCH 1/2] iio: test: Mark file local structure arrays static Jonathan Cameron
2022-08-07 15:52 ` Liam Beguin [this message]
2022-08-07 14:54 ` [PATCH 2/2] iio: light: cm32181: Mark the dev_pm_ops static Jonathan Cameron
2022-08-08 9:15 ` [PATCH 0/2] IIO: Clean up a couple of warnings that snuck in Andy Shevchenko
2022-08-13 15:57 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yu/fvT62LkY0b94V@shaak \
--to=liambeguin@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.